Skip to content

Commit 6e79888

Browse files
author
Julien Ruaux
committed
style: Cleaned up code
1 parent 9044bfa commit 6e79888

File tree

4 files changed

+4
-21
lines changed

4 files changed

+4
-21
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<github.owner>redis-field-engineering</github.owner>
2727
<github.repo>redis-sql-trino</github.repo>
2828

29-
<lettucemod.version>3.2.1</lettucemod.version>
29+
<lettucemod.version>3.3.1</lettucemod.version>
3030
<lettuce.version>6.2.2.RELEASE</lettuce.version>
3131
<testcontainers-redis.version>1.6.3</testcontainers-redis.version>
3232
<ulid.version>5.1.0</ulid.version>

src/main/java/com/redis/trino/RediSearchPageSink.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@
4848
import java.util.concurrent.CompletableFuture;
4949

5050
import com.github.f4b6a3.ulid.UlidFactory;
51-
import com.google.common.collect.ImmutableList;
5251
import com.google.common.primitives.Shorts;
5352
import com.google.common.primitives.SignedBytes;
5453
import com.redis.lettucemod.api.StatefulRedisModulesConnection;
@@ -204,7 +203,7 @@ public static String value(Type type, Block block, int position) {
204203

205204
@Override
206205
public CompletableFuture<Collection<Slice>> finish() {
207-
return completedFuture(ImmutableList.of());
206+
return completedFuture(List.of());
208207
}
209208

210209
@Override

src/main/java/com/redis/trino/RediSearchTranslator.java

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -25,19 +25,12 @@
2525

2626
import static java.util.Objects.requireNonNull;
2727

28-
import java.util.Collections;
29-
import java.util.List;
30-
import java.util.Optional;
31-
3228
import com.redis.lettucemod.search.AggregateOptions;
3329
import com.redis.lettucemod.search.CursorOptions;
3430
import com.redis.lettucemod.search.Limit;
3531
import com.redis.lettucemod.search.SearchOptions;
3632
import com.redis.lettucemod.search.SearchOptions.Builder;
3733

38-
import io.lettuce.core.RedisURI;
39-
import io.trino.spi.HostAddress;
40-
4134
public class RediSearchTranslator {
4235

4336
private final RediSearchQueryBuilder queryBuilder = new RediSearchQueryBuilder();
@@ -52,15 +45,6 @@ public RediSearchConfig getConfig() {
5245
return config;
5346
}
5447

55-
public List<HostAddress> getAddresses() {
56-
Optional<String> uri = config.getUri();
57-
if (uri.isPresent()) {
58-
RedisURI redisURI = RedisURI.create(uri.get());
59-
return Collections.singletonList(HostAddress.fromParts(redisURI.getHost(), redisURI.getPort()));
60-
}
61-
return Collections.emptyList();
62-
}
63-
6448
public static class Aggregation {
6549
private String index;
6650
private String query;

src/test/java/com/redis/trino/RediSearchServer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ public class RediSearchServer implements Closeable {
1212

1313
public RediSearchServer() {
1414
this.dockerContainer = new RedisStackContainer(
15-
RedisStackContainer.DEFAULT_IMAGE_NAME.withTag(RedisStackContainer.DEFAULT_TAG))
16-
.withEnv("REDISEARCH_ARGS", "MAXAGGREGATERESULTS 1000000");
15+
RedisStackContainer.DEFAULT_IMAGE_NAME.withTag(RedisStackContainer.DEFAULT_TAG));
16+
this.dockerContainer.withEnv("REDISEARCH_ARGS", "MAXAGGREGATERESULTS -1");
1717
this.dockerContainer.start();
1818
this.context = new RedisTestContext(dockerContainer);
1919
}

0 commit comments

Comments
 (0)