Smoke test all binaries using matrix build #1115
Open
+158
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
force-pushed
the
1114-smoke-tests-matrix
branch
2 times, most recently
from
3747ab9 to
ab147a1
Compare
Contributor
Author
|
(Draft because it's not working and I still need to add windows) |
datho7561
force-pushed
the
1114-smoke-tests-matrix
branch
3 times, most recently
from
b8ae47b to
59431a3
Compare
Contributor
Author
|
Not pleased with having to wait for all the binaries to build in order to run the tests with them; I'll have to look into if I can improve that |
datho7561
force-pushed
the
1114-smoke-tests-matrix
branch
6 times, most recently
from
9beaf9e to
f0c9738
Compare
Contributor
Author
|
|
datho7561
force-pushed
the
1114-smoke-tests-matrix
branch
9 times, most recently
from
690902c to
44b55ce
Compare
datho7561
changed the title
Contributor
Author
|
Ugh seems like I'll need to adjust the timeouts for Windows for it to be consistent :( |
datho7561
force-pushed
the
1114-smoke-tests-matrix
branch
from
44b55ce to
94c43b3
Compare
Contributor
Author
|
going to push a few blank amends to check the consistency of the tests passing. |
datho7561
force-pushed
the
1114-smoke-tests-matrix
branch
from
94c43b3 to
812cc85
Compare
This lets us smoke test the binaries for every platform instead of just linux x86_64. The builds are run in parallel, which looks a bit messy in the output but hopefully will mean it takes around 10 minutes to get all the results. I wrote the windows part so that it can be expanded to include arm64 in the future. Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
1114-smoke-tests-matrix
branch
from
812cc85 to
5705851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us smoke test the binaries for every platform instead of just linux x86_64.
The builds are run in parallel, which looks a bit messy in the output but hopefully will mean it takes around 10 minutes to get all the results.
I wrote the windows part so that it can be expanded to include arm64 in the future.
Also fixes a bug preventing the linux arm64 binary from being used.