Skip to content

Commit ceeef17

Browse files
committed
Extract more hardcoded strings from ApplicationSetList && Run i18n extraction
Signed-off-by: Atif Ali <atali@redhat.com>
1 parent 78b2e3d commit ceeef17

File tree

14 files changed

+234
-82
lines changed

14 files changed

+234
-82
lines changed

locales/en/plugin__gitops-plugin.json

Lines changed: 39 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,13 @@
8181
"There are no resources associated with the application.": "There are no resources associated with the application.",
8282
"Application resources": "Application resources",
8383
"Name": "Name",
84+
"Namespace": "Namespace",
85+
"Sync Wave": "Sync Wave",
86+
"Kind": "Kind",
87+
"Type": "Type",
88+
"Repository": "Repository",
89+
"Path / Chart": "Path / Chart",
90+
"Ref": "Ref",
8491
"No source": "No source",
8592
"Error. There must at least one source in the application.": "Error. There must at least one source in the application.",
8693
"Application sources": "Application sources",
@@ -101,8 +108,25 @@
101108
"Finished At": "Finished At",
102109
"When the operation was finished.": "When the operation was finished.",
103110
"Resources Last Synced": "Resources Last Synced",
111+
"Status": "Status",
112+
"Hook": "Hook",
104113
"There is no history associated with the application.": "There is no history associated with the application.",
114+
"ID": "ID",
115+
"Deploy Started At": "Deploy Started At",
116+
"Deployed At": "Deployed At",
117+
"Revision(s) and Source Repo URL(s)": "Revision(s) and Source Repo URL(s)",
118+
"Current health status of the ApplicationSet.": "Current health status of the ApplicationSet.",
119+
"Generated Apps": "Generated Apps",
120+
"Number of applications generated by this ApplicationSet.": "Number of applications generated by this ApplicationSet.",
121+
"applications": "applications",
122+
"application": "application",
105123
"Generators": "Generators",
124+
"Number of generators configured in this ApplicationSet.": "Number of generators configured in this ApplicationSet.",
125+
"generators": "generators",
126+
"generator": "generator",
127+
"App Project": "App Project",
128+
"Argo CD project that this ApplicationSet belongs to.": "Argo CD project that this ApplicationSet belongs to.",
129+
"Git repository URL where the ApplicationSet configuration is stored.": "Git repository URL where the ApplicationSet configuration is stored.",
106130
"Applications": "Argo CD Applications",
107131
"Promote": "Promote",
108132
"Full Promote": "Full Promote",
@@ -118,6 +142,16 @@
118142
"There are no Argo Rollouts in all projects.": "There are no Argo Rollouts in all projects.",
119143
"Unable to load data": "Unable to load data",
120144
"There was an error retrieving applications. Check your connection and reload the page.": "There was an error retrieving applications. Check your connection and reload the page.",
145+
"Rollouts": "Rollouts",
146+
"Create Rollout": "Create Rollout",
147+
"Topology view": "Topology view",
148+
"Graph view": "Graph view",
149+
"Pods": "Pods",
150+
"Labels": "Labels",
151+
"Selector": "Selector",
152+
"Last Updated": "Last Updated",
153+
"No labels": "No labels",
154+
"Rollout Status": "Rollout Status",
121155
"No matching Argo CD Applications": "No matching Argo CD Applications",
122156
"No Argo CD Applications": "No Argo CD Applications",
123157
"No Argo CD Applications match the label filter": "No Argo CD Applications match the label filter",
@@ -134,13 +168,10 @@
134168
"There was an error retrieving applicationsets. Check your connection and reload the page.": "There was an error retrieving applicationsets. Check your connection and reload the page.",
135169
"ApplicationSets": "Argo CD ApplicationSets",
136170
"Create ApplicationSet": "Create ApplicationSet",
137-
"Namespace": "Namespace",
138-
"Generated Apps": "Generated Apps",
139171
"Created At": "Created At",
140172
"View in Argo CD": "View in Argo CD",
141173
"Name must be unique within a namespace.": "Name must be unique within a namespace.",
142174
"Namespace defines the space within which each name must be unique.": "Namespace defines the space within which each name must be unique.",
143-
"Labels": "Labels",
144175
"Map of string keys and values that can be used to organize and categorize (scope and select) objects.": "Map of string keys and values that can be used to organize and categorize (scope and select) objects.",
145176
" Edit": " Edit",
146177
"Annotations": "Annotations",
@@ -159,5 +190,9 @@
159190
"Edit ApplicationSet": "Edit ApplicationSet",
160191
"Delete ApplicationSet": "Delete ApplicationSet",
161192
"Actions": "Actions",
162-
"You don't have permission to perform this action": "You don't have permission to perform this action"
193+
"You don't have permission to perform this action": "You don't have permission to perform this action",
194+
"Edit": "Edit",
195+
"annotations": "annotations",
196+
"annotation": "annotation",
197+
"No owner": "No owner"
163198
}

locales/ja/plugin__gitops-plugin.json

Lines changed: 39 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,13 @@
8181
"There are no resources associated with the application.": "There are no resources associated with the application.",
8282
"Application resources": "Application resources",
8383
"Name": "Name",
84+
"Namespace": "Namespace",
85+
"Sync Wave": "Sync Wave",
86+
"Kind": "Kind",
87+
"Type": "Type",
88+
"Repository": "Repository",
89+
"Path / Chart": "Path / Chart",
90+
"Ref": "Ref",
8491
"No source": "No source",
8592
"Error. There must at least one source in the application.": "Error. There must at least one source in the application.",
8693
"Application sources": "Application sources",
@@ -101,8 +108,25 @@
101108
"Finished At": "Finished At",
102109
"When the operation was finished.": "When the operation was finished.",
103110
"Resources Last Synced": "Resources Last Synced",
111+
"Status": "Status",
112+
"Hook": "Hook",
104113
"There is no history associated with the application.": "There is no history associated with the application.",
114+
"ID": "ID",
115+
"Deploy Started At": "Deploy Started At",
116+
"Deployed At": "Deployed At",
117+
"Revision(s) and Source Repo URL(s)": "Revision(s) and Source Repo URL(s)",
118+
"Current health status of the ApplicationSet.": "Current health status of the ApplicationSet.",
119+
"Generated Apps": "Generated Apps",
120+
"Number of applications generated by this ApplicationSet.": "Number of applications generated by this ApplicationSet.",
121+
"applications": "applications",
122+
"application": "application",
105123
"Generators": "Generators",
124+
"Number of generators configured in this ApplicationSet.": "Number of generators configured in this ApplicationSet.",
125+
"generators": "generators",
126+
"generator": "generator",
127+
"App Project": "App Project",
128+
"Argo CD project that this ApplicationSet belongs to.": "Argo CD project that this ApplicationSet belongs to.",
129+
"Git repository URL where the ApplicationSet configuration is stored.": "Git repository URL where the ApplicationSet configuration is stored.",
106130
"Applications": "Applications",
107131
"Promote": "Promote",
108132
"Full Promote": "Full Promote",
@@ -118,6 +142,16 @@
118142
"There are no Argo Rollouts in all projects.": "There are no Argo Rollouts in all projects.",
119143
"Unable to load data": "Unable to load data",
120144
"There was an error retrieving applications. Check your connection and reload the page.": "There was an error retrieving applications. Check your connection and reload the page.",
145+
"Rollouts": "Rollouts",
146+
"Create Rollout": "Create Rollout",
147+
"Topology view": "Topology view",
148+
"Graph view": "Graph view",
149+
"Pods": "Pods",
150+
"Labels": "Labels",
151+
"Selector": "Selector",
152+
"Last Updated": "Last Updated",
153+
"No labels": "No labels",
154+
"Rollout Status": "Rollout Status",
121155
"No matching Argo CD Applications": "No matching Argo CD Applications",
122156
"No Argo CD Applications": "No Argo CD Applications",
123157
"No Argo CD Applications match the label filter": "No Argo CD Applications match the label filter",
@@ -134,13 +168,10 @@
134168
"There was an error retrieving applicationsets. Check your connection and reload the page.": "There was an error retrieving applicationsets. Check your connection and reload the page.",
135169
"ApplicationSets": "ApplicationSets",
136170
"Create ApplicationSet": "Create ApplicationSet",
137-
"Namespace": "Namespace",
138-
"Generated Apps": "Generated Apps",
139171
"Created At": "Created At",
140172
"View in Argo CD": "View in Argo CD",
141173
"Name must be unique within a namespace.": "Name must be unique within a namespace.",
142174
"Namespace defines the space within which each name must be unique.": "Namespace defines the space within which each name must be unique.",
143-
"Labels": "Labels",
144175
"Map of string keys and values that can be used to organize and categorize (scope and select) objects.": "Map of string keys and values that can be used to organize and categorize (scope and select) objects.",
145176
" Edit": " Edit",
146177
"Annotations": "Annotations",
@@ -159,5 +190,9 @@
159190
"Edit ApplicationSet": "Edit ApplicationSet",
160191
"Delete ApplicationSet": "Delete ApplicationSet",
161192
"Actions": "Actions",
162-
"You don't have permission to perform this action": "You don't have permission to perform this action"
193+
"You don't have permission to perform this action": "You don't have permission to perform this action",
194+
"Edit": "Edit",
195+
"annotations": "annotations",
196+
"annotation": "annotation",
197+
"No owner": "No owner"
163198
}

locales/ko/plugin__gitops-plugin.json

Lines changed: 39 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,13 @@
8181
"There are no resources associated with the application.": "There are no resources associated with the application.",
8282
"Application resources": "Application resources",
8383
"Name": "Name",
84+
"Namespace": "Namespace",
85+
"Sync Wave": "Sync Wave",
86+
"Kind": "Kind",
87+
"Type": "Type",
88+
"Repository": "Repository",
89+
"Path / Chart": "Path / Chart",
90+
"Ref": "Ref",
8491
"No source": "No source",
8592
"Error. There must at least one source in the application.": "Error. There must at least one source in the application.",
8693
"Application sources": "Application sources",
@@ -101,8 +108,25 @@
101108
"Finished At": "Finished At",
102109
"When the operation was finished.": "When the operation was finished.",
103110
"Resources Last Synced": "Resources Last Synced",
111+
"Status": "Status",
112+
"Hook": "Hook",
104113
"There is no history associated with the application.": "There is no history associated with the application.",
114+
"ID": "ID",
115+
"Deploy Started At": "Deploy Started At",
116+
"Deployed At": "Deployed At",
117+
"Revision(s) and Source Repo URL(s)": "Revision(s) and Source Repo URL(s)",
118+
"Current health status of the ApplicationSet.": "Current health status of the ApplicationSet.",
119+
"Generated Apps": "Generated Apps",
120+
"Number of applications generated by this ApplicationSet.": "Number of applications generated by this ApplicationSet.",
121+
"applications": "applications",
122+
"application": "application",
105123
"Generators": "Generators",
124+
"Number of generators configured in this ApplicationSet.": "Number of generators configured in this ApplicationSet.",
125+
"generators": "generators",
126+
"generator": "generator",
127+
"App Project": "App Project",
128+
"Argo CD project that this ApplicationSet belongs to.": "Argo CD project that this ApplicationSet belongs to.",
129+
"Git repository URL where the ApplicationSet configuration is stored.": "Git repository URL where the ApplicationSet configuration is stored.",
106130
"Applications": "Applications",
107131
"Promote": "Promote",
108132
"Full Promote": "Full Promote",
@@ -118,6 +142,16 @@
118142
"There are no Argo Rollouts in all projects.": "There are no Argo Rollouts in all projects.",
119143
"Unable to load data": "Unable to load data",
120144
"There was an error retrieving applications. Check your connection and reload the page.": "There was an error retrieving applications. Check your connection and reload the page.",
145+
"Rollouts": "Rollouts",
146+
"Create Rollout": "Create Rollout",
147+
"Topology view": "Topology view",
148+
"Graph view": "Graph view",
149+
"Pods": "Pods",
150+
"Labels": "Labels",
151+
"Selector": "Selector",
152+
"Last Updated": "Last Updated",
153+
"No labels": "No labels",
154+
"Rollout Status": "Rollout Status",
121155
"No matching Argo CD Applications": "No matching Argo CD Applications",
122156
"No Argo CD Applications": "No Argo CD Applications",
123157
"No Argo CD Applications match the label filter": "No Argo CD Applications match the label filter",
@@ -134,13 +168,10 @@
134168
"There was an error retrieving applicationsets. Check your connection and reload the page.": "There was an error retrieving applicationsets. Check your connection and reload the page.",
135169
"ApplicationSets": "ApplicationSets",
136170
"Create ApplicationSet": "Create ApplicationSet",
137-
"Namespace": "Namespace",
138-
"Generated Apps": "Generated Apps",
139171
"Created At": "Created At",
140172
"View in Argo CD": "View in Argo CD",
141173
"Name must be unique within a namespace.": "Name must be unique within a namespace.",
142174
"Namespace defines the space within which each name must be unique.": "Namespace defines the space within which each name must be unique.",
143-
"Labels": "Labels",
144175
"Map of string keys and values that can be used to organize and categorize (scope and select) objects.": "Map of string keys and values that can be used to organize and categorize (scope and select) objects.",
145176
" Edit": " Edit",
146177
"Annotations": "Annotations",
@@ -159,5 +190,9 @@
159190
"Edit ApplicationSet": "Edit ApplicationSet",
160191
"Delete ApplicationSet": "Delete ApplicationSet",
161192
"Actions": "Actions",
162-
"You don't have permission to perform this action": "You don't have permission to perform this action"
193+
"You don't have permission to perform this action": "You don't have permission to perform this action",
194+
"Edit": "Edit",
195+
"annotations": "annotations",
196+
"annotation": "annotation",
197+
"No owner": "No owner"
163198
}

locales/zh/plugin__gitops-plugin.json

Lines changed: 39 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,13 @@
8181
"There are no resources associated with the application.": "There are no resources associated with the application.",
8282
"Application resources": "Application resources",
8383
"Name": "Name",
84+
"Namespace": "Namespace",
85+
"Sync Wave": "Sync Wave",
86+
"Kind": "Kind",
87+
"Type": "Type",
88+
"Repository": "Repository",
89+
"Path / Chart": "Path / Chart",
90+
"Ref": "Ref",
8491
"No source": "No source",
8592
"Error. There must at least one source in the application.": "Error. There must at least one source in the application.",
8693
"Application sources": "Application sources",
@@ -101,8 +108,25 @@
101108
"Finished At": "Finished At",
102109
"When the operation was finished.": "When the operation was finished.",
103110
"Resources Last Synced": "Resources Last Synced",
111+
"Status": "Status",
112+
"Hook": "Hook",
104113
"There is no history associated with the application.": "There is no history associated with the application.",
114+
"ID": "ID",
115+
"Deploy Started At": "Deploy Started At",
116+
"Deployed At": "Deployed At",
117+
"Revision(s) and Source Repo URL(s)": "Revision(s) and Source Repo URL(s)",
118+
"Current health status of the ApplicationSet.": "Current health status of the ApplicationSet.",
119+
"Generated Apps": "Generated Apps",
120+
"Number of applications generated by this ApplicationSet.": "Number of applications generated by this ApplicationSet.",
121+
"applications": "applications",
122+
"application": "application",
105123
"Generators": "Generators",
124+
"Number of generators configured in this ApplicationSet.": "Number of generators configured in this ApplicationSet.",
125+
"generators": "generators",
126+
"generator": "generator",
127+
"App Project": "App Project",
128+
"Argo CD project that this ApplicationSet belongs to.": "Argo CD project that this ApplicationSet belongs to.",
129+
"Git repository URL where the ApplicationSet configuration is stored.": "Git repository URL where the ApplicationSet configuration is stored.",
106130
"Applications": "Applications",
107131
"Promote": "Promote",
108132
"Full Promote": "Full Promote",
@@ -118,6 +142,16 @@
118142
"There are no Argo Rollouts in all projects.": "There are no Argo Rollouts in all projects.",
119143
"Unable to load data": "Unable to load data",
120144
"There was an error retrieving applications. Check your connection and reload the page.": "There was an error retrieving applications. Check your connection and reload the page.",
145+
"Rollouts": "Rollouts",
146+
"Create Rollout": "Create Rollout",
147+
"Topology view": "Topology view",
148+
"Graph view": "Graph view",
149+
"Pods": "Pods",
150+
"Labels": "Labels",
151+
"Selector": "Selector",
152+
"Last Updated": "Last Updated",
153+
"No labels": "No labels",
154+
"Rollout Status": "Rollout Status",
121155
"No matching Argo CD Applications": "No matching Argo CD Applications",
122156
"No Argo CD Applications": "No Argo CD Applications",
123157
"No Argo CD Applications match the label filter": "No Argo CD Applications match the label filter",
@@ -134,13 +168,10 @@
134168
"There was an error retrieving applicationsets. Check your connection and reload the page.": "There was an error retrieving applicationsets. Check your connection and reload the page.",
135169
"ApplicationSets": "ApplicationSets",
136170
"Create ApplicationSet": "Create ApplicationSet",
137-
"Namespace": "Namespace",
138-
"Generated Apps": "Generated Apps",
139171
"Created At": "Created At",
140172
"View in Argo CD": "View in Argo CD",
141173
"Name must be unique within a namespace.": "Name must be unique within a namespace.",
142174
"Namespace defines the space within which each name must be unique.": "Namespace defines the space within which each name must be unique.",
143-
"Labels": "Labels",
144175
"Map of string keys and values that can be used to organize and categorize (scope and select) objects.": "Map of string keys and values that can be used to organize and categorize (scope and select) objects.",
145176
" Edit": " Edit",
146177
"Annotations": "Annotations",
@@ -159,5 +190,9 @@
159190
"Edit ApplicationSet": "Edit ApplicationSet",
160191
"Delete ApplicationSet": "Delete ApplicationSet",
161192
"Actions": "Actions",
162-
"You don't have permission to perform this action": "You don't have permission to perform this action"
193+
"You don't have permission to perform this action": "You don't have permission to perform this action",
194+
"Edit": "Edit",
195+
"annotations": "annotations",
196+
"annotation": "annotation",
197+
"No owner": "No owner"
163198
}

src/gitops/components/application/ApplicationResourcesTab.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -214,39 +214,39 @@ const sortData = (
214214
export const useResourceColumnsDV = (getSortParams) => {
215215
const columns: DataViewTh[] = [
216216
{
217-
cell: t('plugin__gitops-plugin~Name'),
217+
cell: t('Name'),
218218
props: {
219219
'aria-label': 'name',
220220
className: 'pf-m-width-25',
221221
sort: getSortParams(0),
222222
},
223223
},
224224
{
225-
cell: 'Namespace',
225+
cell: t('Namespace'),
226226
props: {
227227
'aria-label': 'namespace',
228228
className: 'pf-m-width-20',
229229
sort: getSortParams(1),
230230
},
231231
},
232232
{
233-
cell: 'Sync Wave',
233+
cell: t('Sync Wave'),
234234
props: {
235235
'aria-label': 'sync wave',
236236
className: 'pf-m-width-15',
237237
sort: getSortParams(2),
238238
},
239239
},
240240
{
241-
cell: 'Sync Status',
241+
cell: t('Sync Status'),
242242
props: {
243243
'aria-label': 'sync status',
244244
className: 'pf-m-width-15',
245245
sort: getSortParams(3),
246246
},
247247
},
248248
{
249-
cell: 'Health Status',
249+
cell: t('Health Status'),
250250
props: {
251251
'aria-label': 'health status',
252252
className: 'pf-m-width-15',
@@ -345,7 +345,7 @@ const ResourceActionsCell: React.FC<{
345345
const filters = (resources: ApplicationResourceStatus[]): RowFilter[] => {
346346
return [
347347
{
348-
filterGroupName: 'Sync Status',
348+
filterGroupName: t('Sync Status'),
349349
type: 'resource-sync',
350350
reducer: (resource) => (resource.status ? resource.status : 'No Sync Status'),
351351
filter: (input, resource) => {
@@ -373,7 +373,7 @@ const filters = (resources: ApplicationResourceStatus[]): RowFilter[] => {
373373
}, []),
374374
},
375375
{
376-
filterGroupName: 'Health Status',
376+
filterGroupName: t('Health Status'),
377377
type: 'resource-health',
378378
reducer: (resource) => (resource.health ? resource.health.status : 'None'),
379379
filter: (input, resource) => {
@@ -402,7 +402,7 @@ const filters = (resources: ApplicationResourceStatus[]): RowFilter[] => {
402402
}, []),
403403
},
404404
{
405-
filterGroupName: 'Kind',
405+
filterGroupName: t('Kind'),
406406
type: 'resource-kind',
407407
reducer: (resource) => resource.kind,
408408
filter: (input, resource) => {

0 commit comments

Comments
 (0)