Remove duplicate and update isSHA, based on Atif's comments

Signed-off-by: Keith Chong <kykchong@redhat.com>

Author: keithchong

src/gitops/Revision/Revision.tsx

@@ -1,8 +1,8 @@
 import * as React from 'react';
-import gitUrlParse, { GitUrl } from 'git-url-parse';
 import { createRevisionURL } from 'src/gitops/utils/gitops';
 
 import ExternalLink from '../utils/components/ExternalLink/ExternalLink';
+import { isSHA, revisionUrl } from '@gitops/utils/urls';
 
 interface RevisionProps {
   repoURL: string;
@@ -42,53 +42,4 @@ const Revision: React.FC<RevisionProps> = ({ repoURL, revision, helm, revisionEx
   }
 };
 
-export const isSHA = (revision: string) => {
-  if (revision.startsWith('sha256:')) {
-    const hashOnly = revision.replace('sha256:', '');
-    return hashOnly.match(/^[a-f0-9]{8,69}$/) !== null;
-  }
-  // https://stackoverflow.com/questions/468370/a-regex-to-match-a-sha1
-  return revision.match(/^[a-f0-9]{5,40}$/) !== null;
-};
-
-function supportedSource(parsed: GitUrl): boolean {
-  return (
-    parsed.resource.startsWith('github') ||
-    ['gitlab.com', 'bitbucket.org'].indexOf(parsed.source) >= 0
-  );
-}
-
-function protocol(proto: string): string {
-  return proto === 'ssh' ? 'https' : proto;
-}
-
-function revisionUrl(url: string, revision: string, forPath: boolean): string {
-  let parsed;
-  try {
-    parsed = gitUrlParse(url);
-  } catch {
-    return null;
-  }
-  let urlSubPath = isSHA(revision) ? 'commit' : 'tree';
-
-  if (url.indexOf('bitbucket') >= 0) {
-    // The reason for the condition of 'forPath' is that when we build nested path, we need to use 'src'
-    urlSubPath = isSHA(revision) && !forPath ? 'commits' : 'src';
-  }
-
-  // Gitlab changed the way urls to commit look like
-  // Ref: https://docs.gitlab.com/ee/update/deprecations.html#legacy-urls-replaced-or-removed
-  if (parsed.source === 'gitlab.com') {
-    urlSubPath = '-/' + urlSubPath;
-  }
-
-  if (!supportedSource(parsed)) {
-    return null;
-  }
-
-  return `${protocol(parsed.protocol)}://${parsed.resource}/${parsed.owner}/${
-    parsed.name
-  }/${urlSubPath}/${revision || 'HEAD'}`;
-}
-
 export default Revision;

src/gitops/utils/urls.ts

@@ -7,6 +7,10 @@ import * as GitUrlParse from 'git-url-parse';
 import { GitUrl } from 'git-url-parse';
 
 export const isSHA = (revision: string) => {
+  if (revision.startsWith('sha256:')) {
+    const hashOnly = revision.replace('sha256:', '');
+    return hashOnly.match(/^[a-f0-9]{8,69}$/) !== null;
+  }
   // https://stackoverflow.com/questions/468370/a-regex-to-match-a-sha1
   return revision.match(/^[a-f0-9]{5,40}$/) !== null;
 };