Skip to content

Commit 55065e8

Browse files
authored
Merge pull request #94 from keithchong/7127-RolloutsImplementDeleteAction
feat: Rollouts: Implement Delete Action (#7127)
2 parents a5f99b1 + 452cc7c commit 55065e8

File tree

2 files changed

+9
-23
lines changed

2 files changed

+9
-23
lines changed

src/components/topology/actions/action-provider.tsx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
import * as React from 'react';
22

3-
import { Action } from '@openshift-console/dynamic-plugin-sdk';
3+
import { Action, useDeleteModal } from '@openshift-console/dynamic-plugin-sdk';
44
import { getResource } from '@openshift-console/dynamic-plugin-sdk-internal';
55
import { GraphElement, isGraph } from '@patternfly/react-topology';
66

7-
import { editRollout } from './creators';
7+
import { editRollout, getDeleteRolloutAction } from './creators';
88

99
export const useGitOpsActionProviderForTopology = (element: GraphElement) => {
10+
const resource = getResource(element);
11+
const deleteModal = useDeleteModal(resource);
12+
1013
const actions = React.useMemo(() => {
11-
const resource = getResource(element);
1214
if (!resource) {
1315
return [];
1416
}
@@ -17,10 +19,10 @@ export const useGitOpsActionProviderForTopology = (element: GraphElement) => {
1719
}
1820
const addActions: Action[] = [];
1921
addActions.push(editRollout(resource));
20-
// addActions.push(getDeleteRolloutAction(resource)) // Add Delete action later
22+
addActions.push(getDeleteRolloutAction(deleteModal));
2123
// Look at console/frontend/packages/dev-console/src/actions/add-resources.tsx : disabledActionsFilter
2224
return addActions;
23-
}, [element]);
25+
}, [element, resource, deleteModal]);
2426
return [actions, true, undefined];
2527
};
2628
const TYPE_APPLICATION_GROUP = 'part-of';

src/components/topology/actions/creators.ts

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,10 @@
11
import { Action, K8sResourceKind } from '@openshift-console/dynamic-plugin-sdk';
22

3-
export const getDeleteRolloutAction = (obj: K8sResourceKind): Action => ({
3+
export const getDeleteRolloutAction = (deleteModal: () => void): Action => ({
44
id: 'delete-rollout',
55
label: 'Delete Rollout',
66
cta: () => {
7-
console.log('GitOps: DeleteRolloutAction disabled for ' + obj?.metadata?.name);
8-
// Dependency on console. We need to implement later
9-
// deleteResourceModal({
10-
// blocking: true,
11-
// resourceName: rollout,
12-
// resourceType: 'Rollout',
13-
// actionLabel: t('Delete'),
14-
// redirect,
15-
// onSubmit: () => {
16-
// return coFetchJSON.delete(
17-
// `/api/helm/release/async?name=${releaseName}&ns=${namespace}&version=${releaseVersion}`,
18-
// null,
19-
// null,
20-
// -1,
21-
// );
22-
// },
23-
// });
7+
deleteModal();
248
},
259
});
2610

0 commit comments

Comments
 (0)