-
Notifications
You must be signed in to change notification settings - Fork 316
Add explicit default fields to all ExternalSecret definitions #9399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add conversionStrategy, decodingStrategy, and metadataPolicy fields explicitly to all ExternalSecret extract blocks to prevent ArgoCD OutOfSync status. The External Secrets Operator automatically adds these default values to resources even when not specified in Git manifests, causing ArgoCD to detect drift. By explicitly defining these fields with their default values (Default, None, None respectively), we ensure the Git manifest matches the live cluster state and eliminate false OutOfSync alerts. For now, and as an additional verification step, this change is only applied to staging. Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Gemini AI Assistant AvailableHi @oswcab! I'm here to help with your pull request. You can interact with me using the following commands: Available Commands
How to Use
PermissionsOnly OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage. This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance. |
|
🤖 Hi @oswcab, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
|
/retest |
|
@oswcab: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
hugares
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hugares, oswcab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add conversionStrategy, decodingStrategy, and metadataPolicy fields explicitly to all ExternalSecret extract blocks to prevent ArgoCD OutOfSync status.
The External Secrets Operator automatically adds these default values to resources even when not specified in Git manifests, causing ArgoCD to detect drift. By explicitly defining these fields with their default values (Default, None, None respectively), we ensure the Git manifest matches the live cluster state and eliminate false OutOfSync alerts.
For now, and as an additional verification step, this change is only applied to staging.