Skip to content

Conversation

@oswcab
Copy link
Contributor

@oswcab oswcab commented Dec 1, 2025

Add conversionStrategy, decodingStrategy, and metadataPolicy fields explicitly to all ExternalSecret extract blocks to prevent ArgoCD OutOfSync status.

The External Secrets Operator automatically adds these default values to resources even when not specified in Git manifests, causing ArgoCD to detect drift. By explicitly defining these fields with their default values (Default, None, None respectively), we ensure the Git manifest matches the live cluster state and eliminate false OutOfSync alerts.

For now, and as an additional verification step, this change is only applied to staging.

Add conversionStrategy, decodingStrategy, and metadataPolicy fields
explicitly to all ExternalSecret extract blocks to prevent ArgoCD
OutOfSync status.

The External Secrets Operator automatically adds these default values
to resources even when not specified in Git manifests, causing ArgoCD
to detect drift. By explicitly defining these fields with their default
values (Default, None, None respectively), we ensure the Git manifest
matches the live cluster state and eliminate false OutOfSync alerts.

For now, and as an additional verification step, this change is only
applied to staging.

Co-Authored-By: Claude <noreply@anthropic.com>
@openshift-ci openshift-ci bot requested review from arewm and ggallen December 1, 2025 22:01
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

🤖 Gemini AI Assistant Available

Hi @oswcab! I'm here to help with your pull request. You can interact with me using the following commands:

Available Commands

  • @gemini-cli /review - Request a comprehensive code review

    • Example: @gemini-cli /review Please focus on security and performance
  • @gemini-cli <your question> - Ask me anything about the codebase

    • Example: @gemini-cli How can I improve this function?
    • Example: @gemini-cli What are the best practices for error handling here?

How to Use

  1. Simply type one of the commands above in a comment on this PR
  2. I'll analyze your code and provide detailed feedback
  3. You can track my progress in the workflow logs

Permissions

Only OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage.


This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

🤖 Hi @oswcab, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@oswcab
Copy link
Contributor Author

oswcab commented Dec 1, 2025

/retest

@openshift-ci
Copy link

openshift-ci bot commented Dec 2, 2025

@oswcab: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-e2e-tests 966ff30 link true /test appstudio-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Dec 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hugares, oswcab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants