KFLUXBUGS-863: introduce results fixes with requisite performance related tuning (dev/stage) #3884
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| - op: replace | ||
| path: /spec/replicas | ||
| # default pipeline-service setting is 1 | ||
| value: 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| DB_USER= | ||
| DB_PASSWORD= | ||
| DB_HOST= | ||
| DB_PORT=5432 | ||
| DB_NAME= | ||
| DB_SSLMODE=disable | ||
| DB_SSLROOTCERT= | ||
| DB_ENABLE_AUTO_MIGRATION=true | ||
| SERVER_PORT=8080 | ||
| PROMETHEUS_PORT=9090 | ||
| PROMETHEUS_HISTOGRAM=true | ||
| TLS_PATH=/etc/tls | ||
| AUTH_DISABLE=false | ||
| AUTH_IMPERSONATE=true | ||
| LOG_LEVEL=info | ||
| LOGS_API=false | ||
| LOGS_TYPE=File | ||
| LOGS_BUFFER_SIZE=5242880 | ||
| LOGS_PATH=/logs | ||
| S3_BUCKET_NAME= | ||
| S3_ENDPOINT= | ||
| S3_HOSTNAME_IMMUTABLE=false | ||
| S3_REGION= | ||
| S3_ACCESS_KEY_ID= | ||
| S3_SECRET_ACCESS_KEY= | ||
| S3_MULTI_PART_SIZE=5242880 | ||
| GCS_BUCKET_NAME= | ||
| STORAGE_EMULATOR_HOST= | ||
| K8S_QPS=50 | ||
| K8S_BURST=100 | ||
| PROFILING=true | ||
| PROFILING_PORT=6060 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,15 +8,22 @@ commonAnnotations: | |
| argocd.argoproj.io/sync-options: SkipDryRunOnMissingResource=true | ||
|
|
||
| resources: | ||
| - https://github.com/openshift-pipelines/pipeline-service.git/developer/openshift/gitops/argocd/pipeline-service?ref=3ed2e97d4eacb0252b153edd2d6006637acb528e | ||
| - https://github.com/openshift-pipelines/pipeline-service.git/developer/openshift/gitops/argocd/pipeline-service-storage?ref=3ed2e97d4eacb0252b153edd2d6006637acb528e | ||
| - ../base/rbac | ||
|
|
||
| # generate a new configmap with updated values (logs api, db ssl mode) and replace the default one | ||
| configMapGenerator: | ||
| - behavior: replace | ||
| files: | ||
| - config.env | ||
| name: api-config | ||
| options: | ||
| disableNameSuffixHash: true | ||
| - behavior: merge | ||
| name: config-observability | ||
| literals: | ||
| - profiling.enable="true" | ||
|
Contributor
Author
There was a problem hiding this comment. so we can get thread dumps if need be .... safe to run in prod per https://go.dev/doc/diagnostics will not be turning on cpu profiling etc. I see us turning on profiling for as many tekton controllers as possible in konflux as part of app sre reqs wrt thread dumps |
||
|
|
||
| patches: | ||
| - path: chains-tekton-config-patches.yaml | ||
|
|
@@ -56,3 +63,8 @@ patches: | |
| target: | ||
| kind: TektonConfig | ||
| name: config | ||
| - path: update-results-watcher-performance.yaml | ||
| target: | ||
| kind: Deployment | ||
| namespace: tekton-results | ||
| name: tekton-results-watcher | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| --- | ||
| - op: add | ||
| path: /spec/template/spec/containers/0/args/- | ||
| value: -threadiness | ||
| - op: add | ||
| path: /spec/template/spec/containers/0/args/- | ||
| value: "50" | ||
| - op: add | ||
| path: /spec/template/spec/containers/0/args/- | ||
| value: -qps | ||
| - op: add | ||
| path: /spec/template/spec/containers/0/args/- | ||
| value: "50" | ||
| - op: add | ||
| path: /spec/template/spec/containers/0/args/- | ||
| value: -burst | ||
| - op: add | ||
| path: /spec/template/spec/containers/0/args/- | ||
| value: "100" | ||
| - op: add | ||
| path: /spec/template/spec/containers/0/args/- | ||
| value: -update_log_timeout | ||
| - op: add | ||
| path: /spec/template/spec/containers/0/args/- | ||
| value: "9m" | ||
|
Contributor
Author
There was a problem hiding this comment. based on performance testing with @pmacik |
||
| - op: add | ||
| path: /spec/template/spec/containers/0/args/- | ||
| value: -dynamic_reconcile_timeout | ||
| - op: add | ||
| path: /spec/template/spec/containers/0/args/- | ||
| value: "9m" | ||
|
Contributor
Author
There was a problem hiding this comment. based on performance testing with @pmacik |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| - op: replace | ||
| path: /spec/replicas | ||
| # default pipeline-service setting is 1 | ||
| value: 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| DB_USER= | ||
| DB_PASSWORD= | ||
| DB_HOST= | ||
| DB_PORT=5432 | ||
| DB_NAME= | ||
| DB_SSLMODE=disable | ||
| DB_SSLROOTCERT= | ||
| DB_ENABLE_AUTO_MIGRATION=true | ||
| SERVER_PORT=8080 | ||
| PROMETHEUS_PORT=9090 | ||
| PROMETHEUS_HISTOGRAM=true | ||
| TLS_PATH=/etc/tls | ||
| AUTH_DISABLE=false | ||
| AUTH_IMPERSONATE=true | ||
| LOG_LEVEL=info | ||
| LOGS_API=false | ||
| LOGS_TYPE=File | ||
| LOGS_BUFFER_SIZE=5242880 | ||
| LOGS_PATH=/logs | ||
| S3_BUCKET_NAME= | ||
| S3_ENDPOINT= | ||
| S3_HOSTNAME_IMMUTABLE=false | ||
| S3_REGION= | ||
| S3_ACCESS_KEY_ID= | ||
| S3_SECRET_ACCESS_KEY= | ||
| S3_MULTI_PART_SIZE=5242880 | ||
| GCS_BUCKET_NAME= | ||
| STORAGE_EMULATOR_HOST= | ||
| K8S_QPS=50 | ||
| K8S_BURST=100 | ||
| PROFILING=true | ||
| PROFILING_PORT=6060 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
been backing off of multiple replicas since some odd behavior I saw during the March outage.
production is already back to 1 replica