[config] Add RemoveConstructorAutowireServiceRector (#855)

* [config] Add RemoveConstructorAutowireServiceRector

* decouple class to strings

Author: TomasVotruba

composer.json

@@ -12,20 +12,21 @@
         "phpstan/extension-installer": "^1.4",
         "phpstan/phpstan": "^2.1.31",
         "phpstan/phpstan-webmozart-assert": "^2.0",
-        "phpunit/phpunit": "^11.4",
+        "phpunit/phpunit": "^11.5",
+        "rector/jack": "^0.2.9",
         "rector/rector-src": "dev-main",
-        "rector/type-perfect": "^2.0",
+        "rector/type-perfect": "^2.1",
         "symfony/config": "^6.4",
         "symfony/dependency-injection": "^6.4",
-        "symfony/http-kernel": "^6.4",
+        "symfony/http-kernel": "^7.0",
         "symfony/routing": "^6.4",
         "symfony/security-core": "^6.4",
         "symfony/security-http": "^6.4",
         "symfony/validator": "^6.4",
         "symfony/web-link": "^6.4",
         "symplify/phpstan-extensions": "^12.0",
-        "symplify/phpstan-rules": "^14.6",
-        "symplify/vendor-patches": "^11.3",
+        "symplify/phpstan-rules": "^14.8",
+        "symplify/vendor-patches": "^11.5",
         "tomasvotruba/class-leak": "^2.0",
         "tomasvotruba/type-coverage": "^2.0",
         "tomasvotruba/unused-public": "^2.0",

config/sets/symfony/configs.php

@@ -4,6 +4,7 @@
 
 use Rector\Config\RectorConfig;
 use Rector\Symfony\Configs\Rector\Closure\MergeServiceNameTypeRector;
+use Rector\Symfony\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector;
 use Rector\Symfony\Configs\Rector\Closure\ServiceArgsToServiceNamedArgRector;
 use Rector\Symfony\Configs\Rector\Closure\ServiceSetStringNameToClassNameRector;
 use Rector\Symfony\Configs\Rector\Closure\ServiceSettersToSettersAutodiscoveryRector;
@@ -16,5 +17,6 @@
         ServiceSetStringNameToClassNameRector::class,
         ServiceSettersToSettersAutodiscoveryRector::class,
         ServiceTagsToDefaultsAutoconfigureRector::class,
+        RemoveConstructorAutowireServiceRector::class,
     ]);
 };

phpstan.neon

@@ -39,16 +39,10 @@ parameters:
         # pointless check
         - '#expects class-string, string given#'
 
-        - '#Calling PHPStan\\Reflection\\Php\\PhpParameterReflection\:\:getName\(\) is not covered by backward compatibility promise\. The method might change in a minor PHPStan version#'
-
         # false positive
         - '#but class PhpParser\\Node\\Stmt\\Expression is not generic#'
         - '#Access to an undefined property Rector\\Contract\\PhpParser\\Node\\StmtsAwareInterface\:\:\$stmts#'
 
-        # false positive
-        - '#Parameters should have "PhpParser\\Node\\Expr\\Closure" types as the only types passed to this method#'
-        - '#Parameter 1 should use "PHPStan\\BetterReflection\\Reflection\\Adapter\\ReflectionMethod" type as the only type passed to this method#'
-
         # more advanced usage, but not always working
         # see https://github.com/rectorphp/rector-src/actions/runs/11798721617/job/32865546672?pr=6422#step:5:110
         - '#Doing instanceof PHPStan\\Type\\.+ is error\-prone and deprecated#'
@@ -59,3 +53,9 @@ parameters:
 
         # avoid notice on run on php 8.3
         - identifier: typeCoverage.constantTypeCoverage
+
+        # false postitive
+        -
+            identifier: typePerfect.narrowPublicClassMethodParamType
+            path: src/NodeAnalyzer/SymfonyPhpClosureDetector.php
+        - '#Parameter 1 should use "PHPStan\\BetterReflection\\Reflection\\Adapter\\ReflectionMethod" type as the only type passed to this method#'

rules-tests/Configs/Rector/Closure/RemoveConstructorAutowireServiceRector/Fixture/avoid_different_type.php.inc

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Fixture;
+
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\AnotherClassWithoutConstructor;
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\DifferentType;
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\PassedAsDependency;
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+use function Symfony\Component\DependencyInjection\Loader\Configurator\service;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+
+    $services->defaults()->autowire();
+
+    $services->set(AnotherClassWithoutConstructor::class)
+        ->arg('$passedAsDependency', service(DifferentType::class));
+};

rules-tests/Configs/Rector/Closure/RemoveConstructorAutowireServiceRector/Fixture/skip_no_defaults_autowire.php.inc

@@ -0,0 +1,17 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Fixture;
+
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\AnotherClassWithoutConstructor;
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\PassedAsDependency;
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+use function Symfony\Component\DependencyInjection\Loader\Configurator\service;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+
+    $services->set(AnotherClassWithoutConstructor::class)
+        ->arg('$passedAsDependency', service(PassedAsDependency::class));
+};

rules-tests/Configs/Rector/Closure/RemoveConstructorAutowireServiceRector/Fixture/skip_no_service_type.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Fixture;
+
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\AnotherClassWithoutConstructor;
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\PassedAsDependency;
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+use function Symfony\Component\DependencyInjection\Loader\Configurator\service;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+
+    $services->defaults()->autowire();
+
+    $services->set(AnotherClassWithoutConstructor::class)
+        ->arg('$passedAsDependency', 123);
+};

rules-tests/Configs/Rector/Closure/RemoveConstructorAutowireServiceRector/Fixture/some_class.php.inc

@@ -0,0 +1,42 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Fixture;
+
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\AnotherClassWithoutConstructor;
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\PassedAsDependency;
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+use function Symfony\Component\DependencyInjection\Loader\Configurator\service;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+
+    $services->defaults()->autowire();
+
+    $services->set(AnotherClassWithoutConstructor::class)
+        ->arg('$passedAsDependency', service(PassedAsDependency::class));
+};
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Fixture;
+
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\AnotherClassWithoutConstructor;
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\PassedAsDependency;
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+use function Symfony\Component\DependencyInjection\Loader\Configurator\service;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+
+    $services->defaults()->autowire();
+
+    $services->set(AnotherClassWithoutConstructor::class);
+};
+
+?>

rules-tests/Configs/Rector/Closure/RemoveConstructorAutowireServiceRector/RemoveConstructorAutowireServiceRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class RemoveConstructorAutowireServiceRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/Configs/Rector/Closure/RemoveConstructorAutowireServiceRector/Source/AnotherClassWithoutConstructor.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source;
+
+final class AnotherClassWithoutConstructor
+{
+    public function __construct(
+        PassedAsDependency $passedAsDependency
+    ) {
+    }
+}

rules-tests/Configs/Rector/Closure/RemoveConstructorAutowireServiceRector/Source/DifferentType.php

@@ -0,0 +1,7 @@
+<?php
+
+namespace Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source;
+
+final class DifferentType
+{
+}