Skip to content

Commit 8e4d32a

Browse files
authored
Clean up PHPStan ignore errors (#847)
1 parent 5880ed9 commit 8e4d32a

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

phpstan.neon

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,12 @@ parameters:
4242
- '#Calling PHPStan\\Reflection\\Php\\PhpParameterReflection\:\:getName\(\) is not covered by backward compatibility promise\. The method might change in a minor PHPStan version#'
4343

4444
# false positive
45-
- '#Access to an undefined property Rector\\Core\\Contract\\PhpParser\\Node\\StmtsAwareInterface\:\:\$stmts#'
4645
- '#but class PhpParser\\Node\\Stmt\\Expression is not generic#'
4746
- '#Access to an undefined property Rector\\Contract\\PhpParser\\Node\\StmtsAwareInterface\:\:\$stmts#'
4847

4948
# false positive
5049
- '#Parameters should have "PhpParser\\Node\\Expr\\Closure" types as the only types passed to this method#'
5150
- '#Parameter 1 should use "PHPStan\\BetterReflection\\Reflection\\Adapter\\ReflectionMethod" type as the only type passed to this method#'
52-
- '#Parameter \#1 \$stmtsAware of method Rector\\NodeAnalyzer\\TerminatedNodeAnalyzer\:\:isAlwaysTerminated\(\) expects Rector\\Contract\\PhpParser\\Node\\StmtsAwareInterface, PhpParser\\Node\\Stmt\\ClassMethod given#'
5351

5452
# more advanced usage, but not always working
5553
# see https://github.com/rectorphp/rector-src/actions/runs/11798721617/job/32865546672?pr=6422#step:5:110
@@ -59,9 +57,5 @@ parameters:
5957
- identifier: argument.type
6058
- identifier: assign.propertyType
6159

62-
- '#::provideMinPhpVersion\(\) never returns \d+ so it can be removed from the return type#'
63-
64-
# node finder
65-
-
66-
identifier: return.type
67-
path: rules/Symfony73/NodeAnalyzer/CommandArgumentsAndOptionsResolver.php
60+
# avoid notice on run on php 8.3
61+
- identifier: typeCoverage.constantTypeCoverage

0 commit comments

Comments
 (0)