[Configs] Skip first class callable on RemoveConstructorAutowireServiceRector (#858)

* [Configs] Skip first class callable on RemoveConstructorAutowireServiceRector

* [Configs] Skip first class callable on RemoveConstructorAutowireServiceRector

* [Configs] Skip first class callable on RemoveConstructorAutowireServiceRector

Author: samsonasik

rules-tests/Configs/Rector/Closure/RemoveConstructorAutowireServiceRector/Fixture/skip_first_class_callable.php.inc

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Fixture;
+
+use Rector\Symfony\Tests\Configs\Rector\Closure\RemoveConstructorAutowireServiceRector\Source\AnotherClassWithoutConstructor;
+use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
+use function Symfony\Component\DependencyInjection\Loader\Configurator\service;
+
+return static function (ContainerConfigurator $containerConfigurator): void {
+    $services = $containerConfigurator->services();
+
+    $services->defaults()->autowire();
+
+    $services->set('named-class', AnotherClassWithoutConstructor::class)
+        ->arg('$passedAsDependency', service(...));
+};
+
+?>

rules/Configs/Rector/Closure/RemoveConstructorAutowireServiceRector.php

@@ -129,6 +129,10 @@ public function refactor(Node $node): ?Node
                 return null;
             }
 
+            if ($node->isFirstClassCallable()) {
+                return null;
+            }
+
             $argName = $node->getArgs()[0]
                 ->value;
             $serviceArgExpr = $node->getArgs()[1]
@@ -186,6 +190,10 @@ private function matchSetServicesClass(MethodCall $methodCall): ?string
             return null;
         }
 
+        if ($methodCall->isFirstClassCallable()) {
+            return null;
+        }
+
         foreach ($methodCall->getArgs() as $arg) {
             if (! $arg->value instanceof ClassConstFetch) {
                 continue;
@@ -209,6 +217,10 @@ private function isParameterTypeMatchingPassedArgExprClass(
             return false;
         }
 
+        if ($serviceArgExpr->isFirstClassCallable()) {
+            return false;
+        }
+
         $dependencyServiceExpr = $serviceArgExpr->getArgs()[0]
             ->value;
         $dependencyService = $this->valueResolver->getValue($dependencyServiceExpr);