ensure reset args after loop (#864)

samsonasik · web-flow · commit 290b5c724d9c · 2025-11-12T17:58:35.000Z
diff --git a/rules/CodeQuality/Rector/Class_/InlineClassRoutePrefixRector.php b/rules/CodeQuality/Rector/Class_/InlineClassRoutePrefixRector.php
@@ -234,10 +234,11 @@ public function refactor(Node $node): ?Class_
                             // silent or "path"
                             if ($attributeArg->name === null || $attributeArg->name->toString() === self::PATH) {
                                 unset($attribute->args[$attributeArgKey]);
-                                $attribute->args = array_values($attribute->args);
                             }
                         }
 
+                        $attribute->args = array_values($attribute->args);
+
                         // nothing to keep, remove whole attribute
                         if ($attribute->args === []) {
                             unset($attrGroup->attrs[$attributeKey]);

Original file line number	Diff line number	Diff line change
`@@ -234,10 +234,11 @@ public function refactor(Node $node): ?Class_`
`234`	`234`	`// silent or "path"`
`235`	`235`	`if ($attributeArg->name === null \|\| $attributeArg->name->toString() === self::PATH) {`
`236`	`236`	`unset($attribute->args[$attributeArgKey]);`
`237`		`- $attribute->args = array_values($attribute->args);`
`238`	`237`	`}`
`239`	`238`	`}`
`240`	`239`
	`240`	`+ $attribute->args = array_values($attribute->args);`
	`241`	`+`
`241`	`242`	`// nothing to keep, remove whole attribute`
`242`	`243`	`if ($attribute->args === []) {`
`243`	`244`	`unset($attrGroup->attrs[$attributeKey]);`