misc static

Author: TomasVotruba

.github/workflows/code_analysis.yaml

@@ -17,6 +17,14 @@ jobs:
                         name: 'Bare Run'
                         run: bin/console
 
+                    -
+                        name: 'ECS'
+                        run: composer check-cs
+
+                    -
+                        name: 'PHPStan'
+                        run: composer phpstan
+
         name: ${{ matrix.actions.name }}
         runs-on: ubuntu-latest
 

composer.json

@@ -10,7 +10,13 @@
         "symplify/smart-file-system": "^9.1",
         "symplify/package-builder": "^9.1",
         "symplify/console-package-builder": "^9.1",
-        "nikic/php-parser": "^4.10"
+        "nikic/php-parser": "^4.10.4"
+    },
+    "require-dev": {
+        "symplify/easy-coding-standard": "^9.1",
+        "phpstan/phpstan": "^0.12.73",
+        "phpunit/phpunit": "^9.5",
+        "symplify/phpstan-extensions": "^9.1"
     },
     "autoload": {
         "psr-4": {
@@ -22,13 +28,9 @@
             "Rector\\PhpParserNodesDocs\\Tests\\": "tests"
         }
     },
-    "require-dev": {
-        "symplify/easy-coding-standard": "^9.1",
-        "phpstan/phpstan": "^0.12.73"
-    },
     "scripts": {
         "check-cs": "vendor/bin/ecs check --ansi",
         "fix-cs": "vendor/bin/ecs check --fix --ansi",
-        "phpstan": "vendor/bin/phpstan analyse --ansi"
+        "phpstan": "vendor/bin/phpstan analyse --ansi --error-format symplify"
     }
 }

phpstan.neon

@@ -0,0 +1,17 @@
+includes:
+    # allows symplify error formatter
+    - vendor/symplify/phpstan-extensions/config/config.neon
+
+parameters:
+    level: max
+
+    paths:
+        - src
+        - tests
+
+    ignoreErrors:
+        -
+            message: '#Cannot cast array<string\>\|bool\|string\|null to string#'
+            path: src/Command/DumpNodesCommand.php
+
+        - '#Method Rector\\PhpParserNodesDocs\\NodeCodeSampleProvider\:\:provide\(\) should return array<class\-string<PhpParser\\Node\>, array<int, Rector\\PhpParserNodesDocs\\ValueObject\\NodeCodeSample\>\> but returns array<class\-string, array<int, Rector\\PhpParserNodesDocs\\ValueObject\\NodeCodeSample\>\>#'

src/NodeCodeSampleProvider.php

@@ -6,6 +6,7 @@
 
 use PhpParser\Node;
 use PhpParser\PrettyPrinter\Standard;
+use Rector\PhpParserNodesDocs\Exception\ShouldNotHappenException;
 use Rector\PhpParserNodesDocs\ValueObject\NodeCodeSample;
 use Symplify\SmartFileSystem\Finder\SmartFinder;
 use Symplify\SmartFileSystem\SmartFileInfo;
@@ -29,7 +30,7 @@ public function __construct(SmartFinder $smartFinder, Standard $standard)
     }
 
     /**
-     * @return array<string, NodeCodeSample[]>
+     * @return array<class-string<Node>, array<int, NodeCodeSample>>
      */
     public function provide(): array
     {
@@ -43,7 +44,7 @@ public function provide(): array
 
             $nodeClass = get_class($node);
 
-            $printedContent = $this->standard->prettyPrint($node);
+            $printedContent = $this->standard->prettyPrint([$node]);
             $nodeCodeSamplesByNodeClass[$nodeClass][] = new NodeCodeSample(
                 $fileInfo->getContents(),
                 $printedContent

src/ValueObject/NodeInfo.php

@@ -24,6 +24,7 @@ final class NodeInfo
     private $nodeCodeSamples = [];
 
     /**
+     * @param class-string<\PhpParser\Node> $class
      * @param NodeCodeSample[] $nodeCodeSamples
      */
     public function __construct(string $class, array $nodeCodeSamples = [])

tests/NodeInfosFactoryTest.php

@@ -4,7 +4,7 @@
 
 namespace Rector\PhpParserNodesDocs\Tests;
 
-use Rector\Core\HttpKernel\RectorKernel;
+use Rector\PhpParserNodesDocs\HttpKernel\PhpParserNodesDocsKernel;
 use Rector\PhpParserNodesDocs\NodeInfosFactory;
 use Symplify\PackageBuilder\Testing\AbstractKernelTestCase;
 
@@ -17,7 +17,7 @@ final class NodeInfosFactoryTest extends AbstractKernelTestCase
 
     protected function setUp(): void
     {
-        $this->bootKernel(RectorKernel::class);
+        $this->bootKernel(PhpParserNodesDocsKernel::class);
 
         $this->nodeInfosFactory = $this->getService(NodeInfosFactory::class);
     }