Fix duplicates or error when __init__ assigns to a property

Fixes #466

Author: AWhetter

autoapi/_parser.py

@@ -131,8 +131,10 @@ def parse_classdef(self, node, data=None):
         self._full_name_stack.append(node.name)
         overridden = set()
         overloads = {}
+        children = {}
         for base in itertools.chain(iter((node,)), node.ancestors()):
             seen = set()
+            base_children = []
             if base.qname() in (
                 "__builtins__.object",
                 "builtins.object",
@@ -151,12 +153,29 @@ def parse_classdef(self, node, data=None):
                     continue
                 seen.add(name)
                 child_data = self.parse(child)
-                data["children"].extend(
+                base_children.extend(
                     _parse_child(node, child_data, overloads, base, name)
                 )
 
             overridden.update(seen)
 
+            for base_child in base_children:
+                existing_child = children.get(base_child["name"])
+                if (
+                    existing_child
+                    # If an attribute was assigned to but this class has a property
+                    # with the same name, then the property was assigned to,
+                    # and not an attribute.
+                    and not (
+                        base_child["type"] == "property"
+                        and existing_child["type"] == "attribute"
+                    )
+                ):
+                    continue
+
+                children[base_child["name"]] = base_child
+
+        data["children"].extend(children.values())
         self._qual_name_stack.pop()
         self._full_name_stack.pop()
 

docs/changes/466.bugfix

@@ -0,0 +1 @@
+Fix error or duplicates when __init__ assigns to a property

tests/python/pyexample/example/example.py

@@ -40,6 +40,14 @@ def __init__(self, attr):
         :type: str
         """
 
+    @property
+    def attr(self):
+        return 5
+
+    @attr.setter
+    def attr(self, value):
+        pass
+
     @property
     def property_simple(self) -> int:
         """This property should parse okay."""

tests/python/test_pyintegration.py

@@ -51,7 +51,10 @@ def check_integration(self, parse, example_path):
         assert foo.find(id="example.Foo.Meta")
 
         # Check that class attributes are documented
-        assert foo.find(id="example.Foo.attr")
+        attr = foo.find(id="example.Foo.attr")
+        assert attr
+        assert attr.find(class_="pre").text.strip() == "property"
+
         attr2 = foo.find(id="example.Foo.attr2")
         assert "attr2" in attr2.text
         # Check that attribute docstrings are used