Add GITHUB_APP_NAME to context processor (#12511)

Needed for readthedocs/ext-theme#655,
which otherwise I need to override the Allauth views for,
and this seems useful in other places if we want to keep linking it.

Author: ericholscher

readthedocs/core/context_processors.py

@@ -27,6 +27,7 @@ def readthedocs_processor(request):
         "SUPPORT_EMAIL": settings.SUPPORT_EMAIL,
         "PUBLIC_API_URL": settings.PUBLIC_API_URL,
         "ADMIN_URL": settings.ADMIN_URL,
+        "GITHUB_APP_NAME": settings.GITHUB_APP_NAME,
     }
     return exports
 

readthedocs/profiles/tests/test_views.py

@@ -256,7 +256,6 @@ def test_migration_page_initial_state(self, request):
 
         assert context["step"] == "overview"
         assert context["step_connect_completed"] is False
-        assert context["github_app_name"] == "readthedocs"
         assert list(context["migrated_projects"]) == []
         assert (
             context["old_application_link"]
@@ -344,7 +343,6 @@ def test_migration_page_step_connect_done(self, request):
 
         assert context["step"] == "overview"
         assert context["step_connect_completed"] is True
-        assert context["github_app_name"] == "readthedocs"
         assert list(context["migrated_projects"]) == []
         assert (
             context["old_application_link"]
@@ -437,7 +435,6 @@ def test_migration_page_step_install_done(self, request):
 
         assert context["step"] == "overview"
         assert context["step_connect_completed"] is True
-        assert context["github_app_name"] == "readthedocs"
         assert list(context["migrated_projects"]) == []
         assert (
             context["old_application_link"]
@@ -541,7 +538,6 @@ def test_migration_page_step_migrate_one_project(
 
         assert context["step"] == "overview"
         assert context["step_connect_completed"] is True
-        assert context["github_app_name"] == "readthedocs"
         assert list(context["migrated_projects"]) == [
             self.project_with_remote_repository,
         ]
@@ -638,7 +634,6 @@ def test_migration_page_step_migrate_all_projects(
 
         assert context["step"] == "overview"
         assert context["step_connect_completed"] is True
-        assert context["github_app_name"] == "readthedocs"
         assert list(context["migrated_projects"]) == [
             self.project_with_remote_repository,
             self.project_with_remote_organization,
@@ -731,7 +726,6 @@ def test_migration_page_step_migrate_one_project_with_errors(
 
         assert context["step"] == "overview"
         assert context["step_connect_completed"] is True
-        assert context["github_app_name"] == "readthedocs"
         assert list(context["migrated_projects"]) == [
             self.project_with_remote_repository,
         ]
@@ -824,7 +818,6 @@ def test_migration_page_step_revoke_done(self, request):
 
         assert context["step"] == "overview"
         assert context["step_connect_completed"] is True
-        assert context["github_app_name"] == "readthedocs"
         assert list(context["migrated_projects"]) == []
         assert (
             context["old_application_link"]

readthedocs/profiles/views.py

@@ -348,7 +348,6 @@ def get_context_data(self, **kwargs):
         user = self.request.user
 
         context["step_connect_completed"] = self._has_new_accounts_for_old_accounts()
-        context["github_app_name"] = settings.GITHUB_APP_NAME
         context["migrated_projects"] = get_migrated_projects(user)
         context["old_application_link"] = get_old_app_link()
         context["step_revoke_completed"] = self._is_access_to_old_github_accounts_revoked()

readthedocs/projects/views/private.py

@@ -459,7 +459,6 @@ def get_context_data(self, **kwargs):
         context["allow_private_repos"] = settings.ALLOW_PRIVATE_REPOS
         context["form_automatic"] = ProjectAutomaticForm(user=self.request.user)
         context["form_manual"] = ProjectManualForm(user=self.request.user)
-        context["GITHUB_APP_NAME"] = settings.GITHUB_APP_NAME
 
         # Provider list for simple lookup of connected services, used for
         # conditional content

readthedocs/rtd_tests/tests/test_notifications.py

@@ -62,6 +62,7 @@ class TestNotification(EmailNotification):
                 "TEMPLATE_ROOT": mock.ANY,
                 "USE_PROMOS": mock.ANY,
                 "USE_ORGANIZATIONS": mock.ANY,
+                "GITHUB_APP_NAME": mock.ANY,
             },
         )