Fix JavaScript interface injection when rotating the screen (#361)

Author: mickael-menu

.idea/compiler.xml

@@ -30,6 +30,10 @@ All notable changes to this project will be documented in this file. Take a look
 
 ### Fixed
 
+#### Navigator
+
+* [#360](https://github.com/readium/kotlin-toolkit/issues/360) Fix EPUB JavaScript interface injection when rotating the screen on some devices.
+
 #### Streamer
 
 * Fix issue with the TTS starting from the beginning of the chapter instead of the current position.

.idea/kotlinc.xml

@@ -173,16 +173,12 @@ open class R2BasicWebView(context: Context, attrs: AttributeSet) : WebView(conte
         listener?.onProgressionChanged()
     }
 
-    override fun onAttachedToWindow() {
-        super.onAttachedToWindow()
-        addJavascriptInterface(this, "Android")
-    }
-
-    override fun onDetachedFromWindow() {
-        super.onDetachedFromWindow()
+    override fun destroy() {
         // Prevent the web view from leaking when detached
         // See https://github.com/readium/r2-navigator-kotlin/issues/52
         removeJavascriptInterface("Android")
+
+        super.destroy()
     }
 
     @android.webkit.JavascriptInterface

CHANGELOG.md

@@ -165,6 +165,7 @@ class R2EpubPageFragment : Fragment() {
         webView.settings.textZoom = textZoom
         webView.resourceUrl = resourceUrl
         webView.setPadding(0, 0, 0, 0)
+        webView.addJavascriptInterface(webView, "Android")
 
         var endReached = false
         webView.setOnOverScrolledCallback(object : R2BasicWebView.OnOverScrolledCallback {