Fix the rendering of PDF covers in some edge cases (#64)

Author: mickael-menu

CHANGELOG.md

@@ -44,6 +44,10 @@ All notable changes to this project will be documented in this file. Take a look
 
 * Fix building with Kotlin 1.6.
 
+#### Streamer
+
+* Fixed the rendering of PDF covers in some edge cases.
+
 #### Navigator
 
 * Fixed turning pages of an EPUB reflowable resource with an odd number of columns. A virtual blank trailing column is appended to the resource when displayed as two columns.

readium/streamer/src/main/java/org/readium/r2/streamer/parser/pdf/PdfiumDocument.kt

@@ -54,22 +54,20 @@ internal class PdfiumDocument(
 }
 
 private fun PdfiumCore.renderCover(document: _PdfiumDocument): Bitmap? {
-    try {
-        val pointer = openPage(document, 0)
-        if (pointer <= 0) return null
-
+    return try {
+        openPage(document, 0)
         val width = getPageWidth(document, 0)
         val height = getPageHeight(document, 0)
         val bitmap = Bitmap.createBitmap(width, height, Bitmap.Config.ARGB_8888)
         renderPageBitmap(document, bitmap, 0, 0, 0, width, height, false)
-        return bitmap
+        bitmap
 
     } catch (e: Exception) {
         Timber.e(e)
-        return null
+        null
     } catch (e: OutOfMemoryError) { // We don't want to catch any Error, only OOM.
         Timber.e(e)
-        return null
+        null
     }
 }