[0.83.0-RC.0] Test Report: 2

[cipolleschi]

Target Minor

0.83.0

Under what system configuration was the test run?

No response

Tested configurations

Refer to this spreadsheet for test cases.

• RNTester + iOS + Hermes V1
• RNTester + Android + Hermes V1
• RNTestProject + iOS + Hermes V1
• RNTestProject + Android + Hermes V1

Close this issue if there are no blocking issues.

Blocking Issues?

[j-piasecki]

All good here.

[mikehardy]

I get an iOS compile error in my fuzz-busting react-native-firebase system integration compiler project:

[React-jsiexecutor] Compiling JSINativeModules.cpp
❌ /Users/mike/Library/Developer/Xcode/DerivedData/rnfbdemo-gsuyjvwnbefbzvbfqtovnhthepew/Build/Products/Debug-iphonesimulator/React-jsinspector/jsinspector_modern.framework/Headers/jsinspector-modern/ScopedExecutor.h:10:10: 'react/utils/OnScopeExit.h' file not found
   10 | #include <react/utils/OnScopeExit.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
[React-jsiexecutor] Compiling JSIExecutor.cpp
❌ /Users/mike/Library/Developer/Xcode/DerivedData/rnfbdemo-gsuyjvwnbefbzvbfqtovnhthepew/Build/Products/Debug-iphonesimulator/React-jsinspector/jsinspector_modern.framework/Headers/jsinspector-modern/ScopedExecutor.h:10:10: 'react/utils/OnScopeExit.h' file not found
   10 | #include <react/utils/OnScopeExit.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~

This script from the rn83 branch: https://github.com/mikehardy/rnfbdemo/blob/rn83/make-demo.sh

File exists on disk, perhaps it is a header inclusion thing based on use_frameworks! (required for react-native-firebase)?

mike@isabela:~/work/invertase/rnfbdemo/rnfbdemo (rn83) % find . |grep OnScopeExit
./node_modules/react-native/ReactCommon/react/utils/OnScopeExit.h

[cipolleschi]

Thanks for flagging! I think i fixed that on main already. Let me add the pick request for RC.1