Skip to content

Commit 212e923

Browse files
authored
Merge pull request #177 from clue-labs/nullable-v3
Improve PHP 8.4+ support by avoiding implicitly nullable types
2 parents 398b6ac + 74d748d commit 212e923

File tree

3 files changed

+20
-3
lines changed

3 files changed

+20
-3
lines changed

src/DuplexResourceStream.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,13 @@ final class DuplexResourceStream extends EventEmitter implements DuplexStreamInt
3838
private $closing = false;
3939
private $listening = false;
4040

41-
public function __construct($stream, LoopInterface $loop = null, $readChunkSize = null, WritableStreamInterface $buffer = null)
41+
/**
42+
* @param resource $stream
43+
* @param ?LoopInterface $loop
44+
* @param ?int $readChunkSize
45+
* @param ?WritableStreamInterface $buffer
46+
*/
47+
public function __construct($stream, ?LoopInterface $loop = null, $readChunkSize = null, ?WritableStreamInterface $buffer = null)
4248
{
4349
if (!\is_resource($stream) || \get_resource_type($stream) !== "stream") {
4450
throw new InvalidArgumentException('First parameter must be a valid stream resource');

src/ReadableResourceStream.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,12 @@ final class ReadableResourceStream extends EventEmitter implements ReadableStrea
4040
private $closed = false;
4141
private $listening = false;
4242

43-
public function __construct($stream, LoopInterface $loop = null, $readChunkSize = null)
43+
/**
44+
* @param resource $stream
45+
* @param ?LoopInterface $loop
46+
* @param ?int $readChunkSize
47+
*/
48+
public function __construct($stream, ?LoopInterface $loop = null, $readChunkSize = null)
4449
{
4550
if (!\is_resource($stream) || \get_resource_type($stream) !== "stream") {
4651
throw new InvalidArgumentException('First parameter must be a valid stream resource');

src/WritableResourceStream.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,13 @@ final class WritableResourceStream extends EventEmitter implements WritableStrea
2828
private $closed = false;
2929
private $data = '';
3030

31-
public function __construct($stream, LoopInterface $loop = null, $writeBufferSoftLimit = null, $writeChunkSize = null)
31+
/**
32+
* @param resource $stream
33+
* @param ?LoopInterface $loop
34+
* @param ?int $writeBufferSoftLimit
35+
* @param ?int $writeChunkSize
36+
*/
37+
public function __construct($stream, ?LoopInterface $loop = null, $writeBufferSoftLimit = null, $writeChunkSize = null)
3238
{
3339
if (!\is_resource($stream) || \get_resource_type($stream) !== "stream") {
3440
throw new \InvalidArgumentException('First parameter must be a valid stream resource');

0 commit comments

Comments
 (0)