Improve TLS server error messages when incoming connection fails

Author: clue

src/SecureServer.php

@@ -184,6 +184,12 @@ function ($conn) use ($that) {
                 $that->emit('connection', array($conn));
             },
             function ($error) use ($that, $connection) {
+                $error = new \RuntimeException(
+                    'Connection from ' . $connection->getRemoteAddress() . ' failed during TLS handshake: ' . $error->getMessage(),
+                    $error->getCode(),
+                    $error
+                );
+
                 $that->emit('error', array($error));
                 $connection->end();
             }

tests/FunctionalSecureServerTest.php

@@ -420,8 +420,10 @@ public function testEmitsErrorIfConnectionIsClosedBeforeHandshake()
 
         $error = Block\await($errorEvent, $loop, self::TIMEOUT);
 
+        // Connection from tcp://127.0.0.1:39528 failed during TLS handshake: Connection lost during TLS handshak
         $this->assertTrue($error instanceof \RuntimeException);
-        $this->assertEquals('Connection lost during TLS handshake', $error->getMessage());
+        $this->assertStringStartsWith('Connection from tcp://', $error->getMessage());
+        $this->assertStringEndsWith('failed during TLS handshake: Connection lost during TLS handshake', $error->getMessage());
         $this->assertEquals(defined('SOCKET_ECONNRESET') ? SOCKET_ECONNRESET : 0, $error->getCode());
     }
 
@@ -445,8 +447,10 @@ public function testEmitsErrorIfConnectionIsClosedWithIncompleteHandshake()
 
         $error = Block\await($errorEvent, $loop, self::TIMEOUT);
 
+        // Connection from tcp://127.0.0.1:39528 failed during TLS handshake: Connection lost during TLS handshak
         $this->assertTrue($error instanceof \RuntimeException);
-        $this->assertEquals('Connection lost during TLS handshake', $error->getMessage());
+        $this->assertStringStartsWith('Connection from tcp://', $error->getMessage());
+        $this->assertStringEndsWith('failed during TLS handshake: Connection lost during TLS handshake', $error->getMessage());
         $this->assertEquals(defined('SOCKET_ECONNRESET') ? SOCKET_ECONNRESET : 0, $error->getCode());
     }