Merge pull request #173 from SimonFrings/tests

Run tests on PHPUnit 9 and clean up test suite

Author: jsor

.travis.yml

@@ -1,18 +1,14 @@
 language: php
 
-php:
-  - 7.1
-  - 7.2
-  - 7.3
-  - 7.4
-  - nightly # ignore errors, see below
-
 # lock distro so new future defaults will not break the build
 dist: trusty
 
-matrix:
-  allow_failures:
-    - php: nightly
+jobs:
+  include:
+    - php: 7.1
+    - php: 7.2
+    - php: 7.3
+    - php: 7.4
 
 install:
   - composer install

composer.json

@@ -9,7 +9,7 @@
         "php": ">=7.1.0"
     },
     "require-dev": {
-        "phpunit/phpunit": "^7"
+        "phpunit/phpunit": "^9.0 || ^7.5"
     },
     "autoload": {
         "psr-4": {

phpunit.xml.dist

@@ -1,15 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 
-<phpunit backupGlobals="false"
-         backupStaticAttributes="false"
-         colors="true"
-         convertErrorsToExceptions="true"
-         convertNoticesToExceptions="true"
-         convertWarningsToExceptions="true"
-         processIsolation="false"
-         stopOnFailure="false"
-         bootstrap="vendor/autoload.php"
->
+<phpunit bootstrap="vendor/autoload.php" colors="true">
     <testsuites>
         <testsuite name="Promise Test Suite">
             <directory>./tests/</directory>

tests/PromiseTest/PromiseFulfilledTestTrait.php

@@ -237,7 +237,7 @@ public function doneShouldTriggerFatalErrorThrownFulfillmentHandlerForFulfilledP
         $errors = $errorCollector->stop();
 
         self::assertEquals(E_USER_ERROR, $errors[0]['errno']);
-        self::assertContains('Unhandled Rejection', $errors[0]['errstr']);
+        self::assertStringContainsString('Unhandled Rejection', $errors[0]['errstr']);
     }
 
     /** @test */
@@ -257,7 +257,7 @@ public function doneShouldTriggerFatalErrorUnhandledRejectionExceptionWhenFulfil
         $errors = $errorCollector->stop();
 
         self::assertEquals(E_USER_ERROR, $errors[0]['errno']);
-        self::assertContains('Unhandled Rejection', $errors[0]['errstr']);
+        self::assertStringContainsString('Unhandled Rejection', $errors[0]['errstr']);
     }
 
     /** @test */

tests/PromiseTest/PromiseRejectedTestTrait.php

@@ -229,7 +229,7 @@ public function doneShouldTriggerFatalErrorExceptionThrownByRejectionHandlerForR
         $errors = $errorCollector->stop();
 
         self::assertEquals(E_USER_ERROR, $errors[0]['errno']);
-        self::assertContains('Unhandled Rejection', $errors[0]['errstr']);
+        self::assertStringContainsString('Unhandled Rejection', $errors[0]['errstr']);
     }
 
     /** @test */
@@ -248,7 +248,7 @@ public function doneShouldTriggerFatalErrorRejectionExceptionWhenRejectionHandle
         $errors = $errorCollector->stop();
 
         self::assertEquals(E_USER_ERROR, $errors[0]['errno']);
-        self::assertContains('Unhandled Rejection', $errors[0]['errstr']);
+        self::assertStringContainsString('Unhandled Rejection', $errors[0]['errstr']);
     }
 
     /** @test */

tests/PromiseTest/RejectTestTrait.php

@@ -142,7 +142,7 @@ public function doneShouldTriggerFatalErrorExceptionThrownByRejectionHandler()
         $errors = $errorCollector->stop();
 
         self::assertEquals(E_USER_ERROR, $errors[0]['errno']);
-        self::assertContains('Unhandled Rejection', $errors[0]['errstr']);
+        self::assertStringContainsString('Unhandled Rejection', $errors[0]['errstr']);
     }
 
     /** @test */
@@ -161,7 +161,7 @@ public function doneShouldTriggerFatalErrorRejectionExceptionWhenRejectionHandle
         $errors = $errorCollector->stop();
 
         self::assertEquals(E_USER_ERROR, $errors[0]['errno']);
-        self::assertContains('Unhandled Rejection', $errors[0]['errstr']);
+        self::assertStringContainsString('Unhandled Rejection', $errors[0]['errstr']);
     }
 
     /** @test */
@@ -184,7 +184,7 @@ public function doneShouldTriggerFatalErrorUnhandledRejectionExceptionWhenReject
         $errors = $errorCollector->stop();
 
         self::assertEquals(E_USER_ERROR, $errors[0]['errno']);
-        self::assertContains('Unhandled Rejection', $errors[0]['errstr']);
+        self::assertStringContainsString('Unhandled Rejection', $errors[0]['errstr']);
     }
 
     /** @test */
@@ -201,7 +201,7 @@ public function doneShouldTriggerFatalErrorExceptionProvidedAsRejectionValue()
         $errors = $errorCollector->stop();
 
         self::assertEquals(E_USER_ERROR, $errors[0]['errno']);
-        self::assertContains('Unhandled Rejection', $errors[0]['errstr']);
+        self::assertStringContainsString('Unhandled Rejection', $errors[0]['errstr']);
     }
 
     /** @test */

tests/PromiseTest/ResolveTestTrait.php

@@ -200,7 +200,7 @@ public function doneShouldTriggerFatalErrorExceptionThrownFulfillmentHandler()
         $errors = $errorCollector->stop();
 
         self::assertEquals(E_USER_ERROR, $errors[0]['errno']);
-        self::assertContains('Unhandled Rejection', $errors[0]['errstr']);
+        self::assertStringContainsString('Unhandled Rejection', $errors[0]['errstr']);
     }
 
     /** @test */
@@ -219,7 +219,7 @@ public function doneShouldTriggerFatalErrorUnhandledRejectionExceptionWhenFulfil
         $errors = $errorCollector->stop();
 
         self::assertEquals(E_USER_ERROR, $errors[0]['errno']);
-        self::assertContains('Unhandled Rejection', $errors[0]['errstr']);
+        self::assertStringContainsString('Unhandled Rejection', $errors[0]['errstr']);
     }
 
     /** @test */

tests/Stub/CallableStub.php

@@ -37,10 +37,14 @@ public function expectCallableNever(): callable
         return $mock;
     }
 
-    public function createCallableMock()
+    protected function createCallableMock()
     {
-        return $this
-            ->getMockBuilder(CallableStub::class)
-            ->getMock();
+        if (method_exists('PHPUnit\Framework\MockObject\MockBuilder', 'addMethods')) {
+            // PHPUnit 9+
+            return $this->getMockBuilder('stdClass')->addMethods(array('__invoke'))->getMock();
+        } else {
+            // legacy PHPUnit 4 - PHPUnit 9
+            return $this->getMockBuilder('stdClass')->setMethods(array('__invoke'))->getMock();
+        }
     }
 }