Skip to content

Commit b3b0474

Browse files
authored
Update README.md (#986)
1 parent e8b2e4e commit b3b0474

File tree

1 file changed

+24
-1
lines changed

1 file changed

+24
-1
lines changed

README.md

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@ A source code example utilizing React-Rails: https://github.com/BookOfGreg/react
4040
- [Upgrading](#upgrading)
4141
- [2.3 to 2.4](#23-to-24)
4242
- [Common Errors](#common-errors)
43+
- [During installation](#during-installation)
44+
- [Undefined Set](#undefined-set)
45+
- [Using TheRubyRacer](#using-therubyracer)
46+
- [HMR](#hmr)
4347
- [Related Projects](#related-projects)
4448
- [Contributing](#contributing)
4549

@@ -627,6 +631,7 @@ For the vast majority of cases this will get you most of the migration:
627631
- re-run `bundle exec rails webpacker:install:react` to update npm packages (Webpacker only)
628632

629633
## Common Errors
634+
### During installation
630635
1) While using installers.(rails webpacker:install:react && rails webpacker:install)
631636
Error:
632637
```
@@ -650,6 +655,24 @@ sudo apt-get update && sudo apt-get install yarn
650655
651656
yarn install
652657
```
658+
### Undefined Set
659+
```
660+
ExecJS::ProgramError (identifier 'Set' undefined):
661+
662+
(execjs):1
663+
```
664+
If you see any variation of this issue, see [Using TheRubyRacer](#using-therubyracer)
665+
666+
667+
### Using TheRubyRacer
668+
TheRubyRacer [hasn't updated LibV8](https://github.com/cowboyd/therubyracer/blob/master/therubyracer.gemspec#L20) (The library that powers Node.js) from v3 in 2 years, any new features are unlikely to work.
669+
670+
LibV8 itself is already [beyond version 7](https://github.com/cowboyd/libv8/releases/tag/v7.3.492.27.1) therefore many serverside issues are caused by old JS engines and fixed by using an up to date one such as [MiniRacer](https://github.com/discourse/mini_racer) or [TheRubyRhino](https://github.com/cowboyd/therubyrhino) on JRuby.
671+
672+
### HMR
673+
HRM is possible with this gem as it does just pass through to Webpacker. Please open an issue to let us know tips and tricks for it to add to the wiki.
674+
675+
One example: [Stack Overflow answer with Babel and Webpacker config](https://stackoverflow.com/a/54846330/193785)
653676

654677
## Related Projects
655678

@@ -664,7 +687,7 @@ yarn install
664687

665688
🎉 Thanks for taking the time to contribute! 🎉
666689

667-
With 2 Million+ downloads of the react-rails Gem and another 100k+ downloads of react_ujs on NPM, you're helping the biggest React + Rails community!
690+
With 5 Million+ downloads of the react-rails Gem and another 2 Million+ downloads of react_ujs on NPM, you're helping the biggest React + Rails community!
668691

669692
By contributing to React-Rails, you agree to abide by the [code of conduct](https://github.com/reactjs/react-rails/blob/master/CODE_OF_CONDUCT.md).
670693

0 commit comments

Comments
 (0)