Simplify assertion of non-prerendered react component

Author: rmosolgo

test/dummy/app/controllers/server_controller.rb

@@ -16,21 +16,23 @@ def console_example_suppressed
   end
 
   def inline_component_prerender_true
-    render component: 'TodoList',
-           props: { todos: ['Render this inline'] },
-           tag: 'span',
-           class: 'custom-class',
-           id: 'custom-id',
-           data: { remote: true }
+    render(component_options)
   end
 
   def inline_component_prerender_false
-    render component: 'TodoList',
-           props: { todos: ['Render this inline'] },
-           tag: 'span',
-           class: 'custom-class',
-           id: 'custom-id',
-           data: { remote: true },
-           prerender: false
+    render(component_options.merge(prerender: false))
+  end
+
+  private
+
+  def component_options
+    {
+      component: 'TodoList',
+      props: { todos: ['Render this inline'] },
+      tag: 'span',
+      class: 'custom-class',
+      id: 'custom-id',
+      data: { remote: true }
+    }
   end
 end

test/server_rendered_html_test.rb

@@ -71,17 +71,8 @@ def wait_to_ensure_asset_pipeline_detects_changes
     test 'react inline component rendering (not pre-rendered)' do
       get '/server/inline_component_prerender_false'
       rendered_html = response.body
-
-      assert_match(/<span.*data-react-class=\"TodoList\"/, rendered_html)
-      # make sure that the items are prerendered
-      assert_match(/Render this inline/, rendered_html)
-      assert_match(/<\/span>/, rendered_html, "it accepts a tag override")
-      # make sure that the layout is rendered with the component
-      assert_match(/<title>Dummy<\/title>/, rendered_html)
-      # make sure that custom html attributes are rendered
-      assert_match(/class=\"custom-class\"/, rendered_html)
-      assert_match(/id=\"custom-id\"/, rendered_html)
-      assert_match(/data-remote=\"true\"/, rendered_html)
+      # make sure the tag closes immediately:
+      assert_match(/<span.*data-react-class=\"TodoList\"[^<]*><\/span>/, rendered_html)
     end
   end
 end