Catch all the JavaScript Engine Switcher's exceptions (#646)

Author: Taritsyn

src/React.Core/JavaScriptEngineFactory.cs

@@ -185,18 +185,16 @@ private void LoadUserScripts(IJsEngine engine)
 						engine.ExecuteFile(_fileSystem, file);
 					}
 				}
-				catch (JsScriptException ex)
+				catch (JsException ex)
 				{
 					// We can't simply rethrow the exception here, as it's possible this is running
 					// on a background thread (ie. as a response to a file changing). If we did
 					// throw the exception here, it would terminate the entire process. Instead,
 					// save the exception, and then just rethrow it later when getting the engine.
 					_scriptLoadException = new ReactScriptLoadException(string.Format(
-						"Error while loading \"{0}\": {1}\r\nLine: {2}\r\nColumn: {3}",
+						"Error while loading \"{0}\": {1}",
 						file,
-						ex.Message,
-						ex.LineNumber,
-						ex.ColumnNumber
+						ex.Message
 					));
 				}
 				catch (IOException ex)

src/React.Core/ReactComponent.cs

@@ -195,7 +195,7 @@ public virtual void RenderHtml(TextWriter writer, bool renderContainerOnly = fal
 						return;
 					}
 				}
-				catch (JsRuntimeException ex)
+				catch (JsException ex)
 				{
 					if (exceptionHandler == null)
 					{

src/React.Core/ReactEnvironment.cs

@@ -209,7 +209,7 @@ protected virtual void EnsureUserScriptsLoaded()
 						Engine.Execute(contents, file);
 					}
 				}
-				catch (JsScriptException ex)
+				catch (JsException ex)
 				{
 					throw new ReactScriptLoadException(string.Format(
 						"Error while loading \"{0}\": {1}",

tests/React.Tests/Core/JavaScriptEngineFactoryTest.cs

@@ -466,7 +466,7 @@ public void ShouldThrowScriptErrorIfReactFails()
 			var factory = CreateFactory(config, cache, fileSystem, () => jsEngine.Object);
 
 			var ex = Assert.Throws<ReactScriptLoadException>(() => factory.GetEngineForCurrentThread());
-			Assert.Equal("Error while loading \"foo.js\": Fail\r\nLine: 42\r\nColumn: 911", ex.Message);
+			Assert.Equal("Error while loading \"foo.js\": Fail", ex.Message);
 		}
 
 		[Fact]
@@ -489,7 +489,7 @@ public void ShouldCatchErrorsWhileLoadingScripts()
 			var factory = CreateFactory(config, cache, fileSystem, () => jsEngine.Object);
 
 			var ex = Assert.Throws<ReactScriptLoadException>(() => factory.GetEngineForCurrentThread());
-			Assert.Equal("Error while loading \"foo.js\": Fail\r\nLine: 42\r\nColumn: 911", ex.Message);
+			Assert.Equal("Error while loading \"foo.js\": Fail", ex.Message);
 		}
 
 		[Fact]