Skip adding to _components during ReactWithInit (#1155)

Author: dustinsoftware

src/React.Core/IReactEnvironment.cs

@@ -82,8 +82,9 @@ public interface IReactEnvironment
 		/// <param name="containerId">ID to use for the container HTML tag. Defaults to an auto-generated ID</param>
 		/// <param name="clientOnly">True if server-side rendering will be bypassed. Defaults to false.</param>
 		/// <param name="serverOnly">True if this component only should be rendered server-side. Defaults to false.</param>
+		/// <param name="skipLazyInit">Skip adding to components list, which is used during GetInitJavascript</param>
 		/// <returns>The component</returns>
-		IReactComponent CreateComponent<T>(string componentName, T props, string containerId = null, bool clientOnly = false, bool serverOnly = false);
+		IReactComponent CreateComponent<T>(string componentName, T props, string containerId = null, bool clientOnly = false, bool serverOnly = false, bool skipLazyInit = false);
 
 		/// <summary>
 		/// Adds the provided <see cref="IReactComponent"/> to the list of components to render client side.

src/React.Core/ReactEnvironment.cs

@@ -273,8 +273,9 @@ public virtual bool HasVariable(string name)
 		/// <param name="containerId">ID to use for the container HTML tag. Defaults to an auto-generated ID</param>
 		/// <param name="clientOnly">True if server-side rendering will be bypassed. Defaults to false.</param>
 		/// <param name="serverOnly">True if this component only should be rendered server-side. Defaults to false.</param>
+		/// <param name="skipLazyInit">Skip adding to components list, which is used during GetInitJavascript</param>
 		/// <returns>The component</returns>
-		public virtual IReactComponent CreateComponent<T>(string componentName, T props, string containerId = null, bool clientOnly = false, bool serverOnly = false)
+		public virtual IReactComponent CreateComponent<T>(string componentName, T props, string containerId = null, bool clientOnly = false, bool serverOnly = false, bool skipLazyInit = false)
 		{
 			if (!clientOnly)
 			{
@@ -287,7 +288,11 @@ public virtual IReactComponent CreateComponent<T>(string componentName, T props,
 				Props = props,
 				ServerOnly = serverOnly
 			};
-			_components.Add(component);
+
+			if (!skipLazyInit)
+			{
+				_components.Add(component);
+			}
 			return component;
 		}
 

tests/React.Tests/Core/ReactEnvironmentTest.cs

@@ -218,6 +218,16 @@ public void StyleTagsReturned()
 			Assert.Equal("static/css/another-stylesheet.css", styles[1]);
 		}
 
+		[Fact]
+		public void SkipLazyInit()
+		{
+			var mocks = new Mocks();
+			var environment = mocks.CreateReactEnvironment();
+
+			environment.CreateComponent("ComponentName", new { }, skipLazyInit: true);
+			Assert.Equal("", environment.GetInitJavaScript());
+		}
+
 		public class Mocks
 		{
 			public Mock<PooledJsEngine> Engine { get; private set; }

tests/React.Tests/Mvc/HtmlHelperExtensionsTests.cs

@@ -49,6 +49,7 @@ public void ReactWithInitShouldReturnHtmlAndScript()
 				new { },
 				null,
 				false,
+				false,
 				false
 			)).Returns(component.Object);
 
@@ -109,6 +110,7 @@ public void ScriptNonceIsReturned()
 				new { },
 				null,
 				false,
+				false,
 				false
 			)).Returns(component.Object);
 
@@ -154,6 +156,7 @@ public void EngineIsReturnedToPoolAfterRender()
 				new { },
 				null,
 				true,
+				false,
 				false
 			)).Returns(component.Object);
 
@@ -184,6 +187,7 @@ public void ReactWithClientOnlyTrueShouldCallRenderHtmlWithTrue()
 				new { },
 				null,
 				true,
+				false,
 				false
 			)).Returns(component.Object);
 
@@ -212,7 +216,8 @@ public void ReactWithServerOnlyTrueShouldCallRenderHtmlWithTrue()
 				new { },
 				null,
 				false,
-				true
+				true,
+				false
 			)).Returns(component.Object);
 
 			var result = HtmlHelperExtensions.React(
@@ -250,7 +255,8 @@ public void RenderFunctionsCalledNonLazily()
 				new { },
 				null,
 				false,
-				true
+				true,
+				false
 			)).Returns(component.Object);
 
 			var result = HtmlHelperExtensions.React(