Tweaks to get sample site running in .NET Core

Author: Daniel15

src/React.AspNet/MemoryFileCacheCore.cs

@@ -12,6 +12,7 @@
 using System.Collections.Generic;
 using Microsoft.Extensions.Caching.Memory;
 using System.Linq;
+using Microsoft.AspNetCore.Hosting;
 using Microsoft.Extensions.FileProviders;
 
 namespace React.AspNet
@@ -28,11 +29,11 @@ public class MemoryFileCacheCore : ICache
 		/// Initializes a new instance of the <see cref="MemoryFileCacheCore" /> class.
 		/// </summary>
 		/// <param name="cache">The cache to use</param>
-		/// <param name="fileProvider">The file provider.</param>
-		public MemoryFileCacheCore(IMemoryCache cache, IFileProvider fileProvider)
+		/// <param name="hostingEnv">The ASP.NET hosting environment.</param>
+		public MemoryFileCacheCore(IMemoryCache cache, IHostingEnvironment hostingEnv)
 		{
 			_cache = cache;
-			_fileProvider = fileProvider;
+			_fileProvider = hostingEnv.ContentRootFileProvider;
 		}
 
 		/// <summary>

src/React.AspNet/ReactBuilderExtensions.cs

@@ -11,10 +11,12 @@
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Hosting;
 using Microsoft.AspNetCore.Http;
-using Microsoft.Extensions.PlatformAbstractions;
 using React.Exceptions;
 using React.TinyIoC;
 using Microsoft.Extensions.DependencyInjection;
+#if !NET451
+using Microsoft.Extensions.Caching.Memory;
+#endif
 
 namespace React.AspNet
 {
@@ -38,7 +40,7 @@ public static IApplicationBuilder UseReact(
 		{
 			EnsureServicesRegistered(app);
 
-			React.AssemblyRegistration.Container.Register(app.ApplicationServices.GetRequiredService<IHostingEnvironment>());
+			RegisterAspNetServices(React.AssemblyRegistration.Container, app.ApplicationServices);
 
 			Initializer.Initialize(registerOptions => AsPerRequestSingleton(
 				app.ApplicationServices.GetService<IHttpContextAccessor>(), 
@@ -82,5 +84,19 @@ private static void EnsureServicesRegistered(IApplicationBuilder app)
 				throw new ReactNotInitialisedException("Please call app.AddReact() before app.UseReact().");
 			}
 		}
+
+		/// <summary>
+		/// Registers required ASP.NET services in ReactJS.NET's TinyIoC container. This is used
+		/// for ASP.NET services that are required by ReactJS.NET.
+		/// </summary>
+		/// <param name="container">ReactJS.NET dependency injection container</param>
+		/// <param name="services">ASP.NET dependency injection container</param>
+		private static void RegisterAspNetServices(TinyIoCContainer container, IServiceProvider services)
+		{
+			container.Register(services.GetRequiredService<IHostingEnvironment>());
+#if !NET451
+			container.Register(services.GetRequiredService<IMemoryCache>());
+#endif
+		}
 	}
 }

src/React.Core/JavaScriptEngineFactory.cs

@@ -8,6 +8,8 @@
 using JavaScriptEngineSwitcher.Msie;
 #if NET40
 using JavaScriptEngineSwitcher.V8;
+#else
+using JavaScriptEngineSwitcher.ChakraCore;
 #endif
 using JSPool;
 using React.Exceptions;
@@ -367,15 +369,13 @@ private static void EnsureJsEnginesRegistered(JsEngineSwitcher jsEngineSwitcher,
 #if NET40
 			jsEngineSwitcher.EngineFactories.AddV8();
 #endif
+			jsEngineSwitcher.EngineFactories.Add(new VroomJsEngine.Factory());
 			if (allowMsie)
 			{
 				jsEngineSwitcher.EngineFactories.AddMsie();
 			}
-#if NET40 || NETSTANDARD1_6
-			if (JavaScriptEngineUtils.EnvironmentSupportsVroomJs())
-			{
-				jsEngineSwitcher.EngineFactories.Add(new VroomJsEngine.Factory());
-			}
+#if !NET40
+			jsEngineSwitcher.EngineFactories.AddChakraCore();
 #endif
 		}
 	}

src/React.Sample.ConsoleApp/project.json

@@ -1,5 +1,5 @@
 {
-  "version": "2.6.0-*",
+  "version": "3.0.0-*",
   "title": "ReactJS.NET Console Sample",
   "authors": [ "Daniel Lo Nigro" ],
   "copyright": "Copyright 2014-Present Facebook, Inc",
@@ -20,6 +20,14 @@
   },
 
   "frameworks": {
-    "net40": {}
+    "net40": {},
+    "netcoreapp1.0": {
+      "dependencies": {
+        "Microsoft.NETCore.App": {
+          "type": "platform",
+          "version": "1.0.0"
+        }
+      }
+    } 
   }
 }

src/React.Sample.Mvc6/project.json

@@ -18,8 +18,7 @@
     },
     "React.AspNet": {
       "target": "project"
-    },
-    "JavaScriptEngineSwitcher.V8": "2.0.0"
+    }
   },
 
   "tools": {
@@ -30,14 +29,33 @@
   },
 
   "frameworks": {
-    "net451": { }
+    "net451": {
+      "dependencies": {
+        "JavaScriptEngineSwitcher.V8": "2.0.0"
+      }
+    },
+    "netcoreapp1.0": {
+      "dependencies": {
+        "Microsoft.NETCore.App": {
+          "version": "1.0.0",
+          "type": "platform"
+        },
+        "VroomJs": "1.2.3"
+      }
+    }
   },
 
   "buildOptions": {
     "emitEntryPoint": true,
     "preserveCompilationContext": true
   },
 
+  "runtimeOptions": {
+    "configProperties": {
+      "System.GC.Server": true
+    }
+  },
+
   "publishOptions": {
     "include": [
       "wwwroot",