Fix unhelpful error message if React can't be loaded

If React fails to load from a user-provided bundle, the script load
exception would be hidden from the user, because the exception is stored
to a field and then rethrown later. EnsureReactLoaded was
getting called before the real exception was thrown, which threw a new
(unhelpful) exception.

Author: dustinsoftware

src/React.Core/JavaScriptEngineFactory.cs

@@ -135,7 +135,7 @@ protected virtual void InitialiseEngine(IJsEngine engine)
 			}
 
 			LoadUserScripts(engine);
-			if (!_config.LoadReact)
+			if (!_config.LoadReact && _scriptLoadException == null)
 			{
 				// We expect to user to have loaded their own version of React in the scripts that
 				// were loaded above, let's ensure that's the case. 

tests/React.Tests/Core/JavaScriptEngineFactoryTest.cs

@@ -164,6 +164,28 @@ public void ShouldThrowIfReactVersionNotLoaded()
 			});
 		}
 
+		[Fact]
+		public void ShouldThrowScriptErrorIfReactFails()
+		{
+			var config = new Mock<IReactSiteConfiguration>();
+			config.Setup(x => x.ScriptsWithoutTransform).Returns(new List<string> {"foo.js"});
+			config.Setup(x => x.LoadReact).Returns(false);
+			var fileSystem = new Mock<IFileSystem>();
+			fileSystem.Setup(x => x.ReadAsString("foo.js")).Returns("FAIL PLZ");
+
+			var jsEngine = new Mock<IJsEngine>();
+			jsEngine.Setup(x => x.Evaluate<int>("1 + 1")).Returns(2);
+			jsEngine.Setup(x => x.Execute("FAIL PLZ")).Throws(new JsRuntimeException("Fail")
+			{
+				LineNumber = 42,
+				ColumnNumber = 911,
+			});
+			var factory = CreateFactory(config, fileSystem, () => jsEngine.Object);
+
+			var ex = Assert.Throws<ReactScriptLoadException>(() => factory.GetEngineForCurrentThread());
+			Assert.Equal("Error while loading \"foo.js\": Fail\r\nLine: 42\r\nColumn: 911", ex.Message);
+		}
+
 		[Fact]
 		public void ShouldCatchErrorsWhileLoadingScripts()
 		{