Skip to content

Commit bc05c69

Browse files
committed
fix flake8 with noqa
1 parent 4926a38 commit bc05c69

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

setup.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
from __future__ import print_function
22

33
import pipes
4+
import shutil
45
import subprocess
56
import sys
67
import traceback
@@ -129,7 +130,10 @@ def run(self):
129130
log.info("Installing Javascript...")
130131
try:
131132
js_dir = str(package_dir / "client" / "app")
132-
for args in ("npm install", "npm run build"):
133+
npm = shutil.which("npm") # this is required on windows
134+
if npm is None:
135+
raise RuntimeError("NPM is not installed.")
136+
for args in (f"{npm} install", f"{npm} run build"):
133137
args_list = args.split()
134138
log.info(f"> {list2cmdline(args_list)}")
135139
subprocess.run(args_list, cwd=js_dir)

src/idom/core/vdom.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def validate_vdom(value: Any) -> None:
9191
class ImportSourceDict(TypedDict):
9292
source: str
9393
fallback: Any
94-
sourceType: str
94+
sourceType: str # noqa
9595
exportsMount: bool # noqa
9696

9797

0 commit comments

Comments
 (0)