Skip to content

Commit 3f13d23

Browse files
committed
remove version name following "+" char
also does not show spinner during docker image build
1 parent f439e2b commit 3f13d23

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

docs/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ ADD README.md ./
2424
ADD idom/client/app/favicon.ico ./
2525

2626
RUN pip install -e .[all]
27-
RUN python -m idom install victory semantic-ui-react @material-ui/core
27+
RUN IDOM_SHOW_SPINNER=false python -m idom install victory semantic-ui-react @material-ui/core
2828

2929
# Build the Docs
3030
# --------------

docs/source/conf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
copyright = "2019, Ryan Morshead"
2828
author = "Ryan Morshead"
2929

30-
release = get_distribution("idom").version
30+
release = get_distribution("idom").version.split("+")[0]
3131
# for example take major/minor
3232
version = ".".join(release.split(".")[:2])
3333

idom/__main__.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import os
12
import sys
23
import argparse
34
from typing import TypeVar, Callable, Any, DefaultDict, Dict
@@ -55,12 +56,15 @@ def run(args: argparse.Namespace) -> None:
5556
f"{args.command!r} does not support {k}={getattr(args, k)}"
5657
)
5758

59+
show_spinner_envvar = os.environ.get("IDOM_SHOW_SPINNER", "true").lower()
60+
show_spinner = {"true": True, "false": False}[show_spinner_envvar]
61+
5862
if args.command == "install":
59-
install(args.dependencies or [], args.exports or [], show_spinner=True)
63+
install(args.dependencies or [], args.exports or [], show_spinner=show_spinner)
6064
elif args.command == "uninstall":
6165
delete_web_modules(args.dependencies)
6266
elif args.command == "restore":
63-
restore(show_spinner=True)
67+
restore(show_spinner=show_spinner)
6468
else:
6569
print("Installed:")
6670
for name in installed():

0 commit comments

Comments
 (0)