Skip to content

Commit 1a161b2

Browse files
committed
fix misc bugs
1 parent 0e507b4 commit 1a161b2

File tree

4 files changed

+12
-10
lines changed

4 files changed

+12
-10
lines changed

docs/main.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,12 +65,12 @@ async def forward_to_index(request):
6565
server = PerClientStateServer(element, {"redirect_root_to_index": False}).register(app)
6666

6767

68-
def prod():
69-
app.run(
68+
def production():
69+
server.run(
7070
host="0.0.0.0",
7171
port=int(os.environ.get("PORT", 5000)),
7272
workers=int(os.environ.get("WEB_CONCURRENCY", 1)),
73-
debug={"true": True, "false": False}[os.environ.get("DEBUG", "False").lower()],
73+
debug=bool(int(os.environ.get("DEBUG", "0"))),
7474
)
7575

7676

@@ -84,4 +84,4 @@ def local(path=""):
8484

8585

8686
if __name__ == "__main__":
87-
prod()
87+
production()

idom/client/build_config.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,10 @@ def resolve_js_dependency_name(
6565
source_name: str,
6666
dependency_name: str,
6767
) -> Optional[str]:
68-
info = self._item_info[source_name]
68+
try:
69+
info = self._item_info[source_name]
70+
except KeyError:
71+
return None
6972
if info.js_package_def is not None:
7073
if info.js_package_def.name != dependency_name:
7174
return None

scripts/install_doc_js_modules.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,9 @@ def install_doc_js_modules():
1111
config_item = find_build_config_item_in_python_file(
1212
"__main__", DOCS_PATH / "main.py"
1313
)
14-
if (
15-
config_item is not None
16-
and config_item["source_name"] not in build_config().config["items"]
17-
):
18-
build([config_item])
14+
if config_item is not None:
15+
if not build_config().has_config_item(config_item["source_name"]):
16+
build([config_item])
1917

2018

2119
if __name__ == "__main__":

tests/test_client/test_build_config.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,7 @@ def test_build_config_all_js_dependency_names(prefab_build_config):
262262
("module_1:missing_dep", None),
263263
("module_3:some_js_pkg", "some_js_pkg"),
264264
("module_3:missing_dep", None),
265+
("missing_module:some_dep", None),
265266
],
266267
)
267268
def test_resolve_js_dependency_name(prefab_build_config, given_dep, resolved_dep):

0 commit comments

Comments
 (0)