fix tests

Author: Archmonger

flake8_idom_hooks/utils.py

@@ -29,8 +29,14 @@ def is_hook_def(node: ast.FunctionDef) -> bool:
 
 def is_component_def(node: ast.FunctionDef) -> bool:
     return any(
-        decorator.value.id == "idom" and decorator.attr == "component"
-        for decorator in node.decorator_list
+        is_idom_component_decorator(decorator) for decorator in node.decorator_list
+    )
+
+
+def is_idom_component_decorator(node) -> bool:
+    return getattr(node, "id", None) == "component" or (
+        getattr(getattr(node, "value", None), "id", None) == "idom"
+        and getattr(node, "attr", None) == "component"
     )
 
 

tests/hook_usage_test_cases.py

@@ -1,3 +1,4 @@
+import idom
 from idom import component
 
 
@@ -88,16 +89,14 @@ def HookInWhileLoop():
         use_state
 
 
-@component
 def outer_function():
     # error: ROH100 hook 'use_state' defined as closure in function 'outer_function'
-    @component
     def use_state():
         ...
 
 
-@component
 def generic_function():
+
     # error: ROH101 hook 'use_state' used outside component or hook definition
     use_state
 
@@ -112,6 +111,11 @@ def Component():
     use_state
 
 
+@idom.component
+def IdomLongImportComponent():
+    use_state
+
+
 @component
 def use_custom_hook():
     use_state
@@ -124,7 +128,6 @@ def use_custom_hook():
 module.use_effect()
 
 
-@component
 def not_hook_or_component():
     # error: ROH101 hook 'use_state' used outside component or hook definition
     use_state
@@ -187,41 +190,34 @@ def CheckEffects():
     )
 
     @use_effect(args=[x])
-    @component
     def my_effect():
         x
 
     @use_effect(args=[])
-    @component
     def my_effect():
         # error: ROH202 dependency 'x' of function 'my_effect' is not specified in declaration of 'use_effect'
         x
 
     @use_effect(args=[])
     @some_other_deco_that_adds_args_to_func_somehow
-    @component
     def my_effect(*args, **kwargs):
         args
         kwargs
 
     @module.use_effect(args=[])
-    @component
     def my_effect():
         # error: ROH202 dependency 'x' of function 'my_effect' is not specified in declaration of 'use_effect'
         x
 
     @not_a_decorator_we_care_about
-    @component
     def some_func():
         ...
 
     @not_a_decorator_we_care_about()
-    @component
     def some_func():
         ...
 
     @use_effect
-    @component
     def impropper_usage_of_effect_as_decorator():
         # ignored because bad useage
         x