improve component decorator check

Author: rmorshea

flake8_idom_hooks/utils.py

@@ -1,7 +1,10 @@
 import ast
+import re
 from contextlib import contextmanager
 from typing import Any, Iterator, List, Tuple
 
+_COMPONENT_DECORATOR_NAME_PATTERN = re.compile(r"^(idom.(\w+\.)*)?component$")
+
 
 @contextmanager
 def set_current(obj: Any, **attrs: Any) -> Iterator[None]:
@@ -28,17 +31,25 @@ def is_hook_def(node: ast.FunctionDef) -> bool:
 
 
 def is_component_def(node: ast.FunctionDef) -> bool:
-    return any(
-        is_idom_component_decorator(decorator) for decorator in node.decorator_list
-    )
+    return any(map(_is_component_decorator, node.decorator_list))
+
+
+def is_hook_function_name(name: str) -> bool:
+    return name.lstrip("_").startswith("use_")
 
 
-def is_idom_component_decorator(node: Any) -> bool:
-    return getattr(node, "id", None) == "component" or (
-        getattr(getattr(node, "value", None), "id", None) == "idom"
-        and getattr(node, "attr", None) == "component"
+def _is_component_decorator(node: ast.AST) -> bool:
+    return (
+        _COMPONENT_DECORATOR_NAME_PATTERN.match(
+            ".".join(reversed(list(_get_dotted_name(node))))
+        )
+        is not None
     )
 
 
-def is_hook_function_name(name: str) -> bool:
-    return name.lstrip("_").startswith("use_")
+def _get_dotted_name(node: ast.AST) -> Iterator[str]:
+    while isinstance(node, ast.Attribute):
+        yield node.attr
+        node = node.value
+    if isinstance(node, ast.Name):
+        yield node.id

noxfile.py

@@ -6,6 +6,13 @@
 REQUIREMENTS_DIR = ROOT / "requirements"
 
 
+@session
+def format(session: Session) -> None:
+    install_requirements(session, "style")
+    session.run("black", ".")
+    session.run("isort", ".")
+
+
 @session
 def test(session: Session) -> None:
     session.notify("test_style")
@@ -17,6 +24,7 @@ def test(session: Session) -> None:
 @session
 def test_style(session: Session) -> None:
     install_requirements(session, "style")
+    session.run("black", "--check", ".")
     session.run("isort", "--check", ".")
     session.run("flake8", ".")