go back to snapshotting Django's debug value

Author: Archmonger

src/reactpy_django/clean.py

@@ -49,9 +49,8 @@ def clean_sessions(verbosity: int = 1):
     """Deletes expired component sessions from the database.
     As a performance optimization, this is only run once every REACTPY_SESSION_MAX_AGE seconds.
     """
-    from django.conf import settings as django_settings
 
-    from reactpy_django.config import REACTPY_SESSION_MAX_AGE
+    from reactpy_django.config import DJANGO_DEBUG, REACTPY_SESSION_MAX_AGE
     from reactpy_django.models import ComponentSession
 
     if verbosity >= 2:
@@ -68,7 +67,7 @@ def clean_sessions(verbosity: int = 1):
 
     session_objects.delete()
 
-    if django_settings.DEBUG or verbosity >= 2:
+    if DJANGO_DEBUG or verbosity >= 2:
         inspect_clean_duration(start_time, "component sessions", verbosity)
 
 
@@ -80,8 +79,7 @@ def clean_user_data(verbosity: int = 1):
     However, we can't use Django to enforce this relationship since ReactPy can be configured to
     use any database.
     """
-    from django.conf import settings as django_settings
-
+    from reactpy_django.config import DJANGO_DEBUG
     from reactpy_django.models import UserDataModel
 
     if verbosity >= 2:
@@ -105,7 +103,7 @@ def clean_user_data(verbosity: int = 1):
 
     user_data_objects.delete()
 
-    if django_settings.DEBUG or verbosity >= 2:
+    if DJANGO_DEBUG or verbosity >= 2:
         inspect_clean_duration(start_time, "user data", verbosity)
 
 

src/reactpy_django/config.py

@@ -23,6 +23,7 @@
 REACTPY_REGISTERED_IFRAME_VIEWS: dict[str, Callable | View] = {}
 
 # Configurable through Django settings.py
+DJANGO_DEBUG = settings.DEBUG  # Snapshot of Django's DEBUG setting
 _REACTPY_DEBUG_MODE.set_current(settings.DEBUG)
 _REACTPY_ASYNC_RENDERING.set_current(
     getattr(settings, "REACTPY_ASYNC_RENDERING", _REACTPY_ASYNC_RENDERING.current)

src/reactpy_django/templatetags/reactpy.py

@@ -74,7 +74,7 @@ def component(
         </body>
         </html>
     """
-    from django.conf import settings as django_settings
+    from reactpy_django.config import DJANGO_DEBUG
 
     request: HttpRequest | None = context.get("request")
     perceived_host = (request.get_host() if request else "").strip("/")
@@ -95,7 +95,7 @@ def component(
     _offline_html = ""
 
     # Validate the host
-    if host and django_settings.DEBUG:
+    if host and DJANGO_DEBUG:
         try:
             validate_host(host)
         except InvalidHostError as e:
@@ -110,7 +110,7 @@ def component(
             return failure_context(dotted_path, ComponentDoesNotExistError(msg))
 
     # Validate the component args & kwargs
-    if is_local and django_settings.DEBUG:
+    if is_local and DJANGO_DEBUG:
         try:
             validate_component_args(user_component, *args, **kwargs)
         except ComponentParamError as e:
@@ -236,21 +236,21 @@ def pyscript_setup(
         config: A JSON string or Python dictionary containing PyScript \
             configuration values.
     """
-    from django.conf import settings as django_settings
+    from reactpy_django.config import DJANGO_DEBUG
 
     return {
         "pyscript_config": extend_pyscript_config(extra_py, extra_js, config),
         "pyscript_layout_handler": PYSCRIPT_LAYOUT_HANDLER,
-        "django_debug": django_settings.DEBUG,
+        "django_debug": DJANGO_DEBUG,
     }
 
 
 def failure_context(dotted_path: str, error: Exception):
-    from django.conf import settings as django_settings
+    from reactpy_django.config import DJANGO_DEBUG
 
     return {
         "reactpy_failure": True,
-        "django_debug": django_settings.DEBUG,
+        "django_debug": DJANGO_DEBUG,
         "reactpy_dotted_path": dotted_path,
         "reactpy_error": type(error).__name__,
     }