better input transform

Author: Archmonger

src/reactpy_django/forms/components.py

@@ -13,9 +13,9 @@
 from reactpy_django.forms.transforms import (
     convert_html_props_to_reactjs,
     convert_textarea_children_to_prop,
-    ensure_input_elements_are_controlled,
     intercept_anchor_links,
     set_value_prop_on_select_element,
+    transform_value_prop_on_input_element,
 )
 from reactpy_django.forms.utils import convert_boolean_fields, convert_multiple_choice_fields
 from reactpy_django.types import FormEvent
@@ -122,7 +122,7 @@ def on_submit_callback(new_data: dict[str, Any]):
             convert_html_props_to_reactjs,
             convert_textarea_children_to_prop,
             set_value_prop_on_select_element,
-            ensure_input_elements_are_controlled,
+            transform_value_prop_on_input_element,
             intercept_anchor_links,
             *extra_transforms,
             strict=False,

src/reactpy_django/forms/transforms.py

@@ -46,11 +46,17 @@ def set_value_prop_on_select_element(vdom_tree: VdomDict) -> VdomDict:
     return vdom_tree
 
 
-def ensure_input_elements_are_controlled(vdom_tree: VdomDict) -> VdomDict:
+def transform_value_prop_on_input_element(vdom_tree: VdomDict) -> VdomDict:
     """Adds an onChange handler on form <input> elements, since ReactJS doesn't like uncontrolled inputs."""
-    vdom_tree.setdefault("eventHandlers", {})
-    if vdom_tree["tagName"] == "input" and "onChange" not in vdom_tree["eventHandlers"]:
-        vdom_tree["eventHandlers"]["onChange"] = EventHandler(to_event_handler_function(_do_nothing_event))
+    # vdom_tree.setdefault("eventHandlers", {})
+    # vdom_tree.setdefault("attributes", {})
+    # if vdom_tree["tagName"] == "input" and "onChange" not in vdom_tree["eventHandlers"]:
+    #     vdom_tree["eventHandlers"]["onChange"] = EventHandler(to_event_handler_function(_do_nothing_event))
+    #     vdom_tree["attributes"].setdefault("value", "")
+
+    vdom_tree.setdefault("attributes", {})
+    if vdom_tree["tagName"] == "input":
+        vdom_tree["attributes"].setdefault("defaultValue", vdom_tree["attributes"].pop("value", ""))
 
     return vdom_tree