Skip to content

Commit b859e18

Browse files
committed
fix(log): add error log details
1 parent 5aa3245 commit b859e18

File tree

2 files changed

+21
-14
lines changed

2 files changed

+21
-14
lines changed

async/async-commons/src/main/java/org/reactivecommons/async/commons/HandlerResolverBuilder.java

Lines changed: 19 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import java.util.Map;
1313
import java.util.concurrent.ConcurrentHashMap;
1414
import java.util.concurrent.ConcurrentMap;
15-
import java.util.logging.Level;
1615
import java.util.stream.Stream;
1716

1817
import static org.reactivecommons.async.api.HandlerRegistry.DEFAULT_DOMAIN;
@@ -45,43 +44,51 @@ public static HandlerResolver buildResolver(String domain,
4544
.collect(ConcurrentHashMap::new, (map, handler) -> map.put(handler.getPath(), handler),
4645
ConcurrentHashMap::putAll);
4746

48-
final ConcurrentMap<String, RegisteredEventListener<?, ?>> eventsToBind = getEventsToBind(domain, registries);
47+
final ConcurrentMap<String, RegisteredEventListener<?, ?>> eventsToBind = getEventsToBind(domain,
48+
registries);
4949

50-
final ConcurrentMap<String, RegisteredEventListener<?, ?>> eventHandlers = getEventHandlersWithDynamics(domain, registries);
50+
final ConcurrentMap<String, RegisteredEventListener<?, ?>> eventHandlers =
51+
getEventHandlersWithDynamics(domain, registries);
5152

52-
return new HandlerResolver(queryHandlers, eventHandlers, eventsToBind, eventNotificationListener, commandHandlers) {
53+
return new HandlerResolver(queryHandlers, eventHandlers, eventsToBind, eventNotificationListener,
54+
commandHandlers) {
5355
@Override
5456
@SuppressWarnings("unchecked")
5557
public <T, D> RegisteredCommandHandler<T, D> getCommandHandler(String path) {
5658
final RegisteredCommandHandler<T, D> handler = super.getCommandHandler(path);
57-
return handler != null ? handler : new RegisteredCommandHandler<>("", defaultCommandHandler, Object.class);
59+
return handler != null ? handler : new RegisteredCommandHandler<>("", defaultCommandHandler,
60+
Object.class);
5861
}
5962
};
6063
}
6164

6265

6366
final ConcurrentMap<String, RegisteredEventListener<?, ?>> eventsToBind = getEventsToBind(domain, registries);
64-
final ConcurrentMap<String, RegisteredEventListener<?, ?>> eventHandlers = getEventHandlersWithDynamics(domain, registries);
67+
final ConcurrentMap<String, RegisteredEventListener<?, ?>> eventHandlers =
68+
getEventHandlersWithDynamics(domain, registries);
6569

66-
return new HandlerResolver(new ConcurrentHashMap<>(), eventHandlers, eventsToBind, new ConcurrentHashMap<>(), new ConcurrentHashMap<>()) {
70+
return new HandlerResolver(new ConcurrentHashMap<>(), eventHandlers, eventsToBind, new ConcurrentHashMap<>(),
71+
new ConcurrentHashMap<>()) {
6772
@Override
6873
@SuppressWarnings("unchecked")
6974
public <T, D> RegisteredCommandHandler<T, D> getCommandHandler(String path) {
7075
final RegisteredCommandHandler<T, D> handler = super.getCommandHandler(path);
71-
return handler != null ? handler : new RegisteredCommandHandler<>("", defaultCommandHandler, Object.class);
76+
return handler != null ? handler : new RegisteredCommandHandler<>("", defaultCommandHandler,
77+
Object.class);
7278
}
7379
};
7480
}
7581

76-
private static ConcurrentMap<String, RegisteredEventListener<?, ?>> getEventHandlersWithDynamics(String domain, Map<String, HandlerRegistry> registries) {
82+
private static ConcurrentMap<String, RegisteredEventListener<?, ?>> getEventHandlersWithDynamics(String domain,
83+
Map<String,
84+
HandlerRegistry> registries) {
7785
// event handlers and dynamic handlers
7886
return registries
7987
.values().stream()
8088
.flatMap(r -> {
8189
if (r.getDomainEventListeners().containsKey(domain)) {
8290
return Stream.concat(r.getDomainEventListeners().get(domain).stream(), getDynamics(domain, r));
8391
}
84-
log.log(Level.WARNING, "Domain " + domain + "does not have a connection defined in your configuration and you want to listen from it");
8592
return Stream.empty();
8693
})
8794
.collect(ConcurrentHashMap::new, (map, handler) -> map.put(handler.getPath(), handler),
@@ -95,14 +102,14 @@ public <T, D> RegisteredCommandHandler<T, D> getCommandHandler(String path) {
95102
return Stream.of();
96103
}
97104

98-
private static ConcurrentMap<String, RegisteredEventListener<?, ?>> getEventsToBind(String domain, Map<String, HandlerRegistry> registries) {
105+
private static ConcurrentMap<String, RegisteredEventListener<?, ?>> getEventsToBind(String domain, Map<String,
106+
HandlerRegistry> registries) {
99107
return registries
100108
.values().stream()
101109
.flatMap(r -> {
102110
if (r.getDomainEventListeners().containsKey(domain)) {
103111
return r.getDomainEventListeners().get(domain).stream();
104112
}
105-
log.log(Level.WARNING, "Domain " + domain + "does not have a connection defined in your configuration and you want to listen from it");
106113
return Stream.empty();
107114
})
108115
.collect(ConcurrentHashMap::new, (map, handler) -> map.put(handler.getPath(), handler),

async/async-commons/src/main/java/org/reactivecommons/async/commons/utils/LoggerSubscriber.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public class LoggerSubscriber<T> extends BaseSubscriber<T> {
1414

1515
private final String flowName;
1616
private static final String ON_COMPLETE_MSG = "%s: ##On Complete Hook!!";
17-
private static final String ON_ERROR_MSG = "%s: ##On Error Hook!!";
17+
private static final String ON_ERROR_MSG = "%s: ##On Error Hook!! %s";
1818
private static final String ON_CANCEL_MSG = "%s: ##On Cancel Hook!!";
1919
private static final String ON_FINALLY_MSG = "%s: ##On Finally Hook! Signal type: %s";
2020

@@ -29,7 +29,7 @@ protected void hookOnComplete() {
2929

3030
@Override
3131
protected void hookOnError(Throwable throwable) {
32-
log.log(Level.SEVERE, format(ON_ERROR_MSG), throwable);
32+
log.log(Level.SEVERE, format(ON_ERROR_MSG, throwable.getMessage()), throwable);
3333
}
3434

3535
@Override

0 commit comments

Comments
 (0)