fix(health): ignore health indicator when dependency not exists

Author: juancgalvis

starters/async-commons-starter/src/main/java/org/reactivecommons/async/starter/config/health/RCHealthIndicator.java

@@ -5,7 +5,8 @@
 public abstract class RCHealthIndicator {
 
     public Mono<RCHealth> health() {
-        return doHealthCheck(RCHealth.builder());
+        return doHealthCheck(RCHealth.builder())
+                .onErrorResume(e -> Mono.just(RCHealth.builder().down().withDetail("error", e.getMessage()).build()));
     }
 
     public abstract Mono<RCHealth> doHealthCheck(RCHealth.RCHealthBuilder builder);

starters/async-commons-starter/src/test/java/org/reactivecommons/async/starter/config/health/ReactiveCommonsHealthIndicatorTest.java

@@ -37,11 +37,11 @@ void setUp() {
     @Test
     void shouldBeUp() {
         // Arrange
-        when(brokerProvider.healthCheck()).thenReturn(Mono.just(RCHealth.builder()
+        when(brokerProvider.healthCheck()).thenReturn(Mono.just(RCHealth.builder().up()
                 .withDetail(DOMAIN, DEFAULT_DOMAIN)
                 .withDetail(VERSION, "123")
                 .build()));
-        when(brokerProvider2.healthCheck()).thenReturn(Mono.just(RCHealth.builder()
+        when(brokerProvider2.healthCheck()).thenReturn(Mono.just(RCHealth.builder().up()
                 .withDetail(DOMAIN, OTHER)
                 .withDetail(VERSION, "1234")
                 .build()));
@@ -56,11 +56,11 @@ void shouldBeUp() {
     @Test
     void shouldBeDown() {
         // Arrange
-        when(brokerProvider.healthCheck()).thenReturn(Mono.just(RCHealth.builder()
+        when(brokerProvider.healthCheck()).thenReturn(Mono.just(RCHealth.builder().down()
                 .withDetail(DOMAIN, DEFAULT_DOMAIN)
                 .withDetail(VERSION, "123")
                 .build()));
-        when(brokerProvider2.healthCheck()).thenReturn(Mono.just(RCHealth.builder()
+        when(brokerProvider2.healthCheck()).thenReturn(Mono.just(RCHealth.builder().up()
                 .withDetail(DOMAIN, OTHER)
                 .withDetail(VERSION, "1234")
                 .build()));

starters/async-kafka-starter/src/test/java/org/reactivecommons/async/kafka/health/KafkaReactiveHealthIndicatorTest.java

@@ -9,6 +9,7 @@
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
+import org.reactivecommons.async.starter.config.health.RCHealth;
 import org.springframework.boot.actuate.health.Health;
 import org.springframework.boot.actuate.health.Health.Builder;
 import org.springframework.boot.actuate.health.Status;
@@ -39,13 +40,13 @@ void shouldBeUp() {
         when(adminClient.describeCluster()).thenReturn(describeClusterResult);
         when(describeClusterResult.clusterId()).thenReturn(KafkaFuture.completedFuture("cluster123"));
         // Act
-        Mono<Health> result = indicator.doHealthCheck(new Builder());
+        Mono<RCHealth> result = indicator.doHealthCheck(RCHealth.builder());
         // Assert
         StepVerifier.create(result)
                 .assertNext(health -> {
                     assertEquals(DEFAULT_DOMAIN, health.getDetails().get("domain"));
                     assertEquals("cluster123", health.getDetails().get("version"));
-                    assertEquals(Status.UP, health.getStatus());
+                    assertEquals(RCHealth.Status.UP, health.getStatus());
                 })
                 .verifyComplete();
     }
@@ -58,12 +59,12 @@ void shouldBeDown() {
         future.completeExceptionally(new RuntimeException("simulate error"));
         when(describeClusterResult.clusterId()).thenReturn(future);
         // Act
-        Mono<Health> result = indicator.doHealthCheck(new Builder());
+        Mono<RCHealth> result = indicator.doHealthCheck(RCHealth.builder());
         // Assert
         StepVerifier.create(result)
                 .expectNextMatches(health -> {
                     assertEquals(DEFAULT_DOMAIN, health.getDetails().get("domain"));
-                    assertEquals(Status.DOWN, health.getStatus());
+                    assertEquals(RCHealth.Status.DOWN, health.getStatus());
                     return true;
                 })
                 .verifyComplete();