Ignore unknown props in MessageConverter

Issue: gh-10

Author: Daniel Bustamante Ospina

async/async-commons-standalone/src/main/java/org/reactivecommons/async/impl/config/RabbitMqConfig.java

@@ -1,5 +1,6 @@
 package org.reactivecommons.async.impl.config;
 
+import com.fasterxml.jackson.databind.DeserializationFeature;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.rabbitmq.client.Connection;
 import com.rabbitmq.client.ConnectionFactory;
@@ -52,7 +53,7 @@ public ConnectionFactoryProvider connectionFactory(RabbitProperties properties){
     }
 
     public MessageConverter messageConverter(){
-        return new JacksonMessageConverter(new ObjectMapper());
+        return new JacksonMessageConverter();
     }
 
     Mono<Connection> createSenderConnectionMono(ConnectionFactory factory, String name){

async/async-commons-starter/src/main/java/org/reactivecommons/async/impl/config/RabbitMqConfig.java

@@ -1,6 +1,5 @@
 package org.reactivecommons.async.impl.config;
 
-import com.fasterxml.jackson.databind.ObjectMapper;
 import com.rabbitmq.client.Connection;
 import com.rabbitmq.client.ConnectionFactory;
 import lombok.AllArgsConstructor;
@@ -69,7 +68,7 @@ public ConnectionFactoryProvider connectionFactory(RabbitProperties properties){
     @Bean
     @ConditionalOnMissingBean
     public MessageConverter messageConverter(){
-        return new JacksonMessageConverter(new ObjectMapper());
+        return new JacksonMessageConverter();
     }
 
     Mono<Connection> createSenderConnectionMono(ConnectionFactory factory, String name){

async/async-commons/src/main/java/org/reactivecommons/async/impl/converters/JacksonMessageConverter.java

@@ -1,6 +1,7 @@
 package org.reactivecommons.async.impl.converters;
 
 
+import com.fasterxml.jackson.databind.DeserializationFeature;
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import lombok.Data;
@@ -20,7 +21,9 @@ public class JacksonMessageConverter implements MessageConverter {
 
     private final ObjectMapper objectMapper;
 
-    public JacksonMessageConverter(ObjectMapper objectMapper) {
+    public JacksonMessageConverter() {
+        final ObjectMapper objectMapper = new ObjectMapper();
+        objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
         this.objectMapper = objectMapper;
     }
 

async/async-commons/src/test/java/org/reactivecommons/async/impl/communications/ReactiveMessageSenderTest.java

@@ -36,7 +36,7 @@ public class ReactiveMessageSenderTest {
     private Sender sender;
 
     @Spy
-    private final MessageConverter messageConverter = new JacksonMessageConverter(new ObjectMapper());
+    private final MessageConverter messageConverter = new JacksonMessageConverter();
 
     @Before
     public void init() {

async/async-commons/src/test/java/org/reactivecommons/async/impl/converters/JacksonMessageConverterTest.java

@@ -1,33 +1,33 @@
 package org.reactivecommons.async.impl.converters;
 
-import static org.assertj.core.api.Assertions.*;
-import static org.mockito.Mockito.*;
-
+import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import lombok.Getter;
 import lombok.RequiredArgsConstructor;
 import org.junit.Test;
-import org.mockito.junit.MockitoJUnitRunner;
+import org.reactivecommons.api.domain.Command;
+import org.reactivecommons.async.impl.RabbitMessage;
 import org.reactivecommons.async.impl.communications.Message;
 
 import java.io.IOException;
 import java.util.Date;
 
+import static org.assertj.core.api.Assertions.assertThat;
+
 public class JacksonMessageConverterTest {
 
     private final ObjectMapper objectMapper = new ObjectMapper();
+    private final JacksonMessageConverter converter = new JacksonMessageConverter();
 
     @Test
     public void toMessage() {
-        JacksonMessageConverter converter = new JacksonMessageConverter(objectMapper);
         final Message message = converter.toMessage(new SampleClass("42", "Daniel", new Date()));
         assertThat(new String(message.getBody())).contains("42").contains("Daniel");
     }
 
     @Test
     public void toMessageWhenDataIsNull() throws IOException {
-        JacksonMessageConverter converter = new JacksonMessageConverter(new ObjectMapper());
         final Message message = converter.toMessage(null);
 
         final JsonNode jsonNode = objectMapper.readTree(message.getBody());
@@ -36,18 +36,42 @@ public void toMessageWhenDataIsNull() throws IOException {
 
     @Test
     public void toMessageWhenDataIsEmpty() throws IOException {
-        JacksonMessageConverter converter = new JacksonMessageConverter(new ObjectMapper());
         final Message message = converter.toMessage("");
 
         final JsonNode jsonNode = objectMapper.readTree(message.getBody());
         assertThat(jsonNode.asText()).isEmpty();
     }
 
+    @Test
+    public void shouldConvertWithUnknownProperties() throws JsonProcessingException {
+
+        final String value = objectMapper.writeValueAsString(new Command<>("test", "42",
+            new SampleClassExtra("23", "one", new Date(), 45l)));
+
+        final Command<SampleClass> command = converter.readCommand(new RabbitMessage(value.getBytes(),
+            null), SampleClass.class);
+
+        assertThat(command.getData()).extracting(SampleClass::getId, SampleClass::getName)
+            .containsExactly("23", "one");
+
+    }
+
     @RequiredArgsConstructor
     @Getter
     private static class SampleClass {
         private final String id;
         private final String name;
         private final Date date;
     }
+
+    @Getter
+    private static class SampleClassExtra extends SampleClass {
+
+        public SampleClassExtra(String id, String name, Date date, Long newProp) {
+            super(id, name, date);
+            this.newProp = newProp;
+        }
+
+        private final Long newProp;
+    }
 }