refactor: Fix some issues

Author: juancgalvis

async/async-kafka/src/main/java/org/reactivecommons/async/kafka/KafkaMessage.java

@@ -30,8 +30,8 @@ public String getContentType() {
         }
     }
 
-    public static KafkaMessage fromDelivery(ReceiverRecord<String, byte[]> record) {
-        return fromDelivery(record, null);
+    public static KafkaMessage fromDelivery(ReceiverRecord<String, byte[]> receiverRecord) {
+        return fromDelivery(receiverRecord, null);
     }
 
     public static KafkaMessage fromDelivery(ReceiverRecord<String, byte[]> receiverRecord, String type) {

async/async-rabbit/src/main/java/org/reactivecommons/async/rabbit/RabbitDomainEventBus.java

@@ -13,6 +13,8 @@
 
 public class RabbitDomainEventBus implements DomainEventBus {
 
+    private static final String EVENT_SEND_FAILURE = "Event send failure: ";
+    private static final String NOT_IMPLEMENTED_YET = "Not implemented yet";
     private final ReactiveMessageSender sender;
     private final String exchange;
     private final boolean persistentEvents;
@@ -30,35 +32,35 @@ public RabbitDomainEventBus(ReactiveMessageSender sender, String exchange, Broke
     @Override
     public <T> Mono<Void> emit(DomainEvent<T> event) {
         return sender.sendWithConfirm(event, exchange, event.getName(), Collections.emptyMap(), persistentEvents)
-                .onErrorMap(err -> new RuntimeException("Event send failure: " + event.getName(), err));
+                .onErrorMap(err -> new RuntimeException(EVENT_SEND_FAILURE + event.getName(), err));
     }
 
     @Override
     public <T> Publisher<Void> emit(String domain, DomainEvent<T> event) {
-        throw new UnsupportedOperationException("Not implemented yet");
+        throw new UnsupportedOperationException(NOT_IMPLEMENTED_YET);
     }
 
     @Override
     public Publisher<Void> emit(CloudEvent cloudEvent) {
         return sender.sendWithConfirm(cloudEvent, exchange, cloudEvent.getType(),
                         Collections.emptyMap(), persistentEvents)
-                .onErrorMap(err -> new RuntimeException("Event send failure: " + cloudEvent.getType(), err));
+                .onErrorMap(err -> new RuntimeException(EVENT_SEND_FAILURE + cloudEvent.getType(), err));
     }
 
     @Override
     public Publisher<Void> emit(String domain, CloudEvent event) {
-        throw new UnsupportedOperationException("Not implemented yet");
+        throw new UnsupportedOperationException(NOT_IMPLEMENTED_YET);
     }
 
     @Override
     public Publisher<Void> emit(RawMessage rawEvent) {
         return sender.sendWithConfirm(rawEvent, exchange, rawEvent.getType(),
                         Collections.emptyMap(), persistentEvents)
-                .onErrorMap(err -> new RuntimeException("Event send failure: " + rawEvent.getType(), err));
+                .onErrorMap(err -> new RuntimeException(EVENT_SEND_FAILURE + rawEvent.getType(), err));
     }
 
     @Override
     public Publisher<Void> emit(String domain, RawMessage event) {
-        throw new UnsupportedOperationException("Not implemented yet");
+        throw new UnsupportedOperationException(NOT_IMPLEMENTED_YET);
     }
 }

starters/async-commons-starter/src/main/java/org/reactivecommons/async/starter/senders/GenericDomainEventBus.java

@@ -15,6 +15,7 @@
 
 @RequiredArgsConstructor
 public class GenericDomainEventBus implements DomainEventBus {
+    private static final String DOMAIN_NOT_FOUND = "Domain not found: ";
     private final ConcurrentMap<String, DomainEventBus> domainEventBuses;
 
 
@@ -27,7 +28,7 @@ public <T> Publisher<Void> emit(DomainEvent<T> event) {
     public <T> Publisher<Void> emit(String domain, DomainEvent<T> event) {
         DomainEventBus domainEventBus = domainEventBuses.get(domain);
         if (domainEventBus == null) {
-            return Mono.error(() -> new InvalidConfigurationException("Domain not found: " + domain));
+            return Mono.error(() -> new InvalidConfigurationException(DOMAIN_NOT_FOUND + domain));
         }
         return domainEventBus.emit(event);
     }
@@ -41,7 +42,7 @@ public Publisher<Void> emit(CloudEvent event) {
     public Publisher<Void> emit(String domain, CloudEvent event) {
         DomainEventBus domainEventBus = domainEventBuses.get(domain);
         if (domainEventBus == null) {
-            return Mono.error(() -> new InvalidConfigurationException("Domain not found: " + domain));
+            return Mono.error(() -> new InvalidConfigurationException(DOMAIN_NOT_FOUND + domain));
         }
         return domainEventBus.emit(event);
     }
@@ -55,7 +56,7 @@ public Publisher<Void> emit(RawMessage event) {
     public Publisher<Void> emit(String domain, RawMessage event) {
         DomainEventBus domainEventBus = domainEventBuses.get(domain);
         if (domainEventBus == null) {
-            return Mono.error(() -> new InvalidConfigurationException("Domain not found: " + domain));
+            return Mono.error(() -> new InvalidConfigurationException(DOMAIN_NOT_FOUND + domain));
         }
         return domainEventBus.emit(event);
     }