Skip to content

Commit 20cbcee

Browse files
committed
Added missing dependencies for stylus (fixes #170), moved additional deps to devDependencies when installing
1 parent e74b89d commit 20cbcee

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# generator-react-webpack - Changelog
22

3+
## 3.1.1
4+
5+
1. Added bugfix for https://github.com/newtriks/generator-react-webpack/issues/170
6+
37
## 3.1.0
48

59
1. Added support for postcss (Patch provided by [stylesuxx](https://github.com/stylesuxx))

generators/app/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ module.exports = generator.Base.extend({
8383
if(styleConfig && styleConfig.packages) {
8484

8585
for(let dependency of styleConfig.packages) {
86-
packageSettings.dependencies[dependency.name] = dependency.version;
86+
packageSettings.devDependencies[dependency.name] = dependency.version;
8787
}
8888
}
8989

@@ -92,7 +92,7 @@ module.exports = generator.Base.extend({
9292
if(this.postcss && postcssConfig && postcssConfig.packages) {
9393

9494
for(let dependency of postcssConfig.packages) {
95-
packageSettings.dependencies[dependency.name] = dependency.version;
95+
packageSettings.devDependencies[dependency.name] = dependency.version;
9696
}
9797
}
9898

utils/configopts.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,9 @@
9090
"value": "stylus",
9191
"suffix": ".styl",
9292
"packages": [
93-
{ "name": "stylus-loader", "version": "^0.5.0" }
93+
{ "name": "stylus-loader", "version": "^0.5.0" },
94+
{ "name": "stylus", "version": "~0.49.2" },
95+
{ "name": "nib", "version": "~1.0.4" }
9496
]
9597
}
9698
],

0 commit comments

Comments
 (0)