Skip to content

Commit b4b6deb

Browse files
authored
Notify success on Discord (#35)
1 parent b0f548c commit b4b6deb

File tree

3 files changed

+8
-15
lines changed

3 files changed

+8
-15
lines changed

.github/workflow-scripts/__tests__/notifyDiscord-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@ describe('prepareFailurePayload', () => {
1919
const message = prepareFailurePayload(undefined);
2020
expect(message).toEqual({
2121
content:
22-
'⚠️ **React Native Nightly Integration Failures** ⚠️\n\nNo failures to report.',
22+
' **React Native Nightly Integration Success** \n\nAll builds are green on both platforms.',
2323
});
2424
});
2525

2626
it('should handle empty failures array', () => {
2727
const message = prepareFailurePayload([]);
2828
expect(message).toEqual({
2929
content:
30-
'⚠️ **React Native Nightly Integration Failures** ⚠️\n\nNo failures to report.',
30+
' **React Native Nightly Integration Success** \n\nAll builds are green on both platforms.',
3131
});
3232
});
3333

.github/workflow-scripts/collectNightlyOutcomes.js

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -92,11 +92,6 @@ async function notifyDiscord(webHook, failures) {
9292
return;
9393
}
9494

95-
if (!failures || failures.length === 0) {
96-
console.log('No failures to report to Discord');
97-
return;
98-
}
99-
10095
try {
10196
// Use the prepareFailurePayload function to format the message
10297
const message = prepareFailurePayload(failures);
@@ -114,13 +109,11 @@ async function collectResults(discordWebHook) {
114109
const failures = printFailures(outcomes);
115110

116111
// Send failure notification if there are current failures
117-
if (failures.length > 0) {
118-
if (discordWebHook) {
119-
console.log('Sending current failures to Discord...');
120-
await notifyDiscord(discordWebHook, failures);
121-
} else {
122-
console.log('Discord webhook not set');
123-
}
112+
if (discordWebHook) {
113+
console.log('Sending current failures to Discord...');
114+
await notifyDiscord(discordWebHook, failures);
115+
} else {
116+
console.log('Discord webhook not set');
124117
}
125118

126119
// Initialize Firebase client

.github/workflow-scripts/notifyDiscord.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ function prepareFailurePayload(failures) {
7171
if (!failures || failures.length === 0) {
7272
return {
7373
content:
74-
'⚠️ **React Native Nightly Integration Failures** ⚠️\n\nNo failures to report.',
74+
' **React Native Nightly Integration Success** \n\nAll builds are green on both platforms.',
7575
};
7676
}
7777

0 commit comments

Comments
 (0)