Skip to content

Commit bea8455

Browse files
committed
fix(apple): backwards compatibility
1 parent 15815c7 commit bea8455

File tree

4 files changed

+53
-41
lines changed

4 files changed

+53
-41
lines changed

examples/react-native/ios/Podfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
PODS:
2-
- AsyncStorage (3.0.0):
2+
- AsyncStorage (2.2.0):
33
- DoubleConversion
44
- glog
55
- hermes-engine
@@ -2023,7 +2023,7 @@ EXTERNAL SOURCES:
20232023
:path: "../node_modules/react-native/ReactCommon/yoga"
20242024

20252025
SPEC CHECKSUMS:
2026-
AsyncStorage: 252b24e7093dc051978e2cc9d0b73b0868ab9b0f
2026+
AsyncStorage: 4b7c60df2215d851c02365540b8da2ecd8bd20ae
20272027
boost: 7e761d76ca2ce687f7cc98e698152abd03a18f90
20282028
DoubleConversion: cb417026b2400c8f53ae97020b2be961b59470cb
20292029
fast_float: 06eeec4fe712a76acc9376682e4808b05ce978b6

examples/react-native/macos/Podfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
PODS:
2-
- AsyncStorage (3.0.0):
2+
- AsyncStorage (2.2.0):
33
- DoubleConversion
44
- glog
55
- hermes-engine
@@ -2023,7 +2023,7 @@ EXTERNAL SOURCES:
20232023
:path: "../node_modules/react-native-macos/ReactCommon/yoga"
20242024

20252025
SPEC CHECKSUMS:
2026-
AsyncStorage: 252b24e7093dc051978e2cc9d0b73b0868ab9b0f
2026+
AsyncStorage: 4b7c60df2215d851c02365540b8da2ecd8bd20ae
20272027
boost: 7d49a506d1ac47358fea28558d184dd6431170ca
20282028
DoubleConversion: 10f51d3e1238973c033faac2d84c0ea114942f53
20292029
fast_float: 44983b3bddb2d2ed3021a98be86f60ec8abc9ffd

packages/async-storage/apple/AsyncStorage.h

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1-
#import <AsyncStorageSpec/AsyncStorageSpec.h>
2-
31
#import <React/RCTBridgeModule.h>
42

3+
#ifdef RCT_NEW_ARCH_ENABLED
4+
#import <AsyncStorageSpec/AsyncStorageSpec.h>
5+
#endif
6+
57
@interface AsyncStorage : NSObject <
68
#ifdef RCT_NEW_ARCH_ENABLED
79
NativeAsyncStorageSpec

packages/async-storage/apple/AsyncStorage.mm

Lines changed: 45 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -6,48 +6,52 @@
66
@implementation AsyncStorage
77
RCT_EXPORT_MODULE(RNAsyncStorage)
88

9-
- (void)getValues:(nonnull NSString *)dbName
10-
keys:(nonnull NSArray *)keys
11-
resolve:(nonnull RCTPromiseResolveBlock)resolve
12-
reject:(nonnull RCTPromiseRejectBlock)reject
9+
RCT_EXPORT_METHOD(getValues
10+
: (nonnull NSString *)dbName keys
11+
: (nonnull NSArray *)keys resolve
12+
: (RCTPromiseResolveBlock)resolve reject
13+
: (RCTPromiseRejectBlock)reject)
1314
{
14-
1515
RNStorage *db = [StorageRegistry.shared getRNStorageWithDbName:dbName];
1616
[db getWithKeys:keys resolver:resolve rejecter:reject];
1717
}
1818

19-
- (void)setValues:(nonnull NSString *)dbName
20-
values:(nonnull NSArray<NSDictionary *> *)values
21-
resolve:(nonnull RCTPromiseResolveBlock)resolve
22-
reject:(nonnull RCTPromiseRejectBlock)reject
19+
RCT_EXPORT_METHOD(setValues
20+
: (nonnull NSString *)dbName values
21+
: (nonnull NSArray<NSDictionary *> *)values resolve
22+
: (nonnull RCTPromiseResolveBlock)resolve reject
23+
: (nonnull RCTPromiseRejectBlock)reject)
2324
{
2425

2526
RNStorage *db = [StorageRegistry.shared getRNStorageWithDbName:dbName];
2627
[db setWithValues:values resolver:resolve rejecter:reject];
2728
}
2829

29-
- (void)removeValues:(nonnull NSString *)dbName
30-
keys:(nonnull NSArray *)keys
31-
resolve:(nonnull RCTPromiseResolveBlock)resolve
32-
reject:(nonnull RCTPromiseRejectBlock)reject
30+
RCT_EXPORT_METHOD(removeValues
31+
: (nonnull NSString *)dbName keys
32+
: (nonnull NSArray *)keys resolve
33+
: (nonnull RCTPromiseResolveBlock)resolve reject
34+
: (nonnull RCTPromiseRejectBlock)reject)
3335
{
3436

3537
RNStorage *db = [StorageRegistry.shared getRNStorageWithDbName:dbName];
3638
[db removeWithKeys:keys resolver:resolve rejecter:reject];
3739
}
3840

39-
- (void)clearStorage:(nonnull NSString *)dbName
40-
resolve:(nonnull RCTPromiseResolveBlock)resolve
41-
reject:(nonnull RCTPromiseRejectBlock)reject
41+
RCT_EXPORT_METHOD(clearStorage
42+
: (nonnull NSString *)dbName resolve
43+
: (nonnull RCTPromiseResolveBlock)resolve reject
44+
: (nonnull RCTPromiseRejectBlock)reject)
4245
{
4346

4447
RNStorage *db = [StorageRegistry.shared getRNStorageWithDbName:dbName];
4548
[db clearWithResolver:resolve rejecter:reject];
4649
}
4750

48-
- (void)getKeys:(nonnull NSString *)dbName
49-
resolve:(nonnull RCTPromiseResolveBlock)resolve
50-
reject:(nonnull RCTPromiseRejectBlock)reject
51+
RCT_EXPORT_METHOD(getKeys
52+
: (nonnull NSString *)dbName resolve
53+
: (nonnull RCTPromiseResolveBlock)resolve reject
54+
: (nonnull RCTPromiseRejectBlock)reject)
5155
{
5256

5357
RNStorage *db = [StorageRegistry.shared getRNStorageWithDbName:dbName];
@@ -56,9 +60,10 @@ - (void)getKeys:(nonnull NSString *)dbName
5660

5761
#pragma mark - Legacy Storage
5862

59-
- (void)legacy_multiGet:(nonnull NSArray *)keys
60-
resolve:(nonnull RCTPromiseResolveBlock)resolve
61-
reject:(nonnull RCTPromiseRejectBlock)reject
63+
RCT_EXPORT_METHOD(legacy_multiGet
64+
: (nonnull NSArray *)keys resolve
65+
: (nonnull RCTPromiseResolveBlock)resolve reject
66+
: (nonnull RCTPromiseRejectBlock)reject)
6267
{
6368
RNCAsyncStorage *legacy = [RNCAsyncStorage sharedInstance];
6469

@@ -87,9 +92,10 @@ - (void)legacy_multiGet:(nonnull NSArray *)keys
8792
});
8893
}
8994

90-
- (void)legacy_multiSet:(nonnull NSArray *)kvPairs
91-
resolve:(nonnull RCTPromiseResolveBlock)resolve
92-
reject:(nonnull RCTPromiseRejectBlock)reject
95+
RCT_EXPORT_METHOD(legacy_multiSet
96+
: (nonnull NSArray *)kvPairs resolve
97+
: (nonnull RCTPromiseResolveBlock)resolve reject
98+
: (nonnull RCTPromiseRejectBlock)reject)
9399
{
94100
RNCAsyncStorage *legacy = [RNCAsyncStorage sharedInstance];
95101

@@ -110,9 +116,10 @@ - (void)legacy_multiSet:(nonnull NSArray *)kvPairs
110116
});
111117
}
112118

113-
- (void)legacy_multiRemove:(nonnull NSArray *)keys
114-
resolve:(nonnull RCTPromiseResolveBlock)resolve
115-
reject:(nonnull RCTPromiseRejectBlock)reject
119+
RCT_EXPORT_METHOD(legacy_multiRemove
120+
: (nonnull NSArray *)keys resolve
121+
: (nonnull RCTPromiseResolveBlock)resolve reject
122+
: (nonnull RCTPromiseRejectBlock)reject)
116123
{
117124
RNCAsyncStorage *legacy = [RNCAsyncStorage sharedInstance];
118125

@@ -130,8 +137,9 @@ - (void)legacy_multiRemove:(nonnull NSArray *)keys
130137
});
131138
}
132139

133-
- (void)legacy_getAllKeys:(nonnull RCTPromiseResolveBlock)resolve
134-
reject:(nonnull RCTPromiseRejectBlock)reject
140+
RCT_EXPORT_METHOD(legacy_getAllKeys
141+
: (nonnull RCTPromiseResolveBlock)resolve reject
142+
: (nonnull RCTPromiseRejectBlock)reject)
135143
{
136144
RNCAsyncStorage *legacy = [RNCAsyncStorage sharedInstance];
137145

@@ -149,8 +157,9 @@ - (void)legacy_getAllKeys:(nonnull RCTPromiseResolveBlock)resolve
149157
});
150158
}
151159

152-
- (void)legacy_clear:(nonnull RCTPromiseResolveBlock)resolve
153-
reject:(nonnull RCTPromiseRejectBlock)reject
160+
RCT_EXPORT_METHOD(legacy_clear
161+
: (nonnull RCTPromiseResolveBlock)resolve reject
162+
: (nonnull RCTPromiseRejectBlock)reject)
154163
{
155164

156165
RNCAsyncStorage *legacy = [RNCAsyncStorage sharedInstance];
@@ -169,9 +178,10 @@ - (void)legacy_clear:(nonnull RCTPromiseResolveBlock)resolve
169178
});
170179
}
171180

172-
- (void)legacy_multiMerge:(nonnull NSArray *)kvPairs
173-
resolve:(nonnull RCTPromiseResolveBlock)resolve
174-
reject:(nonnull RCTPromiseRejectBlock)reject
181+
RCT_EXPORT_METHOD(legacy_multiMerge
182+
: (nonnull NSArray *)kvPairs resolve
183+
: (nonnull RCTPromiseResolveBlock)resolve reject
184+
: (nonnull RCTPromiseRejectBlock)reject)
175185
{
176186
// merge is removed
177187
resolve(nil);

0 commit comments

Comments
 (0)