chore: bump @rnx-kit/eslint-plugin to 0.6.0 (#1037)

Author: tido64

package.json

@@ -6,7 +6,6 @@
   ],
   "packageManager": "yarn@3.4.1",
   "devDependencies": {
-    "@rnx-kit/eslint-plugin": "^0.5.0",
     "eslint": "^8.54.0",
     "prettier": "^2.8.8",
     "typescript": "^5.3.0"

packages/api/example/ExampleExtension.ts

@@ -1,4 +1,4 @@
-import { StorageExtension } from "../src";
+import type { StorageExtension } from "../src";
 
 export interface MyExampleExtension extends StorageExtension {
   double: (num: number) => Promise<number>;

packages/api/example/ExampleStorage.ts

@@ -1,15 +1,14 @@
-import { AsyncStorage, StorageKeys, StorageModel } from "../src";
-import { ExampleExtension, MyExampleExtension } from "./ExampleExtension";
+import type { AsyncStorage, StorageKeys, StorageModel } from "../src";
+import type { MyExampleExtension } from "./ExampleExtension";
+import { ExampleExtension } from "./ExampleExtension";
 
 type MyModel = StorageModel<{
   age: number;
   name: string;
   likes: boolean[];
 }>;
 
-// @ts-ignore
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-class ExampleStorage implements AsyncStorage<MyModel, MyExampleExtension> {
+export class ExampleStorage implements AsyncStorage<MyModel, MyExampleExtension> {
   private storage: MyModel = {
     age: null,
     name: null,

packages/api/package.json

@@ -16,7 +16,7 @@
   "scripts": {
     "prepack": "yarn build",
     "build": "bob build",
-    "test:lint": "eslint src/**",
+    "test:lint": "eslint $(git ls-files '*.js' '*.ts' '*.tsx')",
     "test:ts": "tsc --noEmit",
     "test:jest": "jest"
   },

packages/default-storage/example/examples/Basic.tsx

@@ -1,4 +1,4 @@
-// @ts-ignore
+// @ts-expect-error cannot find module
 import AsyncStorage from "@react-native-async-storage/async-storage";
 import React from "react";
 import {

packages/default-storage/example/examples/Functional.tsx

@@ -1,4 +1,4 @@
-// @ts-ignore
+// @ts-expect-error cannot find module
 import AsyncStorage from "@react-native-async-storage/async-storage";
 import React, { useEffect, useState } from "react";
 import isEqual from "lodash/isEqual";
@@ -23,6 +23,18 @@ type TestResult =
       actual?: string | null;
     };
 
+function isTestResult(result: unknown): result is TestResult {
+  return (
+    result === SKIP_TEST ||
+    Boolean(
+      result &&
+        typeof result === "object" &&
+        "step" in result &&
+        "expected" in result
+    )
+  );
+}
+
 function compare(expected: TestValue, actual: string): boolean {
   return typeof expected === "string"
     ? expected === actual
@@ -105,7 +117,11 @@ function Functional(): JSX.Element {
           try {
             await execute(test);
             testResults.push([name, undefined]);
-          } catch (e: any) {
+          } catch (e: unknown) {
+            if (!isTestResult(e)) {
+              throw e;
+            }
+
             testResults.push([name, e]);
           }
         }
@@ -140,7 +156,11 @@ function Functional(): JSX.Element {
           try {
             await execute(test);
             testResults.push([name, undefined]);
-          } catch (e: any) {
+          } catch (e: unknown) {
+            if (!isTestResult(e)) {
+              throw e;
+            }
+
             testResults.push([name, e]);
             await new Promise((resolve) => {
               AsyncStorageTestSupport.test_unsetDelegate(resolve);

packages/default-storage/example/examples/GetSetClear.tsx

@@ -5,7 +5,7 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-// @ts-ignore
+// @ts-expect-error cannot find module
 import AsyncStorage from "@react-native-async-storage/async-storage";
 import React from "react";
 import { Button, StyleSheet, Text, View } from "react-native";

packages/default-storage/example/examples/MergeItem.tsx

@@ -5,7 +5,7 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-// @ts-ignore
+// @ts-expect-error cannot find module
 import AsyncStorage from "@react-native-async-storage/async-storage";
 import React, { useCallback, useState } from "react";
 import {

packages/default-storage/package.json

@@ -55,7 +55,7 @@
     "bundle:ios": "scripts/ios_e2e.sh 'bundle'",
     "bundle:macos": "react-native bundle --entry-file index.ts --platform macos --dev false --bundle-output example/index.macos.jsbundle",
     "test": "concurrently -n lint,ts yarn:test:lint yarn:test:ts",
-    "test:lint": "eslint src/**/*.ts example/**/*.ts jest/*.js",
+    "test:lint": "eslint $(git ls-files '*.js' '*.ts' '*.tsx')",
     "test:ts": "tsc",
     "test:e2e:android": "scripts/android_e2e.sh 'test'",
     "test:e2e:ios": "scripts/ios_e2e.sh 'test'",

packages/eslint-config/index.js

@@ -1,9 +1 @@
-const { FlatCompat } = require("@eslint/eslintrc");
-const js = require("@eslint/js");
-
-const compat = new FlatCompat({
-  baseDirectory: __dirname,
-  recommendedConfig: js.configs.recommended,
-});
-
-module.exports = compat.extends("plugin:@rnx-kit/recommended");
+module.exports = require("@rnx-kit/eslint-plugin/recommended");