🚨 Remove jsx-wrap-multiline due to false positive

Nuhvi · Nuhvi · commit 7aec80c31e37 · 2020-02-16T11:28:28.000+03:00
diff --git a/app/components/Button/tests/index.test.tsx b/app/components/Button/tests/index.test.tsx
@@ -12,7 +12,6 @@ const href = 'http://mxstbr.com';
 const children = <h1>Test</h1>;
 const renderComponent = (props: Props & { type?: any } = {}) => {
   const utils = render(
-    // tslint:disable-next-line: jsx-wrap-multiline
     <Button href={href} {...props}>
       {children}
     </Button>,
diff --git a/app/components/Footer/tests/index.test.tsx b/app/components/Footer/tests/index.test.tsx
@@ -17,7 +17,6 @@ describe('<Footer />', () => {
   it('should render and match the snapshot', () => {
     const renderedComponent = renderer
       .create(
-        // tslint:disable-next-line: jsx-wrap-multiline
         <Provider store={store}>
           <IntlProvider locale="en">
             <Footer />
diff --git a/app/components/Header/tests/index.test.tsx b/app/components/Header/tests/index.test.tsx
@@ -14,7 +14,6 @@ describe('<Header />', () => {
 
   it('should render a div', () => {
     const { container } = render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <IntlProvider locale="en">
           <ConnectedRouter history={history}>
diff --git a/app/components/ReposList/tests/index.test.tsx b/app/components/ReposList/tests/index.test.tsx
@@ -16,7 +16,6 @@ describe('<ReposList />', () => {
 
   it('should render an error if loading failed', () => {
     const { queryByText } = render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <IntlProvider locale="en">
         <ReposList loading={false} error={{ message: 'Loading failed!' }} />
       </IntlProvider>,
@@ -52,7 +51,6 @@ describe('<ReposList />', () => {
       },
     ] as Repo[];
     const { container } = render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <IntlProvider locale="en">
           <ReposList repos={repos} error={false} loading={false}/>
diff --git a/app/components/Toggle/tests/index.test.tsx b/app/components/Toggle/tests/index.test.tsx
@@ -19,7 +19,6 @@ describe('<Toggle />', () => {
       },
     });
     const { container } = render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <IntlProvider locale="en">
         <Toggle values={['en', 'de']} messages={messages} />
       </IntlProvider>,
diff --git a/app/components/ToggleOption/tests/index.test.tsx b/app/components/ToggleOption/tests/index.test.tsx
@@ -14,7 +14,6 @@ describe('<ToggleOption />', () => {
       },
     });
     const { container } = render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <IntlProvider locale="en">
         <ToggleOption value="en" message={message.enMessage} />
       </IntlProvider>,
@@ -24,7 +23,6 @@ describe('<ToggleOption />', () => {
 
   it('should display `value`(two letter language code) when `message` is absent', () => {
     const { queryByText } = render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <IntlProvider locale="de">
         <ToggleOption value="de" />
       </IntlProvider>,
diff --git a/app/containers/FeaturePage/tests/index.test.tsx b/app/containers/FeaturePage/tests/index.test.tsx
@@ -9,7 +9,6 @@ describe('<FeaturePage />', () => {
     const {
       container: { firstChild },
     } = render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <IntlProvider locale="en">
         <FeaturePage />
       </IntlProvider>,
diff --git a/app/containers/HomePage/tests/index.test.tsx b/app/containers/HomePage/tests/index.test.tsx
@@ -18,7 +18,6 @@ jest.mock('containers/App/actions');
 
 const renderHomePage = store =>
   render(
-    // tslint:disable-next-line: jsx-wrap-multiline
     <Provider store={store}>
       <IntlProvider locale="en">
         <HomePage />
diff --git a/app/containers/LanguageProvider/tests/index.test.tsx b/app/containers/LanguageProvider/tests/index.test.tsx
@@ -28,7 +28,6 @@ describe('<LanguageProvider />', () => {
     const text = 'Test';
     const children = <h1>{text}</h1>;
     const { queryByText } = render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <LanguageProvider messages={messages}>
           {children}
@@ -40,7 +39,6 @@ describe('<LanguageProvider />', () => {
 
   it('should render the default language messages', () => {
     const { queryByText } = render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <LanguageProvider messages={translationMessages}>
           <FormattedMessage {...messages.someMessage} />
diff --git a/app/containers/LocaleToggle/tests/index.test.tsx b/app/containers/LocaleToggle/tests/index.test.tsx
@@ -27,7 +27,6 @@ describe('<LocaleToggle />', () => {
 
   it('should match the snapshot', () => {
     const { container } = render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <LanguageProvider messages={translationMessages}>
           <LocaleToggle />
@@ -39,7 +38,6 @@ describe('<LocaleToggle />', () => {
 
   it('should present the default `en` english language option', () => {
     const { queryByDisplayValue } = render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <LanguageProvider messages={translationMessages}>
           <LocaleToggle />
@@ -51,7 +49,6 @@ describe('<LocaleToggle />', () => {
 
   it('should dispatch changeLocale when user selects a new option', () => {
     const { container } = render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <LanguageProvider messages={translationMessages}>
           <LocaleToggle />
diff --git a/app/containers/NotFoundPage/tests/index.test.tsx b/app/containers/NotFoundPage/tests/index.test.tsx
@@ -12,7 +12,6 @@ import messages from '../messages';
 describe('<NotFound />', () => {
   it('should render the Page Not Found text', () => {
     const { queryByText } = render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <IntlProvider locale="en">
         <NotFound />
       </IntlProvider>,
diff --git a/app/containers/RepoListItem/tests/index.test.tsx b/app/containers/RepoListItem/tests/index.test.tsx
@@ -26,7 +26,6 @@ const renderComponent = (item, currentUser) => {
     initialState, history);
 
   return render(
-    // tslint:disable-next-line: jsx-wrap-multiline
     <Provider store={store}>
       <IntlProvider locale="en">
         <RepoListItem item={item} />
diff --git a/app/utils/tests/injectReducer.test.tsx b/app/utils/tests/injectReducer.test.tsx
@@ -108,7 +108,6 @@ describe('useInjectReducer hook', () => {
 
   it('should inject a given reducer', () => {
     render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <ComponentWithReducer />
       </Provider>,
diff --git a/app/utils/tests/injectSaga.test.tsx b/app/utils/tests/injectSaga.test.tsx
@@ -54,7 +54,6 @@ describe('injectSaga decorator', () => {
   it('should inject given saga, mode, and props', () => {
     const props = { test: 'test' };
     renderer.create(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <ComponentWithSaga {...props} />
       </Provider>,
@@ -71,7 +70,6 @@ describe('injectSaga decorator', () => {
   it('should eject on unmount with a correct saga key', () => {
     const props = { test: 'test' };
     const renderedComponent = renderer.create(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <ComponentWithSaga {...props} />
       </Provider>,
@@ -92,7 +90,6 @@ describe('injectSaga decorator', () => {
   it('should propagate props', () => {
     const props = { testProp: 'test' };
     const renderedComponent = renderer.create(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <ComponentWithSaga {...props} />
       </Provider>,
@@ -136,7 +133,6 @@ describe('useInjectSaga hook', () => {
   it('should inject given saga and mode', () => {
     const props = { test: 'test' };
     render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <ComponentWithSaga {...props} />
       </Provider>,
@@ -152,7 +148,6 @@ describe('useInjectSaga hook', () => {
   it('should eject on unmount with a correct saga key', () => {
     const props = { test: 'test' };
     const { unmount } = render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <ComponentWithSaga {...props} />
       </Provider>,
diff --git a/internals/generators/container/index.js b/internals/generators/container/index.js
@@ -187,14 +187,14 @@ module.exports = {
       actions.push({
         type: 'modify',
         path: '../../app/types/index.d.ts',
-        pattern: new RegExp(/.*\/\/.*\[IMPORT NEW CONTAINERSTATE ABOVE\].+\n\n*/),
+        pattern: new RegExp(/.*\/\/.*\[IMPORT NEW CONTAINERSTATE ABOVE\].+\n/),
         templateFile: './container/importContainerState.hbs',
         abortOnFail: true,
       });
       actions.push({
         type: 'modify',
         path: '../../app/types/index.d.ts',
-        pattern: new RegExp(/.*\/\/.*\[INSERT NEW REDUCER KEY ABOVE\].+\n\n*/),
+        pattern: new RegExp(/.*\/\/.*\[INSERT NEW REDUCER KEY ABOVE\].+\n/),
         templateFile: './container/appendApplicationRootState.hbs',
         abortOnFail: true,
       });
diff --git a/internals/templates/containers/HomePage/tests/index.test.tsx b/internals/templates/containers/HomePage/tests/index.test.tsx
@@ -13,7 +13,6 @@ describe('<HomePage />', () => {
     const {
       container: { firstChild },
     } = render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <IntlProvider locale="en">
         <HomePage />
       </IntlProvider>,
diff --git a/internals/templates/containers/NotFoundPage/tests/index.test.tsx b/internals/templates/containers/NotFoundPage/tests/index.test.tsx
@@ -12,7 +12,6 @@ describe('<NotFound />', () => {
     const {
       container: { firstChild },
     } = render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <IntlProvider locale="en">
         <NotFound />
       </IntlProvider>,
diff --git a/internals/templates/utils/tests/injectReducer.test.tsx b/internals/templates/utils/tests/injectReducer.test.tsx
@@ -111,7 +111,6 @@ describe('useInjectReducer hook', () => {
 
   it('should inject a given reducer', () => {
     render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <ComponentWithReducer />
       </Provider>,
diff --git a/internals/templates/utils/tests/injectSaga.test.tsx b/internals/templates/utils/tests/injectSaga.test.tsx
@@ -54,7 +54,6 @@ describe('injectSaga decorator', () => {
   it('should inject given saga, mode, and props', () => {
     const props = { test: 'test' };
     renderer.create(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <ComponentWithSaga {...props} />
       </Provider>,
@@ -71,7 +70,6 @@ describe('injectSaga decorator', () => {
   it('should eject on unmount with a correct saga key', () => {
     const props = { test: 'test' };
     const renderedComponent = renderer.create(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <ComponentWithSaga {...props} />
       </Provider>,
@@ -92,7 +90,6 @@ describe('injectSaga decorator', () => {
   it('should propagate props', () => {
     const props = { testProp: 'test' };
     const renderedComponent = renderer.create(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <ComponentWithSaga {...props} />
       </Provider>,
@@ -135,7 +132,6 @@ describe('useInjectSaga hook', () => {
   it('should inject given saga and mode', () => {
     const props = { test: 'test' };
     render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <ComponentWithSaga {...props} />
       </Provider>,
@@ -151,7 +147,6 @@ describe('useInjectSaga hook', () => {
   it('should eject on unmount with a correct saga key', () => {
     const props = { test: 'test' };
     const { unmount } = render(
-      // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <ComponentWithSaga {...props} />
       </Provider>,
diff --git a/tslint.json b/tslint.json
@@ -23,7 +23,8 @@
     "no-implicit-dependencies": false,
     "no-submodule-imports": false,
     "no-empty": false,
-    "jsx-alignment": false
+    "jsx-alignment": false,
+    "jsx-wrap-multiline": false
   },
   "linterOptions": {
     "exclude": ["**/*.js"]
