Merge pull request #66 from react-boilerplate/dev

React Boilerplate Typescript v4.1

Author: Can-Sahin

.all-contributorsrc

@@ -1,6 +1,6 @@
 {
-  "projectName": "react-boilerplate",
-  "projectOwner": "react-boilerplate",
+  "projectName": "react-boilerplate-typescript",
+  "projectOwner": "react-boilerplate-typescript",
   "repoType": "github",
   "repoHost": "https://github.com",
   "files": [
@@ -10,10 +10,10 @@
   "commit": true,
   "contributors": [
     {
-      "login": "mxstbr",
-      "name": "Max Stoiber",
-      "avatar_url": "https://avatars0.githubusercontent.com/u/7525670?v=4",
-      "profile": "https://mxstbr.com",
+      "login": "Can-Sahin",
+      "name": "Can Sahin",
+      "avatar_url": "https://avatars2.githubusercontent.com/u/33245689?v=4",
+      "profile": "https://github.com/Can-Sahin",
       "contributions": [
         "code",
         "doc",
@@ -23,152 +23,26 @@
       ]
     },
     {
-      "login": "julienben",
-      "name": "Julien Benchetrit",
-      "avatar_url": "https://avatars2.githubusercontent.com/u/8948127?v=4",
-      "profile": "https://julien.engineering/",
-      "contributions": [
-        "code",
-        "question",
-        "doc",
-        "review",
-        "maintenance"
-      ]
-    },
-    {
-      "login": "gretzky",
-      "name": "Sara Federico",
-      "avatar_url": "https://avatars1.githubusercontent.com/u/15176096?v=4",
-      "profile": "http://sarafederi.co",
-      "contributions": [
-        "code",
-        "review",
-        "question",
-        "doc",
-        "maintenance"
-      ]
-    },
-    {
-      "login": "justingreenberg",
-      "name": "Justin Greenberg",
-      "avatar_url": "https://avatars1.githubusercontent.com/u/1539088?v=4",
-      "profile": "https://justingreenberg.com",
+      "login": "GrayStrider",
+      "name": "Gray Strider",
+      "avatar_url": "https://avatars0.githubusercontent.com/u/43771776?s=460&v=4",
+      "profile": "https://github.com/GrayStrider",
       "contributions": [
         "code",
+        "tool",
         "review"
       ]
     },
     {
-      "login": "jwinn",
-      "name": "Jon Winn",
-      "avatar_url": "https://avatars3.githubusercontent.com/u/891726?v=4",
-      "profile": "https://github.com/jwinn",
-      "contributions": [
-        "code",
-        "review"
-      ]
-    },
-    {
-      "login": "Mensae",
-      "name": "Johan Meester",
-      "avatar_url": "https://avatars2.githubusercontent.com/u/474743?v=4",
-      "profile": "https://meester-johan.info/",
-      "contributions": [
-        "code",
-        "test",
-        "doc"
-      ]
-    },
-    {
-      "login": "Dattaya",
-      "name": "Yaroslav Kiliba",
-      "avatar_url": "https://avatars3.githubusercontent.com/u/387256?v=4",
-      "profile": "https://github.com/Dattaya",
-      "contributions": [
-        "code"
-      ]
-    },
-    {
-      "login": "gihrig",
-      "name": "Glen Ihrig",
-      "avatar_url": "https://avatars2.githubusercontent.com/u/1481063?v=4",
-      "profile": "https://github.com/gihrig",
-      "contributions": [
-        "code"
-      ]
-    },
-    {
-      "login": "somus",
-      "name": "Somasundaram Ayyappan",
-      "avatar_url": "https://avatars3.githubusercontent.com/u/1802828?v=4",
-      "profile": "https://github.com/somus",
-      "contributions": [
-        "code"
-      ]
-    },
-    {
-      "login": "oliverturner",
-      "name": "Oliver Turner",
-      "avatar_url": "https://avatars0.githubusercontent.com/u/21795?v=4",
-      "profile": "https://www.codedsignal.co.uk/",
-      "contributions": [
-        "code"
-      ]
-    },
-    {
-      "login": "samit4me",
-      "name": "Samuel Sharpe",
-      "avatar_url": "https://avatars3.githubusercontent.com/u/3248531?v=4",
-      "profile": "https://github.com/samit4me",
-      "contributions": [
-        "code"
-      ]
-    },
-    {
-      "login": "KarandikarMihir",
-      "name": "Mihir Karandikar",
-      "avatar_url": "https://avatars3.githubusercontent.com/u/17466938?v=4",
-      "profile": "https://karandikarmihir.github.io/",
-      "contributions": [
-        "code"
-      ]
-    },
-    {
-      "login": "v",
-      "name": "Vaibhav Verma",
-      "avatar_url": "https://avatars2.githubusercontent.com/u/627846?v=4",
-      "profile": "http://www.vverma.net",
-      "contributions": [
-        "code"
-      ]
-    },
-    {
-      "login": "sedubois",
-      "name": "Sébastien Dubois",
-      "avatar_url": "https://avatars1.githubusercontent.com/u/4217871?v=4",
-      "profile": "https://imagineclarity.com",
-      "contributions": [
-        "code"
-      ]
-    },
-    {
-      "login": "chaintng",
-      "name": "Chainarong Tangsurakit",
-      "avatar_url": "https://avatars2.githubusercontent.com/u/2979072?v=4",
-      "profile": "https://www.chaintng.com",
-      "contributions": [
-        "code"
-      ]
-    },
-    {
-      "login": "amilajack",
-      "name": "Amila Welihinda",
-      "avatar_url": "https://avatars1.githubusercontent.com/u/6374832?v=4",
-      "profile": "https://amilajack.com",
+      "login": "rajatkantinandi",
+      "name": "Rajat Kanti Nandi",
+      "avatar_url": "https://avatars1.githubusercontent.com/u/17743895?v=4",
+      "profile": "https://twitter.com/rajatkantinandi",
       "contributions": [
-        "code"
+        "tool"
       ]
     }
   ],
-  "contributorsPerLine": 8
+  "contributorsPerLine": 8,
+  "commitConvention": "none"
 }

.eslintignore

@@ -0,0 +1,9 @@
+internals/scripts
+internals/generators
+internals/templates
+server/
+*.html
+node_modules
+coverage
+build
+node_modules

.eslintrc.js

@@ -6,9 +6,21 @@ const prettierOptions = JSON.parse(
 );
 
 module.exports = {
-  parser: 'babel-eslint',
-  extends: ['airbnb', 'prettier', 'prettier/react'],
-  plugins: ['prettier', 'redux-saga', 'react', 'react-hooks', 'jsx-a11y'],
+  parser: '@typescript-eslint/parser',
+  extends: [
+    'airbnb-typescript',
+    'prettier',
+    'prettier/react',
+    'prettier/@typescript-eslint'
+  ],
+  plugins: [
+    'prettier',
+    'redux-saga',
+    'react',
+    'react-hooks',
+    'jsx-a11y',
+    '@typescript-eslint',
+  ],
   env: {
     jest: true,
     browser: true,
@@ -21,19 +33,47 @@ module.exports = {
     ecmaFeatures: {
       jsx: true,
     },
+    project: './tsconfig.eslint.json',
   },
   rules: {
+    'jsx-no-lambda': 0,
+    semi: [2, 'always'],
+    '@typescript-eslint/interface-name-prefix': 0,
+    '@typescript-eslint/no-empty-interface': 0,
+    'object-shorthand': [0, 'never'],
+    quotes: [2, 'single'],
+    '@typescript-eslint/no-var-requires': 0,
+    'member-ordering': 0,
+    'object-literal-sort-keys': 0,
+    'no-shadowed-variable': 0,
+    'no-consecutive-blank-lines': 0,
+    'no-string-literal': 0,
+    'jsx-no-multiline-js': 0,
+    'jsx-boolean-value': 0,
+    'arrow-parens': 0,
+    'no-implicit-dependencies': 0,
+    'no-submodule-imports': 0,
+    'no-case-declarations': 1,
+    '@typescript-eslint/no-empty-function': 0,
+    '@typescript-eslint/ban-ts-ignore': 1,
+    '@typescript-eslint/indent': 0,
+    'jsx-alignment': 0,
+    'jsx-wrap-multiline': 0,
+    '@typescript-eslint/camelcase': 0,
     'prettier/prettier': ['error', prettierOptions],
     'arrow-body-style': [2, 'as-needed'],
     'class-methods-use-this': 0,
+    'import/order': 0,
     'import/imports-first': 0,
     'import/newline-after-import': 0,
     'import/no-dynamic-require': 0,
     'import/no-extraneous-dependencies': 0,
     'import/no-named-as-default': 0,
-    'import/no-unresolved': 2,
+    'import/no-unresolved': [2, { caseSensitive: false }], // ts already checks case sensitive imports
     'import/no-webpack-loader-syntax': 0,
     'import/prefer-default-export': 0,
+    'import/no-cycle': 1,
+    'no-param-reassign': 1,
     indent: [
       2,
       2,
@@ -60,7 +100,6 @@ module.exports = {
     'newline-per-chained-call': 0,
     'no-confusing-arrow': 0,
     'no-console': 1,
-    'no-unused-vars': 2,
     'no-use-before-define': 0,
     'prefer-template': 2,
     'react/destructuring-assignment': 0,
@@ -70,7 +109,9 @@ module.exports = {
     'react/jsx-first-prop-new-line': [2, 'multiline'],
     'react/jsx-filename-extension': 0,
     'react/jsx-no-target-blank': 0,
+    'react/jsx-props-no-spreading': 0,
     'react/jsx-uses-vars': 2,
+    'react/prop-types': 0,
     'react/require-default-props': 0,
     'react/require-extension': 0,
     'react/self-closing-comp': 0,
@@ -80,10 +121,18 @@ module.exports = {
     'require-yield': 0,
   },
   settings: {
+    'import/parsers': {
+      '@typescript-eslint/parser': ['.ts', '.tsx'],
+    },
     'import/resolver': {
       webpack: {
         config: './internals/webpack/webpack.prod.babel.js',
       },
+      typescript: {
+        alwaysTryTypes: true, // always try to resolve types under `<root>@types` directory even it doesn't contain any source code, like `@types/unist`
+        directory: './tsconfig.json',
+      },
     },
+    'import/ignore': ['types'], // Weirdly eslint cannot resolve exports in types folder (try removing this later)
   },
 };

.github/CODEOWNERS

@@ -0,0 +1,2 @@
+# Global owners
+*       @Can-Sahin

.npmrc

@@ -0,0 +1 @@
+save-exact = true

.prettierrc

@@ -4,5 +4,6 @@
   "useTabs": false,
   "semi": true,
   "singleQuote": true,
-  "trailingComma": "all"
+  "trailingComma": "all",
+  "arrowParens": "avoid"
 }

.travis.yml

@@ -1,14 +1,14 @@
 language: node_js
 
 node_js:
-  - 'node'
-  - 'lts/*'
+  - "node"
+  - "lts/*"
 
 services:
   - xvfb
 
 script:
-  # - node ./internals/scripts/generate-templates-for-linting
+  - node ./internals/scripts/generate-templates-for-linting
   - npm test -- --maxWorkers=4
   - npm run build
 
@@ -20,7 +20,7 @@ notifications:
   email:
     on_failure: change
 
-after_success: 'npm run coveralls'
+after_success: "npm run coveralls"
 
 cache:
   directories: