remove lookup types, too verbose

reverted redundant destructuring aliases
optimize imports

Author: GrayStrider

app/components/List/index.tsx

@@ -3,11 +3,10 @@ import * as React from 'react';
 import Ul from './Ul';
 import Wrapper from './Wrapper';
 import { Repo } from '../../containers/RepoListItem/types';
-import { UserData } from '../../containers/App/types';
 
 interface Props {
   component: React.ComponentType<any>;
-  items?: UserData['repos'];
+  items?: Repo[];
 }
 
 function List(props: Props) {
@@ -31,5 +30,4 @@ function List(props: Props) {
   );
 }
 
-const items: UserData['repos'] = [];
 export default List;

app/components/ReposList/index.tsx

@@ -6,13 +6,9 @@ import LoadingIndicator from 'components/LoadingIndicator';
 import RepoListItem from 'containers/RepoListItem';
 import { ContainerState, UserData } from '../../containers/App/types';
 
-interface Props {
-  loading?: ContainerState['loading'];
-  error?: ContainerState['error'];
-  repos?: UserData['repos'];
-}
+export type ReposListProps = Pick<ContainerState, 'loading' | 'error'> & Pick<UserData, 'repos'>;
 
-function ReposList({ loading, error, repos }: Props) {
+function ReposList({ loading, error, repos }: ReposListProps) {
   if (loading) {
     return <List component={LoadingIndicator} />;
   }

app/components/ReposList/tests/index.test.tsx

@@ -55,7 +55,7 @@ describe('<ReposList />', () => {
       // tslint:disable-next-line: jsx-wrap-multiline
       <Provider store={store}>
         <IntlProvider locale="en">
-          <ReposList repos={repos} error={false} />
+          <ReposList repos={repos} error={false} loading={false}/>
         </IntlProvider>
       </Provider>,
     );

app/containers/App/types.d.ts

@@ -1,7 +1,7 @@
 import { ActionType } from 'typesafe-actions';
 import * as actions from './actions';
-import { ApplicationRootState } from 'types';
 import { Repo } from '../RepoListItem/types';
+import { ApplicationRootState } from '../../types';
 
 /* --- STATE --- */
 
@@ -13,7 +13,7 @@ interface AppState {
 }
 
 interface UserData {
-  readonly repos?: Repo[]; // too many fields. Won't declare them all
+  readonly repos?: Repo[];
 }
 
 

app/containers/HomePage/index.tsx

@@ -4,20 +4,15 @@
  * This is the first thing users see of our App, at the '/' route
  */
 
-import React, { useEffect, memo } from 'react';
+import React, { useEffect } from 'react';
 import { Helmet } from 'react-helmet';
 import { FormattedMessage } from 'react-intl';
-import { connect, useSelector, useDispatch } from 'react-redux';
-import { compose, Dispatch } from 'redux';
+import { useDispatch, useSelector } from 'react-redux';
 import { createStructuredSelector } from 'reselect';
 
 import { useInjectReducer } from 'utils/injectReducer';
 import { useInjectSaga } from 'utils/injectSaga';
-import {
-  makeSelectRepos,
-  makeSelectLoading,
-  makeSelectError,
-} from 'containers/App/selectors';
+import { makeSelectError, makeSelectLoading, makeSelectRepos } from 'containers/App/selectors';
 import H2 from 'components/H2';
 import ReposList from 'components/ReposList';
 import AtPrefix from './AtPrefix';