Merge pull request #60 from react-boilerplate/fix-template-generator-script

Fix template generator script

Author: Can-Sahin

.github/CODEOWNERS

@@ -0,0 +1,2 @@
+# Global owners
+*       @Can-Sahin

.travis.yml

@@ -8,7 +8,7 @@ services:
   - xvfb
 
 script:
-  # - node ./internals/scripts/generate-templates-for-linting
+  - node ./internals/scripts/generate-templates-for-linting
   - npm test -- --maxWorkers=4
   - npm run build
 

internals/generators/container/index.js

@@ -78,10 +78,10 @@ module.exports = {
     ];
 
     // If component wants tests
-    if (data.wantMessages) {
+    if (data.wantTests) {
       actions.push({
         type: 'add',
-        path: '../../app/containers/{{properCase name}}/tests/index.test.ts',
+        path: '../../app/containers/{{properCase name}}/tests/index.test.tsx',
         templateFile: './container/test.tsx.hbs',
         abortOnFail: true,
       });

internals/generators/index.js

@@ -11,6 +11,13 @@ const componentGenerator = require('./component/index.js');
 const containerGenerator = require('./container/index.js');
 const languageGenerator = require('./language/index.js');
 
+/**
+ * Every generated backup file gets this extension
+ * @type {string}
+ */
+const BACKUPFILE_EXTENSION = 'rbgen';
+
+
 module.exports = plop => {
   plop.setGenerator('component', componentGenerator);
   plop.setGenerator('container', containerGenerator);
@@ -38,4 +45,22 @@ module.exports = plop => {
     exec(`npm run prettify -- "${folderPath}"`);
     return folderPath;
   });
+  plop.setActionType('backup', (answers, config) => {
+    fs.copyFileSync(
+      path.join(__dirname, config.path, config.file),
+      path.join(
+        __dirname,
+        config.path,
+        `${config.file}.${BACKUPFILE_EXTENSION}`,
+      ),
+      'utf8',
+    );
+    return path.join(
+      __dirname,
+      config.path,
+      `${config.file}.${BACKUPFILE_EXTENSION}`,
+    );
+  });
 };
+
+module.exports.BACKUPFILE_EXTENSION = BACKUPFILE_EXTENSION;

internals/generators/language/index.js

@@ -42,13 +42,13 @@ module.exports = {
       actions.push({
         type: 'backup',
         path: '../../app',
-        file: 'i18n.js',
+        file: 'i18n.ts',
       });
 
       actions.push({
         type: 'backup',
         path: '../../app',
-        file: 'app.js',
+        file: 'app.tsx',
       });
     }
 

internals/scripts/generate-templates-for-linting.js

@@ -103,7 +103,8 @@ function reportErrors(reason) {
 function runLintingOnDirectory(relativePath) {
   return new Promise((resolve, reject) => {
     shell.exec(
-      `npm run lint:eslint "app/${relativePath}/**/**.js"`,
+      // dont run typescript typechecking here because CLI doesn't support glob pattern
+      `npm run lint:tslint "app/${relativePath}/**/**.ts*"`,
       {
         silent: true,
       },