Only use its:dir if rdf:version is 1.2

Author: rubensworks

lib/RdfXmlParser.ts

@@ -162,7 +162,7 @@ export class RdfXmlParser extends Transform implements RDF.Sink<EventEmitter, RD
    * @param activeTag The active tag.
    */
   public createLiteral(value: string, activeTag: IActiveTag): RDF.Literal {
-    return this.dataFactory.literal(value, activeTag.datatype ? activeTag.datatype : activeTag.language ? { language: activeTag.language, direction: activeTag.direction } : undefined)
+    return this.dataFactory.literal(value, activeTag.datatype ? activeTag.datatype : activeTag.language ? { language: activeTag.language, direction: activeTag.rdfVersion ? activeTag.direction : undefined } : undefined)
   }
 
   protected attachSaxListeners() {
@@ -217,6 +217,8 @@ export class RdfXmlParser extends Transform implements RDF.Sink<EventEmitter, RD
       activeTag.baseIRI = parentTag.baseIRI;
       // Also inherit triple term collection array
       activeTag.childrenTripleTerms = parentTag.childrenTripleTerms;
+      // Also RDF version
+      activeTag.rdfVersion = parentTag.rdfVersion;
     } else {
       activeTag.baseIRI = this.baseIRI;
     }
@@ -267,7 +269,7 @@ export class RdfXmlParser extends Transform implements RDF.Sink<EventEmitter, RD
     for (const attributeKey in tag.attributes) {
       const attribute = tag.attributes[attributeKey];
       if (attribute.uri === RdfXmlParser.RDF && attribute.local === 'version') {
-        this.emit('version', attribute.value);
+        this.setVersion(activeTag, attribute.value);
       } else if (parentTag && attribute.uri === RdfXmlParser.RDF) {
         switch (attribute.local) {
         case 'about':
@@ -443,7 +445,7 @@ while ${attribute.value} and ${activeSubjectValue} where found.`);
     for (const propertyAttributeKey in tag.attributes) {
       const propertyAttribute = tag.attributes[propertyAttributeKey];
       if (propertyAttribute.uri === RdfXmlParser.RDF && propertyAttribute.local === 'version') {
-        this.emit('version', propertyAttribute.value);
+        this.setVersion(activeTag, propertyAttribute.value);
       } else if (propertyAttribute.uri === RdfXmlParser.RDF) {
         switch (propertyAttribute.local) {
         case 'resource':
@@ -735,6 +737,11 @@ while ${attribute.value} and ${activeSubjectValue} where found.`);
       delete activeTag.direction;
     }
   }
+
+  private setVersion(activeTag: IActiveTag, version: string) {
+    activeTag.rdfVersion = version;
+    this.emit('version', version);
+  }
 }
 
 export interface IRdfXmlParserArgs {
@@ -796,6 +803,7 @@ export interface IActiveTag {
   childrenTagsToTripleTerms?: boolean;
   childrenTripleTerms?: RDF.Quad[];
   reifier?: RDF.NamedNode | RDF.BlankNode;
+  rdfVersion?: string;
 }
 
 export enum ParseType {

test/RdfXmlParser-test.ts

@@ -851,7 +851,8 @@ abc`)).rejects.toBeTruthy();
 <rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
             xmlns:dc="http://purl.org/dc/elements/1.1/"
             xmlns:ex="http://example.org/stuff/1.0/"
-            xmlns:its="http://www.w3.org/2005/11/its">
+            xmlns:its="http://www.w3.org/2005/11/its"
+            rdf:version="1.2">
   <rdf:Description rdf:about="http://www.w3.org/TR/rdf-syntax-grammar" xml:lang="en-us" its:dir="abc">
     <dc:title>RDF 1.1 XML Syntax</dc:title>
   </rdf:Description>
@@ -1470,7 +1471,8 @@ abc`)).rejects.toBeTruthy();
 <rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
             xmlns:dc="http://purl.org/dc/elements/1.1/"
             xmlns:ex="http://example.org/stuff/1.0/"
-            xmlns:its="http://www.w3.org/2005/11/its">
+            xmlns:its="http://www.w3.org/2005/11/its"
+            rdf:version="1.2">
   <rdf:Description rdf:about="http://www.w3.org/TR/rdf-syntax-grammar" xml:lang="en-us" its:dir="ltr">
     <dc:title>RDF 1.1 XML Syntax</dc:title>
   </rdf:Description>
@@ -1509,7 +1511,8 @@ abc`)).rejects.toBeTruthy();
 <rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
             xmlns:dc="http://purl.org/dc/elements/1.1/"
             xmlns:ex="http://example.org/stuff/1.0/"
-            xmlns:its="http://www.w3.org/2005/11/its">
+            xmlns:its="http://www.w3.org/2005/11/its"
+            rdf:version="1.2">
   <rdf:Description rdf:about="http://www.w3.org/TR/rdf-syntax-grammar" xml:lang="en-us" its:dir="ltr">
     <ex:editor>
       <rdf:Description>
@@ -1591,7 +1594,8 @@ abc`)).rejects.toBeTruthy();
 <rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
             xmlns:dc="http://purl.org/dc/elements/1.1/"
             xmlns:ex="http://example.org/stuff/1.0/"
-            xmlns:its="http://www.w3.org/2005/11/its">
+            xmlns:its="http://www.w3.org/2005/11/its"
+            rdf:version="1.2">
   <rdf:Description rdf:about="http://www.w3.org/TR/rdf-syntax-grammar">
     <dc:title xml:lang="en-us" its:dir="rtl">RDF 1.1 XML Syntax</dc:title>
   </rdf:Description>
@@ -1687,7 +1691,8 @@ abc`)).rejects.toBeTruthy();
 <rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
             xmlns:dc="http://purl.org/dc/elements/1.1/"
             xmlns:ex="http://example.org/stuff/1.0/"
-            xmlns:its="http://www.w3.org/2005/11/its">
+            xmlns:its="http://www.w3.org/2005/11/its"
+            rdf:version="1.2">
   <rdf:Description rdf:about="http://www.w3.org/TR/rdf-syntax-grammar">
     <dc:title>RDF 1.1 XML Syntax</dc:title>
     <dc:title xml:lang="en" its:dir="ltr">RDF 1.1 XML Syntax</dc:title>
@@ -1717,6 +1722,24 @@ abc`)).rejects.toBeTruthy();
             ]);
       });
 
+      // 2.8
+      it('its:dir without rdf:version', async () => {
+        const array = await parse(parser, `<?xml version="1.0" ?>
+<rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
+  xmlns:ex="http://example.org/"
+  xmlns:its="http://www.w3.org/2005/11/its"
+  its:version="2.0"
+  its:dir="ltr"
+  xml:lang="en">
+  <rdf:Description rdf:about="http://example.org/joe" ex:name="bar" />
+</rdf:RDF>`);
+        return expect(array)
+            .toBeRdfIsomorphic([
+              quad('http://example.org/joe', 'http://example.org/name',
+                  '"bar"@en'),
+            ]);
+      });
+
       // 2.9
       it('rdf:datatype on property elements', async () => {
         const array = await parse(parser, `<?xml version="1.0"?>