Merge pull request fooinha#4 from fooinha/fix/3

fooinha · web-flow · commit 32ed114a1215 · 2019-02-09T18:02:27.000Z
nginx-ssl-ja3: bad byte swap
diff --git a/src/ngx_ssl_ja3.c b/src/ngx_ssl_ja3.c
@@ -334,7 +334,7 @@ ngx_ssl_ja3(ngx_connection_t *c, ngx_pool_t *pool, ngx_ssl_ja3_t *ja3) {
         ngx_memcpy(ja3->ciphers, ciphers_out, len);
 #if NGX_HAVE_LITTLE_ENDIAN
         for (size_t i = 0; i < ja3->ciphers_sz; ++i) {
-            ja3->ciphers[i] >>=8;
+            ja3->ciphers[i] = (ja3->ciphers[i] >> 8) | (ja3->ciphers[i] << 8);
         }
 #endif
     }

Original file line number	Diff line number	Diff line change
`@@ -334,7 +334,7 @@ ngx_ssl_ja3(ngx_connection_t c, ngx_pool_t pool, ngx_ssl_ja3_t *ja3) {`
`334`	`334`	`ngx_memcpy(ja3->ciphers, ciphers_out, len);`
`335`	`335`	`#if NGX_HAVE_LITTLE_ENDIAN`
`336`	`336`	`for (size_t i = 0; i < ja3->ciphers_sz; ++i) {`
`337`		`- ja3->ciphers[i] >>=8;`
	`337`	`+ ja3->ciphers[i] = (ja3->ciphers[i] >> 8) \| (ja3->ciphers[i] << 8);`
`338`	`338`	`}`
`339`	`339`	`#endif`
`340`	`340`	`}`