Skip to content

Commit 78ab50f

Browse files
committed
changed visibility of fields for getter setter mode to 'protected'
1 parent 53becd5 commit 78ab50f

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

src/main/java/com/igormaznitsa/jbbp/compiler/conversion/JBBPToJava6Converter.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -414,8 +414,7 @@ private String makeAnonymousStructName() {
414414
}
415415

416416
private String makeModifier(final JBBPNamedFieldInfo nullableNameFieldInfo) {
417-
if (this.builder.doGettersSetters) return "private";
418-
return nullableNameFieldInfo == null ? "protected" : "public";
417+
return nullableNameFieldInfo == null || this.builder.doGettersSetters ? "protected" : "public";
419418
}
420419

421420
@Override

src/test/java/com/igormaznitsa/jbbp/compiler/conversion/JBBPToJava6ConverterCompilationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ public void testGettersSetters() throws Exception {
9898
text = JBBPToJava6Converter.makeBuilder(parser).setDoGettersSetters(true).setClassName(CLASS_NAME).build().convert();
9999

100100
assertFalse(text.contains("public byte a;"));
101-
assertTrue(text.contains("private byte a;"));
101+
assertTrue(text.contains("protected byte a;"));
102102
assertTrue(text.contains("public void setA(byte value) {"));
103103
assertTrue(text.contains("public byte getA() {"));
104104
}

0 commit comments

Comments
 (0)