refactoring

Author: raydac

jbbp/src/main/java/com/igormaznitsa/jbbp/compiler/conversion/JBBPToJavaConverter.java

@@ -1043,7 +1043,7 @@ public ExpressionEvaluatorVisitor visitEnd() {
 
       class ExprTreeItem {
 
-        Operator op;
+        final Operator op;
         Object left;
         Object right;
 

jbbp/src/main/java/com/igormaznitsa/jbbp/io/JBBPOut.java

@@ -258,9 +258,8 @@ public JBBPOut Skip(int numberOfBytes) throws IOException {
    *
    * @param value the byte outOrder to be used in next operations, must not be null
    * @return the DSL session
-   * @throws IOException it will be thrown for transport errors
    */
-  public JBBPOut ByteOrder(final JBBPByteOrder value) throws IOException {
+  public JBBPOut ByteOrder(final JBBPByteOrder value) {
     assertNotEnded();
     JBBPUtils.assertNotNull(value, "Byte order must not be null");
     if (this.processCommands) {
@@ -1021,12 +1020,11 @@ public JBBPOut Bin(final Object object) throws IOException {
    * @param customFieldWriter a custom field writer to be used for saving of
    *                          custom fields of the object, it can be null
    * @return the context
-   * @throws IOException it will be thrown for any transport error
    * @see JBBPMapper#clearFieldCache()
    * @see Bin
    * @since 1.1
    */
-  public JBBPOut Bin(final Object object, final JBBPCustomFieldWriter customFieldWriter) throws IOException {
+  public JBBPOut Bin(final Object object, final JBBPCustomFieldWriter customFieldWriter) {
     if (this.processCommands) {
       this.processObject(object, null, customFieldWriter);
     }

jbbp/src/main/java/com/igormaznitsa/jbbp/mapper/MappedFieldRecord.java

@@ -445,6 +445,7 @@ static void setFieldValue(final Object classInstance, final Method setter, final
     }
   }
 
+  @SuppressWarnings("TryWithIdenticalCatches")
   private static <T> T tryMakeInstance(
       final Class<T> type,
       final JBBPAbstractField binField,

jbbp/src/main/java/com/igormaznitsa/jbbp/utils/JBBPDslBuilder.java

@@ -2071,7 +2071,7 @@ protected static class BinFieldContainer extends BinField {
     final List<BinField> fields = new ArrayList<>();
     final Class<?> klazz;
 
-    static BinFieldContainer END_STRUCT = new BinFieldContainer(null, null);
+    static final BinFieldContainer END_STRUCT = new BinFieldContainer(null, null);
 
     BinFieldContainer(final Class<?> klazz, final Bin bin, final boolean fieldLocalAnnotation, final Field field) {
       super(bin, fieldLocalAnnotation, field);

jbbp/src/main/java/com/igormaznitsa/jbbp/utils/JBBPTextWriter.java

@@ -48,7 +48,6 @@
 import com.igormaznitsa.jbbp.model.JBBPFieldUByte;
 import com.igormaznitsa.jbbp.model.JBBPFieldUShort;
 import com.igormaznitsa.jbbp.model.JBBPNumericField;
-
 import java.io.FilterWriter;
 import java.io.IOException;
 import java.io.StringWriter;
@@ -1058,9 +1057,8 @@ public JBBPTextWriter Int(final int[] values, int off, int len) throws IOExcepti
    * Increase indent.
    *
    * @return the context
-   * @throws IOException it will be thrown for transport error
    */
-  public JBBPTextWriter IndentInc() throws IOException {
+  public JBBPTextWriter IndentInc() {
     this.indent += this.spacesInTab;
     return this;
   }
@@ -1083,9 +1081,8 @@ public JBBPTextWriter IndentInc(final int count) throws IOException {
    * Decrease indent.
    *
    * @return the context
-   * @throws IOException it will be thrown for transport error
    */
-  public JBBPTextWriter IndentDec() throws IOException {
+  public JBBPTextWriter IndentDec() {
     if (this.indent > 0) {
       this.indent = Math.max(0, this.indent - this.spacesInTab);
     }

jbbp/src/main/java/com/igormaznitsa/jbbp/utils/JBBPUtils.java

@@ -41,6 +41,7 @@ public final class JBBPUtils {
   public static final JBBPAbstractField[] ARRAY_FIELD_EMPTY = new JBBPAbstractField[0];
 
   // Don't replace by StandardCharsets for Android compatibility!
+  @SuppressWarnings("CharsetObjectCanBeUsed")
   private static final Charset CHARSET_UTF8 = Charset.forName("UTF-8");
 
   private JBBPUtils() {