Using Utils.BuildArguments to create arguments string for MSI installer causes issues so reverted that change. This fixes #664.

ravibpatel · ravibpatel · commit 8e878844719b · 2024-02-15T11:12:58.000+05:30
diff --git a/AutoUpdater.NET/DownloadUpdateDialog.cs b/AutoUpdater.NET/DownloadUpdateDialog.cs
@@ -230,18 +230,11 @@ private void WebClientOnDownloadFileCompleted(object sender, AsyncCompletedEvent
                     FileName = "msiexec"
                 };
 
-                var arguments = new Collection<string>
-                {
-                    "/i",
-                    tempPath
-                };
-
+                processStartInfo.Arguments = $"/i \"{tempPath}\"";
                 if (!string.IsNullOrEmpty(installerArgs))
                 {
-                    arguments.Add(installerArgs);
+                    processStartInfo.Arguments += $" {installerArgs}";
                 }
-
-                processStartInfo.Arguments = Utils.BuildArguments(arguments);
             }
 
             if (AutoUpdater.RunUpdateAsAdmin)

Original file line number	Diff line number	Diff line change
`@@ -230,18 +230,11 @@ private void WebClientOnDownloadFileCompleted(object sender, AsyncCompletedEvent`
`230`	`230`	`FileName = "msiexec"`
`231`	`231`	`};`
`232`	`232`
`233`		`- var arguments = new Collection<string>`
`234`		`- {`
`235`		`- "/i",`
`236`		`- tempPath`
`237`		`- };`
`238`		`-`
	`233`	`+ processStartInfo.Arguments = $"/i \"{tempPath}\"";`
`239`	`234`	`if (!string.IsNullOrEmpty(installerArgs))`
`240`	`235`	`{`
`241`		`- arguments.Add(installerArgs);`
	`236`	`+ processStartInfo.Arguments += $" {installerArgs}";`
`242`	`237`	`}`
`243`		`-`
`244`		`- processStartInfo.Arguments = Utils.BuildArguments(arguments);`
`245`	`238`	`}`
`246`	`239`
`247`	`240`	`if (AutoUpdater.RunUpdateAsAdmin)`